From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BD9F41E10; Thu, 9 Mar 2023 12:23:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D4D240ED7; Thu, 9 Mar 2023 12:23:17 +0100 (CET) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 8F620400D7 for ; Thu, 9 Mar 2023 12:23:14 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4PXRcl27tXzKmc9; Thu, 9 Mar 2023 19:23:03 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 9 Mar 2023 19:23:11 +0800 Subject: Re: [PATCH v2 1/2] build: clarify configuration without IOVA field in mbuf To: Thomas Monjalon CC: , David Marchand , Bruce Richardson , Qi Zhang , =?UTF-8?Q?Morten_Br=c3=b8rup?= , Shijith Thotton , Olivier Matz , Ruifeng Wang , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Jingjing Wu , Beilei Xing , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj , Kai Ji , Pablo de Lara , Radha Mohan Chintakuntla , Veerasenareddy Burru , Kevin Laatz , Pavan Nikhilesh , =?UTF-8?Q?Mattias_R=c3=b6nnblom?= , Liang Ma , Peter Mccarthy , Jerin Jacob , Harry van Haaren , "Artem V. Andreev" , Andrew Rybchenko , Ashwin Sekhar T K , "John W. Linville" , Ciara Loftus , Chas Williams , "Min Hu (Connor)" , Gaetan Rivet , Dongdong Liu , Yisen Zhuang , Konstantin Ananyev , Qiming Yang , Jakub Grajciar , Tetsuya Mukawa , Jakub Palider , Tomasz Duszynski , Sachin Saxena , Hemant Agrawal References: <20230219115529.3260580-1-thomas@monjalon.net> <20230306161328.3802696-2-thomas@monjalon.net> <5a0d4a65-d0d4-ed81-9f44-35ef9fd29d48@huawei.com> <1921837.PYKUYFuaPT@thomas> From: fengchengwen Message-ID: Date: Thu, 9 Mar 2023 19:23:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1921837.PYKUYFuaPT@thomas> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/3/9 15:29, Thomas Monjalon wrote: > 09/03/2023 02:43, fengchengwen: >> On 2023/3/7 0:13, Thomas Monjalon wrote: >>> --- a/doc/guides/rel_notes/release_22_11.rst >>> +++ b/doc/guides/rel_notes/release_22_11.rst >>> @@ -504,7 +504,7 @@ ABI Changes >>> ``rte-worker-`` so that DPDK can accommodate lcores higher than 99. >>> >>> * mbuf: Replaced ``buf_iova`` field with ``next`` field and added a new field >>> - ``dynfield2`` at its place in second cacheline if ``RTE_IOVA_AS_PA`` is 0. >>> + ``dynfield2`` at its place in second cacheline if ``RTE_IOVA_IN_MBUF`` is 0. >> >> Should add to release 23.03 rst. > > Yes we could add a note in API changes. > >> The original 22.11 still have RTE_IOVA_AS_PA definition. > > Yes it was not a good idea to rename in the release notes. > >>> -if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 >>> - build = false >>> - reason = 'driver does not support disabling IOVA as PA mode' >>> +if not get_option('enable_iova_as_pa') >>> subdir_done() >>> endif >> >> Suggest keep original, and replace RTE_IOVA_AS_PA with RTE_IOVA_IN_MBUF: >> if dpdk_conf.get('RTE_IOVA_IN_MBUF') == 0 >> subdir_done() >> endif > > Why testing the C macro in Meson? > It looks simpler to check the Meson option in Meson. The macro was create in meson.build: config/meson.build:319:dpdk_conf.set10('RTE_IOVA_AS_PA', get_option('enable_iova_as_pa')) It can be regarded as alias of enable_iova_as_pa. This commit was mainly used to improve comprehensibility. so we should limit the 'enable_iova_as_pa' usage scope. and the 'if dpdk_conf.get('RTE_IOVA_IN_MBUF') == 0' is more comprehensibility than 'if not get_option('enable_iova_as_pa')' > >> Meson build 0.63.0 already support deprecated a option by a new option. >> When update to the new meson verion, the drivers' meson.build will not be modified. > > I don't understand this comment. I mean: the option "enable_iova_as_pa" need deprecated future. Based on this, I think we should limit 'enable_iova_as_pa' usage scope, this allows us to reduce the amount of change effort when it's about to deprecated. > > > . >