From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7497AA00C2; Thu, 3 Feb 2022 11:58:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D851F4014F; Thu, 3 Feb 2022 11:58:18 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id F2F8940143 for ; Thu, 3 Feb 2022 11:58:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643885897; x=1675421897; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=JoKqGIrr3u8xFVAYfaEL4TCcUgjqADSpVOmkVspuN3o=; b=NKx3g+Ea0ix/xRGXde6UoeXXblmWGXgLToqCsye6Lh/AJ8pzt19KFtU5 TpFq0gs1k9lkCD/XPm6Rb1Cuzshkq/uCp2AvRYb2kg+TVf9IVnquwDvXC zcL0z7cFJds6/EOmb96j0y4j+FEHI3PqqTi3t+sg/QdRd6ylpYuV21Avu gAF9n1gqqhOI8Ohh067TziDIAn/FctPL1EdMNypm5X7OutwOWtO8RRegx FS6VeHnLA0unOoakX9vs/x5Ns4CqXxt02slEqAS/sBUKAP8ZD2KBXsRCE wx8EZdhXb6NMK9Gu7vDkd8cjyNGYjHubl0QfR8si4GSxoJdk14r384u9/ A==; X-IronPort-AV: E=McAfee;i="6200,9189,10246"; a="231690897" X-IronPort-AV: E=Sophos;i="5.88,339,1635231600"; d="scan'208";a="231690897" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2022 02:57:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,339,1635231600"; d="scan'208";a="566367353" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 03 Feb 2022 02:57:59 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 3 Feb 2022 02:57:59 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 3 Feb 2022 02:57:59 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 3 Feb 2022 02:57:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aBel3BmVGiUnybDtvSvvlMDMJntivaQyBulLMFocdiFzzKsVeW4K1WpWoEmEvp4eWO9JTjm9URZ9YfFaeRRhTNlNRxqfhISVXqyUT1S/vajpDiz4Wr8rn/xbpe3FI327muQJ7D3kY482sw3wlD/+1xNVt9K9W5tIA/A966DdZnw8tgrovWfQe6ksS3nSIao/uXrTzIZpEx+Rxr/s0DSNpmjv7KwS2UDYc2vJItZbNV+be485g4b99BqGt0ZL978RjoPkuO88u02ydUJlDK6zXPzoohwPw+RVYqw4uKk1nSRXNUBdaTEgickpW8sII0izwCDKYLFEXMaOGTMSIFRYSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R5q0EJ/N7gsADJAwArgbjfHesoOawjF3eNWNoYKKpk4=; b=RJWWyjN0EKOJcM1QIAbPWbU+4vRuD8O78dtFowlJn8UZXCVyE99q0x3coXO2mMUzO6Jq6Mq9clQJzVBvD0kuCiaD1tpFYxVmiYu5vjhiLFHrsTXJBhyOVQ3YDyx7DwtG6WpCVk6YkocRwr6n03r+D76veYMavPd3n+cIRC7McxuGGysQOq1HhsRlSEwtQ0OI2aV5g340ojjF53tlSIAGtonobo70mSns7mGckN9eBpikXl5/mCTTFDSgZthLpWYaRRXwqwOmf5B3wUv0YCKbi2nJDAXUZskjnVfo5sCGWvU8v0wk5Y2uR5C4PSDXviSmCT09wlafykR5JRzT/Gq0ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM5PR11MB1483.namprd11.prod.outlook.com (2603:10b6:4:e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.19; Thu, 3 Feb 2022 10:57:53 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022 10:57:53 +0000 Message-ID: Date: Thu, 3 Feb 2022 10:57:48 +0000 Content-Language: en-US To: Thomas Monjalon CC: , "John Daley (johndale)" , Weiguo Li References: <57f04130-427b-54e1-2384-74699b6a385d@intel.com> <2530593.7s5MMGUR32@thomas> From: Ferruh Yigit Subject: Re: [PATCH] net/enic: adjust memory check and use in proper order X-User: ferruhy In-Reply-To: <2530593.7s5MMGUR32@thomas> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P123CA0011.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3a138806-44e8-409f-f7e8-08d9e70406dd X-MS-TrafficTypeDiagnostic: DM5PR11MB1483:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:660; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6KQdbEf7jKNnXfAL+2JMKMqpxllNSGKvNJHiWtd+jni9WkioNRYSQBHWaOKcD4LprgRN1UsDNI0CpHfNLpx88vSWGOPbKuguhy1KAIouuI4wb/i2Z/CI533AMa8jJ3M5l2wx9qe2Zafm8Q7qGYxXhwgqfGXk8XnaLgpN4BQTGm/zgb57m2vvUPlsIsKNvSMDB124es9yAMjPbWAi6oo7knEVyVWUO1y5sRDXDriZs/IHl6Fxyu5h2BfPAXRpGai5kq45w9biAA4vOiVOR+fUmWTV0uJIpYrxAk2R4gVL1vBJN3wGsXAuDEGFKEeXn9jwWI9ki5FuABW3rgRnlIjPEv7s7MmgyhKmk2UO8uKycEIobljnVXVqiwZk7FSzCj4KSff9EKN1ygUXmoLdOTXS6QpN4krumD4Ib80BaCQtPEJqfZsVqwGhQCpSQoWLTGwbTS8knSIatCrQj6mCDJ267UNXOKVjfGrYF55rh7tYR3eBFMfRqWouS7fqALe7LAAvCb4Z675Vtn23vypuieNvThITgVeTbE3MFl/SoWWJkC7twKSvAi1LDbwVdKAaYwEfKKLjv75QQ35LUNRbucy9b/sjGj+5BxfXOkwRCPGg5rlpt5BMhMbMYlS2AhdjL8PSt4Sse50JhCNJycHztatS3OVSMEii8H4rjGu70EuFve/9l84nv7i/v8s7sQ0aJiEmSH6t0I6+PIUjENAeGlhDiTM8v0Eqeo00LVOCqWJUoM0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6512007)(8936002)(4326008)(66476007)(66946007)(66556008)(55236004)(8676002)(38100700002)(53546011)(316002)(6666004)(508600001)(86362001)(83380400001)(54906003)(6506007)(6486002)(6916009)(2616005)(31696002)(5660300002)(31686004)(2906002)(82960400001)(4744005)(44832011)(26005)(186003)(36756003)(48020200001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGxtcXM1YkkyY04wRytUOGtZSCtROHlFSXlVb2krMnFVYXVJalZPa1NqRlpZ?= =?utf-8?B?d2s0VzhlMk96eUpJZnk0K2JPdUxrNGMya2RnZFZXNUp6MmpvMXE3TDZSMm0r?= =?utf-8?B?Q2JJQXB3ZmpybW5vU0pDckJOMkdsSnMrc0N5WStFbUNqN2MyRjlmbnhKaFA2?= =?utf-8?B?SXRnYXhIZ2E1MGtJbFF0d1l3RktWeHlkZjc4NXpzeU51RWNINVF4WHRuZHVi?= =?utf-8?B?ZVRUKzZZYzVSNzJHZXo2am4zVzNLQ0ZKVEtQL2FKTmN5aFd3UnVCNlNzL2ps?= =?utf-8?B?cFFGWDVuekU2MkFpNXQwQUc3bGNISnFNZ3dXZTlxVWNFTmlsOHBwZHdnUGhI?= =?utf-8?B?STRYOXhMdUpXQVZSYVo2TUV3NDZDcllYdEY5RnoxeGw3b2VsQnh1b3BoQm9k?= =?utf-8?B?WUd3M2oxNzF6TjJEcGE0WVlmL0E2VkVLUk0rU1BORHpzbGdQRmVGOVFBbGxu?= =?utf-8?B?Mml6RWRtRTVmZDJCYktrL2JwMnpONWo0aU1DOXQwR2NUVnd6Rkozenc3MmNp?= =?utf-8?B?TzJ5MlRLOWsxOHRCWmIvYXpyWGhpTENZTnlNNGZuN21ib1BvYVRLa0x2SHBm?= =?utf-8?B?cjlkc2JvcGJoZWVnQmx1ZnBtalJLRkMzd0hNazUrUyt1dFo5c01TSXR2dEZJ?= =?utf-8?B?L3FybnUvTjBZRTk3MkJYcWxWSFFYdFk2VnRUdlNHT013Z3ZEUVdJVnF6U1Z1?= =?utf-8?B?Y0Nuc0xocCttRDYvMkRHVmxPY3RNRFFhOHlVWW8waW9qdGdZclVuU2VMSXBi?= =?utf-8?B?aGtTZzZ5Tm1ZRGFrUDBkUGoyV21UdFJscW1MV1FQUEhGc3ZCaFFGKy92TjdQ?= =?utf-8?B?cmd4Ni9SZGlWd2FCZXowTW12ZFNHTzg3RnhFbXVIb2lzSjdCNng4eERkdkQ5?= =?utf-8?B?L205TWN0S1NJaXkzTThkMXZzbDU3eklaWEkvVjlyYWNFQzdLNGtnSnh0eEFx?= =?utf-8?B?ZFpiaWhNYy9pbXhuWEIvRkwyVGcxaWpUVGhxTUh5Z0lRTlZibU5aVHlLOVJr?= =?utf-8?B?azkvRXBFamtnTFd0Y1E4bU5rTDkvaEpNd3o1WTExOWlyb2J5SG1rcEd5RklJ?= =?utf-8?B?MDlJSW13cU5HaENldkNJTVJjMlhjZnhlYXoyL1ZrM1J3bWFxRktDamlIMm9z?= =?utf-8?B?bTZmci8va1JacjZ1MkVlVjM5MGhDUjhqY1ZsUUw2ZTVLbGJpeFkzMm5CTFRl?= =?utf-8?B?eXF3a3lCQ01uRkx6Rm5INnNiQ2JZRkpPUHEzclFveHNWRWI0ejBvc0NEZDcx?= =?utf-8?B?TVNtaTUvUkUydkh1Rm1EUGk2TVhNb3Y5VXVIMWVRclBUcnZDVGJRWC93bWV2?= =?utf-8?B?N1lkb2I2WnpCeUd0WnhWM1FFNkRyQlpaQitvRUxTTFpBUm9VWkpPeXN5ZXpN?= =?utf-8?B?TUlMVVRZWFgvOGkxc3N0aktNYkx3dzVVOW03dzlEQk9UK2JjUmpqbk9heDZJ?= =?utf-8?B?MjVNZ1JzaFpwWmc1SHRScmxWK2NjSEkyRm1XNEdjNkhEbGpBNHdZQm9CU2lH?= =?utf-8?B?US9xL0FvZVhJU1NqdDZKcW5kQTIwNXU4RW1XRWYzNGtPN1dGZ09CbmQ3L3N3?= =?utf-8?B?bmFHMytlc0wvZ21ZZWIvTWg1ZHRXQVBRczNFVWJndWNWWW91SjFHWTBXOGJS?= =?utf-8?B?dkxyMDcyZTZsdUs2VWQyeE56VzE0cWYvNHBRV01ZSG1jUEtlZ3QrWWpndnNP?= =?utf-8?B?SVl2S3NrVFN3bkpQVmlUYnhhYjZZSGJiWDdiUGxhUEpuWUI1bURZYU1ZSHpj?= =?utf-8?B?LzR6Ry9sVmpYNHhISG5sSHQyQ0xvMDk4T3JLMlRNM1doNlkyM25IaWRkWHNE?= =?utf-8?B?RHZmbyt4RkJScEFRVzRSWFV3aWxzVTEyK0hUTDY2NTdMMlNIK2EvMjdJU09n?= =?utf-8?B?aXE4VE5nekFIN1VnclozWHNoVlF0Y29obkpxUUp6MmU1a21qbjBobEJjWmk5?= =?utf-8?B?WVdvMkVNZ0dKUklIK1g5L2IydkMrYWhLY0hmbmxmTnBEdDVIVzkyS0hOR2dy?= =?utf-8?B?VDZMNzRmTzZFQjBBZkVKaTZvTmJBZncxeWJnQldvZDlHZDI5UDduMEZCUVdm?= =?utf-8?B?R0JPV2Q0WWdLbFUwdWJwMkZ0eklETUNvZnorQkdZU3QyZXQrSmlvUzE3R3g5?= =?utf-8?B?TEowQ3BQTDlKS1lwc2tJamsxUjQyOEtpQVVNYlJ5SFJwUDJEU09QWWxWVW11?= =?utf-8?Q?6gXHlMxwOoe6RyA8GTRA7d0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3a138806-44e8-409f-f7e8-08d9e70406dd X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 10:57:53.3543 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e6/h4W8enz+3zrbbRHTR5YtcRyGPnaHWrbLG93ZLdNQCBSNaohjKL91ot8U3HOe6Wf8W0dleqJVcI78M6zTn0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1483 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/2/2022 11:50 AM, Thomas Monjalon wrote: >>> Subject: [PATCH] net/enic: adjust memory check and use in proper order >>> >>> Fixes: bb66d562aefc ("net/enic: share flow actions with same signature") >>> >>> Signed-off-by: Weiguo Li >>> >>> Reviewed-by: John Daley >>> >> Applied to dpdk-next-net/main, thanks. > > Please could we have a little of explanation in the commit log? > The title says "adjust [...] and use in proper order" > but I see only a move of the check. > > Is following good? If so I can update it in next-net. net/enic: fix dereference before null check Move memcpy to 'ah->key' after 'ah' null check Fixes: bb66d562aefc ("net/enic: share flow actions with same signature") Cc: stable@dpdk.org