From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D06FD2BF1 for ; Tue, 27 Mar 2018 19:10:40 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2018 10:10:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,367,1517904000"; d="scan'208";a="42637386" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.63]) ([10.237.221.63]) by orsmga001.jf.intel.com with ESMTP; 27 Mar 2018 10:10:37 -0700 To: "Guo, Jia" , jianfeng.tan@intel.com, jingjing.wu@intel.com, thomas@monjalon.net Cc: dev@dpdk.org, helin.zhang@intel.com References: <1517306475-2153-1-git-send-email-jia.guo@intel.com> <1519716008-2188-1-git-send-email-jia.guo@intel.com> <43713ba9-fc13-c7fd-84bf-1aa902fe83eb@intel.com> <58a0257a-b0a7-1895-7d7a-f5b623681d82@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR1xgUJB33UawAKCRD5M+tD3xNhH3TID/wNjq1doFXg49WaM7ZXez/1 qwj7U6FQ2eUhlEPX8dXc52cu+iQk8/mssXQtANEx+jndxfvlkikBNgI+mr3m/ho54uQWFZd7 Bv0DVVkLHNkLWK6tT6iISdCgXrQuOv8y5rucEGkJ8dDPsp8Mqr4sBjavRBpczphoa3miKusA HzUEo0SYuHUPmBlbmvKv4PkA5quWtXpkgV2HZ1bW9X0dQkAqEVioAPm5Q6pXJODfV8kaZUtJ z4swEtBnK9XAWm2HccF7KmFh0vv+Zh9lEMnEFt7UPXngY6+xCTo6xV1IVc8EZfDjOip8I4h2 ALMaLgrZwA9VVmHCVOrnO3UZqfGehrwz4O3sUrcmIzxjk3gfBmVRCBfuWGchSpWtZ99U6V1a OEuG+ymyjBDtyymW+KSvmCBl2gIxZHvZFvSRRdDObkkUIskSJ95f/6HBOESRZBOiV9GEAhC5 gI9OAKKF8HQaN/r5KJrkzscjQcjIdV1jXhTkfQ4wH3GJiVM5JxsKsEjjRw7yfSJo2GBEGqMe KMwMLWg4f1DgVtjOuGf10isu+29MvapW2IxKYaHcVc2vHfWbDi2AvBj/VAzKILWbTEgI1VL5 zKpo5p6X2O55oEyeflDiAzrUfvLqB4vmTyqXtW6PdLyZC7kXIzmNu6EBVx9oSgy3CADw5saN 0La9OoCAc7Tn+s7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKA== Message-ID: Date: Tue, 27 Mar 2018 18:10:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <58a0257a-b0a7-1895-7d7a-f5b623681d82@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V2] igb_uio: fix uevent montior issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 17:10:41 -0000 On 3/27/2018 8:46 AM, Guo, Jia wrote: > > > On 3/27/2018 2:28 AM, Ferruh Yigit wrote: >> On 2/27/2018 7:20 AM, Jeff Guo wrote: >>> udev could not detect remove and add event of device when hotplug in >>> and out devices, that related with the fix about using pointer of >>> rte_uio_pci_dev as dev_id instead of uio_device for irq device handler, >>> that would result igb uio irq failure when kernel version after than 3.17. >>> >>> The root cause is that the older version of Linux kernel don't expose the >>> uio_device structure, only for the kernel version after than 3.17 use >>> uio_device. so this patch correct it by use a macro to check before handle >>> the pci interrupt. >>> >>> Fixes: 6b9ed026a870 ("igb_uio: fix build with kernel <= 3.17") >>> Signed-off-by: Jeff Guo >>> --- >>> v2->v1: >>> use macro in compat.h to replace of version check in .c file, benifit for >>> future backport and make more readable. >>> --- >>> lib/librte_eal/linuxapp/igb_uio/compat.h | 4 ++++ >>> lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 16 ++++++++++++++++ >>> 2 files changed, 20 insertions(+) >>> >>> diff --git a/lib/librte_eal/linuxapp/igb_uio/compat.h b/lib/librte_eal/linuxapp/igb_uio/compat.h >>> index ce456d4..2c61190 100644 >>> --- a/lib/librte_eal/linuxapp/igb_uio/compat.h >>> +++ b/lib/librte_eal/linuxapp/igb_uio/compat.h >>> @@ -132,3 +132,7 @@ static bool pci_check_and_mask_intx(struct pci_dev *pdev) >>> #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 5, 0) >>> #define HAVE_PCI_MSI_MASK_IRQ 1 >>> #endif >>> + >>> +#if LINUX_VERSION_CODE > KERNEL_VERSION(3, 17, 0) >>> +#define HAVE_UIO_DEVICE_STRUCTURE 1 >>> +#endif >>> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >>> index 4cae4dd..99018f4 100644 >>> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >>> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >>> @@ -192,8 +192,14 @@ igbuio_pci_irqcontrol(struct uio_info *info, s32 irq_state) >>> static irqreturn_t >>> igbuio_pci_irqhandler(int irq, void *dev_id) >>> { >>> +#ifndef HAVE_UIO_DEVICE_STRUCTURE >>> struct rte_uio_pci_dev *udev = (struct rte_uio_pci_dev *)dev_id; >>> struct uio_info *info = &udev->info; >>> +#else >>> + struct uio_device *idev = (struct uio_device *)dev_id; >>> + struct uio_info *info = idev->info; >>> + struct rte_uio_pci_dev *udev = info->priv; >>> +#endif >>> >>> /* Legacy mode need to mask in hardware */ >>> if (udev->mode == RTE_INTR_MODE_LEGACY && >>> @@ -279,9 +285,15 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev) >>> } >>> >>> if (udev->info.irq != UIO_IRQ_NONE) >>> +#ifndef HAVE_UIO_DEVICE_STRUCTURE >>> err = request_irq(udev->info.irq, igbuio_pci_irqhandler, >>> udev->info.irq_flags, udev->info.name, >>> udev); >>> +#else >>> + err = request_irq(udev->info.irq, igbuio_pci_irqhandler, >>> + udev->info.irq_flags, udev->info.name, >>> + udev->info.uio_dev); >>> +#endif >> Hi Jeff, >> >> Can you please describe how this is solving the problem. Isn't only requirement >> for dev_id to be unique? Why it differs to pass uio_dev instead of udev pointer? > > Hi, ferruh > > > yes, this is because the uio_device definition is not exposed in kernel earlier > than 3.17,  you could check the history of commit > (6b9ed026a8704b9e5ee5da7997617ef7cc82e114), igb_uio: fix build with kernel <= > 3.17, which fix it by I get this part. The question is how this is fixing uevent monitor issue. Isn't the last parameter of the request_irq() is "void *" that has been passed to handler. Why and where it differs if that pointer is "struct uio_device" or not? > > use using pointer of rte_uio_pci_dev instead. > >>> dev_info(&udev->pdev->dev, "uio device registered with irq %ld\n", >>> udev->info.irq); >>> >>> @@ -292,7 +304,11 @@ static void >>> igbuio_pci_disable_interrupts(struct rte_uio_pci_dev *udev) >>> { >>> if (udev->info.irq) { >>> +#ifndef HAVE_UIO_DEVICE_STRUCTURE >>> free_irq(udev->info.irq, udev); >>> +#else >>> + free_irq(udev->info.irq, udev->info.uio_dev); >>> +#endif >>> udev->info.irq = 0; >>> } >>> >>> >