From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A810FA04DB; Fri, 4 Sep 2020 20:31:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 82D6FE07; Fri, 4 Sep 2020 20:31:33 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id F2077DE0 for ; Fri, 4 Sep 2020 20:31:31 +0200 (CEST) IronPort-SDR: vEaoHN70klkVZ5EL3SROGSZakJsfkZlmwRapg5nZ2JK1qh2wsdHpray6g2N9qWbqoeNYIgLPW4 93K0Wa74R0OQ== X-IronPort-AV: E=McAfee;i="6000,8403,9734"; a="219360524" X-IronPort-AV: E=Sophos;i="5.76,391,1592895600"; d="scan'208";a="219360524" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2020 11:31:30 -0700 IronPort-SDR: qpMj9ra6W1z0lhxQ1MkCpiFB+nadgC7csTVWpZyaDAPan7MvgJNSFAL+ELX+N0/vpJ+SyRdQW+ CptoklIYTVtw== X-IronPort-AV: E=Sophos;i="5.76,391,1592895600"; d="scan'208";a="478611605" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.212.198]) ([10.213.212.198]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2020 11:31:28 -0700 To: "Min Hu (Connor)" , dev@dpdk.org Cc: stephen@networkplumber.org, bruce.richardson@intel.com, Jerin Jacob Kollanukkaran , Andrew Rybchenko , Thomas Monjalon , Wenzhuo Lu , Beilei Xing , Bernard Iremonger References: <1598961165-20832-2-git-send-email-humin29@huawei.com> <1599219135-53194-1-git-send-email-humin29@huawei.com> <1599219135-53194-2-git-send-email-humin29@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: Date: Fri, 4 Sep 2020 19:31:25 +0100 MIME-Version: 1.0 In-Reply-To: <1599219135-53194-2-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V2 1/4] ethdev: fix compiling errors for per-queue statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/4/2020 12:32 PM, Min Hu (Connor) wrote: > From: Huisong Li > > Currently, only statistics of rx/tx queues with queue_id less than > RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain > application scenario that it needs to use 256 or more than 256 queues > and display all statistics of rx/tx queue. At this moment, we have to > change the macro to be equaled to the queue number. > > However, modifying the macro to be greater than 256 will trigger > many errors and warnings from test-pmd, PMD driver and librte_ethdev > during compiling dpdk project. But it is possible and permited that > rx/tx queue number is greater than 256 and all statistics of rx/tx > queue need to be displayed. In addition, the data type of rx/tx queue > number in rte_eth_dev_configure API is 'uint16_t'. So It is unreasonable > to use the 'uint8_t' type for variables that control which per-queue > statistics can be displayed. > > Fixes: ed30d9b691b2 ("app/testpmd: add stats per queue") > Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") > Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/") > Fixes: e6defdfddc3b ("net/igc: enable statistics") > Fixes: 2265e4b4e84b ("net/octeontx2: add basic stats operation") > Fixes: 6c3169a3dc04 ("virtio: move to drivers/net/") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor) > Reviewed-by: Wei Hu (Xavier) > Reviewed-by: Dongdong Liu The patch mostly looks good and it enables build with 'RTE_ETHDEV_QUEUE_STAT_CNTRS' > 256. Only I put a comment for a testpmd change to enable the "set stat_qmap" command for map value > 256. BUT there are many things to fix in the queue stats mapping, since you are already on it can you help on a few things on testpmd related to it, if you have time for it? 1) Getting queue stats shouldn't require stats mapping, it should be controlled separately. Many PMDs doesn't require/do the stats mapping but they still can collect the per queue stats, which can be displayed independent from mapping. 2) Even you map only one queue, while displaying stats it will display 'RTE_ETHDEV_QUEUE_STAT_CNTRS' queues, and when that number is high it makes hard to see the actual interested values. If there is no mapping, it should display min(number_of_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS). If there is mapping it should display queues that mapping done, this may require adding a new 'active' field to 'struct queue_stats_mappings'. 3) Why 'struct queue_stats_mappings' is cache aligned, is it really needed? 4) The mapping arrays, 'tx_queue_stats_mappings_array' & 'rx_queue_stats_mappings_array' are global and their size is based on fixed max port and queue size assumptions, can those mapping array be done per port and 'RTE_ETHDEV_QUEUE_STAT_CNTRS' size per port? Thanks, ferruh