From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B189C12009; Wed, 24 Jan 2018 18:20:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2018 09:19:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,408,1511856000"; d="scan'208";a="29167318" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by orsmga002.jf.intel.com with ESMTP; 24 Jan 2018 09:19:58 -0800 To: John Daley Cc: dev@dpdk.org, Hyong Youb Kim , stable@dpdk.org References: <20180123010529.17748-1-johndale@cisco.com> <20180123010529.17748-2-johndale@cisco.com> From: Ferruh Yigit Message-ID: Date: Wed, 24 Jan 2018 17:19:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180123010529.17748-2-johndale@cisco.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/enic: fix segfault due to static max number of queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 17:20:01 -0000 On 1/23/2018 1:05 AM, John Daley wrote: > From: Hyong Youb Kim > > ENIC_CQ_MAX, ENIC_WQ_MAX and others are arbitrary values that > prevent the app from using more queues when they are available on > hardware. Remove them and dynamically allocate vnic_cq and such > arrays to accommodate all available hardware queues. > > As a side effect of removing ENIC_CQ_MAX, this commit fixes a segfault > that would happen when the app requests more than 16 CQs, because > enic_set_vnic_res() does not consider ENIC_CQ_MAX. For example, the > following command causes a crash. > > testpmd -- --rxq=16 --txq=16 > > Fixes: ce93d3c36db0 ("net/enic: fix resource check failures when bonding devices") > Cc: stable@dpdk.org > > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley Applied to dpdk-next-net/master, thanks.