From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B35F9A00C3; Tue, 18 Jan 2022 11:29:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B2A340696; Tue, 18 Jan 2022 11:29:33 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 67E624068E; Tue, 18 Jan 2022 11:29:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642501771; x=1674037771; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=SIFy3qPKnjrtzl8v24A5qEe1N+lPsq3Y3C1Z9hZBFvg=; b=dfa5afRDx5OemdTte9TSEvEeiV2ceTWI0VCTirgEYBqpZohzFtFuOAS8 ZgSEDSt3Z5rKYk0S+jlmKOaiq8a2J19o+fo97PIL/rmQHHGjE6WSWY+uF X5f4LBw/L/iei0cqWD6TTVKhEyHDAjiqt1s+pYeMr1lu4BLmEcWxYgQsv tXjQivQw3HMdlNYHG/2usgf7RqIgiYEgdLxVPNOfJEOfyQUQxVmCn0OBu 6ZlQpsIdLPuO72EQ1zFgW7vEIAUM7AsuNpWPR1sxbBeITRUDGRnl2ff2M DFMJ3cxA10Ha3rgc97jUHETGTiZrmNh1XwqyMv9LmXjmP55qbQ2/dT/HJ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10230"; a="269163796" X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="269163796" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 02:29:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,297,1635231600"; d="scan'208";a="474721580" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 18 Jan 2022 02:29:29 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 18 Jan 2022 02:29:29 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 18 Jan 2022 02:29:29 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 18 Jan 2022 02:29:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d/4gqQYO+k2yPbwn1VbonJoecoURgvfJ+X2mBV6Saulnw/l7blWDmt3nRPpUgpsacd70dVs4fL1kfPqemdSLEFQ3QzyOvi+jlSgEDBNv+lLk/cwaUTSNSZqTwpp2mezm64vufA8lcOpOSv+fAb3+Q53iEDbXyEICBYiRTEwTqFNRyiaryO99GawrwjaC4wHb1QeFO3VVjPJIXl0/Bctdc+niSw6y7UStZhuEWvQ5nmOELFhLJIE9rDr5nIPgvCE9I8pFzjW1SkMdCygMjpNeE/Zkckt0i1WQVIj7p579g0J3I+5babJ9SStAZtSXYl83pC4QQR4PhrNUsSQ/2bU43Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x8uvRCHjIyWbcT6o3bLGC+lCFIrHM6Wg/USjkWRLylY=; b=ZTO2UCjKYC+knqQz2x7g/WJlH0ULbXb8tTYikvaxZLmffyBq2BoeIGrwe1wul9Gl8nmWearx+SoCgMeYX5+r8vVXkxFbC+6xI4jn4YKfWJum9841fQRUpBpVzSu9QOtD7eVDCD1RWb/LDOU0/qUXopqUDcrj2xJHfDtTT1ikkOhUkjXXMGhHQ9pxPFmQspZieYKNX7zlMMxuyy73ES9WcFyESwPR4NT4Uv5plp54MZ6NCUBNmhCBA2RBeSvz44Hgk4KLi0XZ+dvzRued/JXPQznR+JOG1aPz/h3alXD26a1HPnYDU7wdNf5SBp6SKDzjmHqt5+D4QQ4NNa0JiNz6FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM6PR11MB3388.namprd11.prod.outlook.com (2603:10b6:5:5f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Tue, 18 Jan 2022 10:29:27 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4888.014; Tue, 18 Jan 2022 10:29:27 +0000 Message-ID: Date: Tue, 18 Jan 2022 10:29:22 +0000 Subject: Re: [PATCH] net/af_xdp: fix build with -Wunused-function Content-Language: en-US To: Ciara Loftus CC: , References: <20211209171947.25340-1-ciara.loftus@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211209171947.25340-1-ciara.loftus@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0051.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::15) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 80a3b588-2d35-4536-36e8-08d9da6d673d X-MS-TrafficTypeDiagnostic: DM6PR11MB3388:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1388; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c36Zbpqz73GWN7wU1GmV41CoBkhKdKbBWiyKqQ7XTVaDDqHiG3pyHMKEf6C0IRJBFkZ0U8bAdQxe0sOAXdcM5lZHkrcDCfu/SaJ2PaYBU/zHbCGpFJ2mXIaUOACCyfY0uharVYU1xFJY74YIs1bW1N1erYzKv1Hjp6dbBQQZyGV6mH5l/OrL7WsKlJG47vftlmyZqSH1WBuASBhH7hUU3LvjRW6zE2YSz5OccrPolJS2rVkPQzreESp+2nQIKr8dRWnCIST4vwDaJJflIFgBFMei5n3WpdClLJpBeSswNIIWD/1zvXupq4mKmyWevXcxnJnO3ttaAwd9opRxcH4kAoXJ2k08uZUatPhfBMkGHOTWdnQaWSm0isiSjwrSkrCuJIqwmhCswy6O34W5MxTpZdzSqEbaksgYH+yvEuJX/pqcTb0Dzw52d/bf3OzYTEj0DiBE7V0phVDrbL3HJyOj0CfaEz1CPMaZ2RF/XSfgV7KbMKLBaGMUsAgH7yt6ftaM3k6HJFH/3iPhMmmIwupeW5pve2rhlbEsMPSe5gT1lF2teeY4wE3dDE+7OXvMsqZxevrbJNG066vuh/dRIJk8Sn401J62VNjaojUlrVBIRY9mKFdwh2JKbBJH7VTiJ9f+FRh68YITvIXqAfyC96ct1KQwfmxKAnbdytvYDBTWQhjOP1eTlJYMAtB/Fj+6n4nTTv1qrjcMHE279swp8yPYhg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(4326008)(450100002)(26005)(6862004)(508600001)(37006003)(316002)(186003)(86362001)(53546011)(6506007)(31696002)(6636002)(44832011)(6512007)(82960400001)(2616005)(2906002)(6486002)(5660300002)(8936002)(38100700002)(36756003)(66556008)(66476007)(6666004)(31686004)(66946007)(8676002)(4744005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlYzM2ZSaThTbzNaUnZjWTQzM051VmRoQ1ViWFZYOStUQVNlTit1TlVOKyti?= =?utf-8?B?Zk03ZzNhQ1NKSDFQcDNHT2tkQ3NCZHlpcmM4d1d0K216aVUyWjc2T0RGQS83?= =?utf-8?B?UUhrcTNuVWZmdllsMlpOTjc2cUxZM2xWbkVYVmRtVXMzOUlZSlJ0eTkyc0Uw?= =?utf-8?B?N3JzdGVGZFhNK1JRcVlCcmNyNjVwSGE1ZVpmc3JuTGd2di9HYlk1L29vWGls?= =?utf-8?B?bUhRc3dvdGIzR1ZVU01tK0NtWW93WjNwaG1SeGxOcnJlc013SWo0MUUrcDNF?= =?utf-8?B?WlFvTW96dzh6cmNQaE4vOXdpVUhwWXR3eCtBUThMV05YWWJhSTFvWDgvSnRZ?= =?utf-8?B?WEcxaHJGQk5mcEVRQ2ZGWmRJTVp0elBKdVZLelFlaEdSK1MvRXE4VEpRa2gy?= =?utf-8?B?YmYrSFg4TjJxQTJMbWpWQWlXbDVJQ3VUK0YzdEdzVytqTk1IVkk1VVNwK2ho?= =?utf-8?B?SThIVTZJMFpRc3BhZlhOTlBnUEJMWkRvNEVRcWU2dFNMNWYxZUc3cDNLUHFT?= =?utf-8?B?dmhUcUJyejFXWS9hMDhjeDFzeklIYmRFYUxKbDFRamNBMFlPUDBhb0t6SW84?= =?utf-8?B?L3FpWlY1RHRyd2ozeGoxWVNRYy96MC9SdzhlL3A2dytyWmxPQ0pNd2xqTDZO?= =?utf-8?B?YXkyQ1VIUDlUb3pyZFVmYmtLYWRSTk4zbXFEYmtQL0ZkM0hXOFhzZjdFMnlF?= =?utf-8?B?eTBkdE1xMG9wbXRWaUdMM1VvY2JlL1VRSnRhdjRlRmhHL3VmQk9vZ3l1Qml3?= =?utf-8?B?anRUSlI3RzZaU21CZ251b1V2T3ZxNDM1MGw1LzhBZzQvU1BWS2xvZXZhcWN4?= =?utf-8?B?TVFiYTJscmhuM3RpbnpNeG01eTNRR0MzQzQwbmI5S2VnaDRnSlBMbE1WbklC?= =?utf-8?B?SW5Ic2RTNzZtaU5Ba1AwVW13YVQ4NkFFNGU5OUdvQ0hBUzBKWStGNmJiZStl?= =?utf-8?B?aENLamQ0SzZRNWJ4aHNxL0hBR3B4ZGxtbWg1WDVUcWMrY3NQNThWMDdreGll?= =?utf-8?B?OUtiTUVtaFVYaERLaWRZMzBnUlEya0x5QisyYjZqTG1pWXR2Tk81WDhXc0Fn?= =?utf-8?B?WktXbVBQWFh2S2IvSEhJT01id0I4NG1MVFBXREFhT05LRlE3OUpvb1hSTjVE?= =?utf-8?B?QVRJWDhZNlJLSytiWGljbXVPQy9UQk1qcW9PUE9hN3Rpa1JGYWR2YzdURjRm?= =?utf-8?B?QlVaUHB5YWNpa1FDdHFsQk8vNGN6S0hoajhPdXkwMU1paUd2N3MvcWU5dzRi?= =?utf-8?B?cksyclZNcHNUQjFFdkFDNGJUbVd5NmNYNU9NWm1LSmFvZXdmalF3azQ5SEdq?= =?utf-8?B?alRqc0I3b2o0WjN0T3pJWVJOaVRibjVVQmR6Ny9QdDJRQURTOTQ4ZDh0eHNr?= =?utf-8?B?YlNsL3h0MDZGYXI0R3NGSVpBQllnMFhVYVovTzJFSE5nY2JScmU1Ni84QVVQ?= =?utf-8?B?RlowNTFoOHZkZlhOREZvSWtibytDTXUyUWJHQ29JUHRmZWVTZEp1SUlwdVBC?= =?utf-8?B?eHFwU0R4aWM0S0M1UlBaNkxLRGNtaHJDazNZYW9EYnlyK0hwUkdHUHc0OEky?= =?utf-8?B?MFV0djFPbHd4WlpRcWFWRXE5SWFTa3BWc0Z5T1N1NFlwM1VWUHFaeFZCV05r?= =?utf-8?B?Q1JlR1Q4ZTlaL1RQeVA4dFZxSjUxQVllQzduZFlPaUo3UlJGaklwbWJodTJV?= =?utf-8?B?Tlc0cFhKb0hLdUVVM0ZGZHVCT1R1RU0vdkkzZENRTG5VTHZZVytIaGxrZndZ?= =?utf-8?B?SWpEVWdDOFR4aU1LK09NU1RIRGlaamlJMEF5ZXVQTkQyLzhNbEhmdVN5eDIx?= =?utf-8?B?azJGMHA4ZEZYZFRQNDQ1NU9mTjhkOXFFcytydVpmYkEvMzZQS3NVQnJUTVlS?= =?utf-8?B?RENKemY2REVZdVVWbDdjLzNESThOSlFIamNMa1lDYTg3eE5jeldNdkxtbVZa?= =?utf-8?B?WnlVTDlORG14SHN3U1ZjbE5vWGlsSGVXMEhnUkgyK2Q3c2E1eDFqSm1ySnpJ?= =?utf-8?B?NVBWWit0eDJKa2pOT1ROUFJGcmlnQjRlVFkwK0xteU5TSEtCUHB1K1lvSmRM?= =?utf-8?B?dDYwUmVJeWtValU3V1E4WWNZMWZDMlh6bURzMWtrR0tFTlBGQ3BaZVEzTEM0?= =?utf-8?B?SnFXN200QmZqN1M2bDcwUUlwYUp1YndCUVhIekJnSzJUbnFVWGxFMEp3YnZ1?= =?utf-8?Q?8Bv45NZupJBhP6Ml3b8o+6Q=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 80a3b588-2d35-4536-36e8-08d9da6d673d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2022 10:29:27.2365 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /3asBCtIPhIB1RhjOR3dx5+0wm7U8lHH1EHyKRJwpXPMzBV9qG7hhLOXz5vQPw6BMKGQUA7N01NcSTO4C+MJ7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3388 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/9/2021 5:19 PM, Ciara Loftus wrote: > The get_shared_umem function is only called when the kernel > flag XDP_UMEM_UNALIGNED_CHUNK_FLAG is defined. Move the > function implementation and associated helper so that it only > gets compiled when that flag is set. > > Fixes: 74b46340e2d4 ("net/af_xdp: support shared UMEM") > Cc: stable@dpdk.org > > Signed-off-by: Ciara Loftus Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.