From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 954BFA0588; Tue, 7 Apr 2020 15:44:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6FFD31BE90; Tue, 7 Apr 2020 15:44:42 +0200 (CEST) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 4485B2BE9 for ; Tue, 7 Apr 2020 15:44:41 +0200 (CEST) Received: by mail-lj1-f193.google.com with SMTP id p14so3731081lji.11 for ; Tue, 07 Apr 2020 06:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IYgsR8UWoGeLEmVYEMoVV74kzwUmTWzdjazxlpdxfNg=; b=z610/y5SttQMPqRYqEeMzVY2kQ1KcardYCl9g+tpapffYG3oq0pTmunZeh9KCEpUHO XxZ6Im4MieMersf4QfoWiDSgYMlf9GDNVX8vBhb+9WFn9RyF3hR2WGTRy0+YCxa6dH/X l0MCgw0zNgannGs1NenSltw71Cd1FL1OJK28PNQatNdJ2UjiD90K99ZP8IljyfSLywWc eBbTYTiF5VTJ0byuB/Mlw4y924lY3PkqdzFT+roapGIVYutlNtPk0fbiGL+61fMNx3AB BcgG2O06qNCRb95/qLFraNVTFig8IiyNmzmLm2qVH70q7NMF9alEC/+peOyyqksEoOjm KgUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IYgsR8UWoGeLEmVYEMoVV74kzwUmTWzdjazxlpdxfNg=; b=tzv08mRaiGjHWxn2ovEkVKsIkjFB2aqZceR6NDf9dWvk386yBEmxRl+o1XT71R5SRw xNXMKjN9IfLzY7OpEdH3nuvMIhvz7J+6XM7zynBGDhqQ/+i2t7c77qshnnzsMhUGvDd3 0fOHJdhHwjMesadbzZ1gYlMI4deXZUz2kDRb5D2IXdv4WlOZgE7FDnWkvWfUFIjRQ9Vs T/NLZQDU4B5wHYKzRuNZwPHXnHoJNyY3wAMd5BtnumpS8XpDAsZFpjqj8M/Kf7d2aIfD h8+MRbV1vaIgct8PCiQkkl4AWi8ymbgVrjL7vPrx/6RTn3gx+5wf6AE6nkHhZnC7eX1S 2pIQ== X-Gm-Message-State: AGi0PuaPllEa70Y4rf4aHHYTc2W4l8T66j82eV/U3r5FoaCCx5y2fzMP yCjE5YI8z5+0AGobbtm6kjEK X-Google-Smtp-Source: APiQypJ2XiyxQ6p83erZSzWcG3aCzbOb2byss5kO+rFTCwtCDGPgqUE3/MsFwMMx0Z+0XM8lhz4vFQ== X-Received: by 2002:a2e:8693:: with SMTP id l19mr1916135lji.132.1586267080796; Tue, 07 Apr 2020 06:44:40 -0700 (PDT) Received: from [192.168.0.105] ([155.93.220.174]) by smtp.gmail.com with ESMTPSA id k18sm14046463lfg.81.2020.04.07.06.44.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2020 06:44:40 -0700 (PDT) To: wangyunjian , dev@dpdk.org Cc: jerry.lilijun@huawei.com, xudingke@huawei.com, stable@dpdk.org References: <1586259447-13508-1-git-send-email-wangyunjian@huawei.com> From: Heinrich Kuhn Message-ID: Date: Tue, 7 Apr 2020 15:44:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1586259447-13508-1-git-send-email-wangyunjian@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] net/nfp: fix dangling pointer on failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2020/04/07 13:37, wangyunjian wrote: > From: Yunjian Wang > > When nfp_pf_create_dev() is cleaning up, it does not correctly set > the dev_private variable to NULL, which will lead to a double free. > > Fixes: ef28aa96e53b ("net/nfp: support multiprocess") > CC: stable@dpdk.org > > Signed-off-by: Yunjian Wang Thanks Yunjian Acked-by: Heinrich Kuhn