From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay02.ispgateway.de (smtprelay02.ispgateway.de [80.67.31.40]) by dpdk.org (Postfix) with ESMTP id 8AD111B1F0 for ; Tue, 10 Oct 2017 10:11:04 +0200 (CEST) Received: from [146.52.109.75] (helo=nb-martin.allegro) by smtprelay02.ispgateway.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) (envelope-from ) id 1e1pcs-0005Yq-9P; Tue, 10 Oct 2017 10:10:54 +0200 To: Yongseok Koh Cc: Adrien Mazarguil , =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= , "dev@dpdk.org" , Ferruh Yigit References: <5d1f07c4-5933-806d-4d11-8fdfabc701d7@allegro-packets.com> <374F8C13-CFB0-42FD-8993-BF7F0401F891@mellanox.com> From: Martin Weiser Message-ID: Date: Tue, 10 Oct 2017 10:10:53 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Df-Sender: bWFydGluLndlaXNlckBhbGxlZ3JvLXBhY2tldHMuY29t Subject: Re: [dpdk-dev] Mellanox ConnectX-5 crashes and mbuf leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 08:11:04 -0000 Hi Yongseok, I can confirm that this patch fixes the crashes and freezing in my tests so far. We still see an issue that once the mbufs run low and reference counts are used as well as freeing of mbufs in processing lcores happens we suddenly lose a large amount of mbufs that will never return to the pool. But I can also reproduce this with ixgbe so this is not specific to the mlx5 driver but rather an issue of the current dpdk-net-next state. I will write up a separate mail with details how to reproduce this= =2E Thank you for your support! Best regards, Martin On 08.10.17 00:19, Yongseok Koh wrote: >> On Oct 6, 2017, at 3:30 PM, Yongseok Koh wrote: >> >> Hi, Martin >> >> Even though I had done quite serious tests before sending out the patc= h, >> I figured out deadlock could happen if the Rx queue size is smaller. I= t is 128 >> by default in testpmd while I usually use 256. >> >> I've fixed the bug and submitted a new patch [1], which actually rever= ts the >> previous patch. So, you can apply the attached with disregarding the o= ld one. >> >> And I have also done extensive tests for this new patch but please let= me know >> your test results. >> >> [1] >> "net/mlx5: fix deadlock due to buffered slots in Rx SW ring" >> at http://dpdk.org/dev/patchwork/patch/29847 > Hi Martin > > I've submitted v2 of the patch [1]. I just replaced vector insns with r= egular > statements. This is just for ease of maintenance because I'm about to = add > vectorized PMD for ARM NEON. In terms of functionality and performance= it is > identical. > > Please proceed your testing with this and let me know the result. > > [1] > [dpdk-dev,v2] net/mlx5: fix deadlock due to buffered slots in Rx SW rin= g > , which is at http://dpdk.org/dev/patchwork/patch/29879/ > > Thanks, > Yongseok >