From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C6C72558D for ; Fri, 3 Jun 2016 14:53:04 +0200 (CEST) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 08D3178226; Fri, 3 Jun 2016 12:53:04 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-7-206.ams2.redhat.com [10.36.7.206]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u53Cr0lp000737; Fri, 3 Jun 2016 08:53:01 -0400 To: Arnon Warshavsky , Neil Horman References: <20160602104106.GA12923@hmsreliant.think-freely.org> <2363376.b1CWhBpcZG@xps13> <75917C44-9CF7-4A0B-B8D3-CD7DC7425D49@intel.com> <20160602171120.GB12923@hmsreliant.think-freely.org> <7091836E-B9D5-4F99-ADDB-A47B4C7B5F7E@intel.com> <20160602200837.GC12923@hmsreliant.think-freely.org> <20160603102943.GC16616@bricha3-MOBL3> <20160603110129.GB17812@bricha3-MOBL3> <20160603115048.GA12627@hmsreliant.think-freely.org> Cc: Bruce Richardson , "Wiles, Keith" , Thomas Monjalon , Yuanhan Liu , "dev@dpdk.org" , "Tan, Jianfeng" , Stephen Hemminger , Christian Ehrhardt , Olivier Matz From: Panu Matilainen Message-ID: Date: Fri, 3 Jun 2016 15:53:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 03 Jun 2016 12:53:04 +0000 (UTC) Subject: Re: [dpdk-dev] [RFC] Yet another option for DPDK options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2016 12:53:05 -0000 On 06/03/2016 03:01 PM, Arnon Warshavsky wrote: > > > On Fri, Jun 3, 2016 at 2:50 PM, Neil Horman > wrote: > > On Fri, Jun 03, 2016 at 12:01:30PM +0100, Bruce Richardson wrote: > > On Fri, Jun 03, 2016 at 11:29:43AM +0100, Bruce Richardson wrote: > > > On Thu, Jun 02, 2016 at 04:08:37PM -0400, Neil Horman wrote: > > > > On Thu, Jun 02, 2016 at 07:41:10PM +0000, Wiles, Keith wrote: > > > > > > > > > > On 6/2/16, 12:11 PM, "Neil Horman" > wrote: > > > > > > > > > > > > > > > > >1) The definition of a config structure that can be passed > to rte_eal_init, > > > > > >defining the configuration for that running process > > > > > > > > > > Having a configuration structure means we have to have an > ABI change to that structure anytime we add or remove an option. I > was thinking a very simple DB of some kind would be better. Have the > code query the DB to obtain the needed information. The APIs used to > query and set the DB needs to be very easy to use as well. > > > > > > > > Thats a fair point. A decent starting point is likely a > simple struct that > > > > looks like this: > > > > > > > > struct key_vals { > > > > char *key; > > > > union { > > > > ulong longval; > > > > void *ptrval; > > > > } value; > > > > }; > > > > > > > > struct config { > > > > size_t count; > > > > struct key_vals kvp[0]; > > > > }; > > > > > > > > > > > > > > Maybe each option can define its own structure if needed or > just a simple variable type can be used for the basic types (int, > string, bool, …) > > > > > > > > > Well, if you have config sections that require mulitiple > elements, I'd handle > > > > that with naming, i.e. if you have a config group that has an > int and char > > > > value, I'd name them "group.intval", and "group.charval", so > they are > > > > independently searchable, but linked from a nomenclature > standpoint. > > > > > > > > > Would this work better in the long run, does a fixed > structure still make sense? > > > > > > > > > No. I think you're ABI concerns are valid, but the above is > likely a good > > > > starting point to address them. > > > > > > > > Best > > > > Neil > > > > > > I'll throw out one implementation idea here that I looked at > previously, for > > > the reason that it was simple enough implement with existing code. > > > > > > We already have the cfgfile library which works with name/value > pairs read from > > > ini files on disk. However, it would be easy enough to add > couple of APIs to > > > that to allow the user to "set" values inside an ini structure > as well. With > > > that done we can then just add a new eal_init api which takes a > single > > > "struct rte_cfgfile *" as parameter. For those apps that want to > just use > > > inifiles for configuration straight, they can then do: > > > > > > cfg = rte_cfgfile_load("my_cfg_file"); > > > rte_eal_newinit(cfg); > > > > > > Those who want a different config can instead do: > > > > > > cfg = rte_cfgfile_new(); > > > rte_cfgfile_add_section(cfg, "dpdk"); > > > foreach_eal_setting_wanted: > > > rte_cfgfile_set(cfg, "dpdk", mysetting, myvalue); > > > rte_eal_newinit(cfg); > > > > > From chatting to a couple of other DPDK dev's here I suspect I may > not have > > been entirely clear here with this example. What is being shown > above is building > > up a "config-file" in memory - or rather a config structure which > happens to > > have the idea of sections and values as an ini file has. There is > no actual > > file ever being written to disk, and for those using any non-ini > config file > > structure for their app, the code overhead of using the APIs above > should be > > pretty much the same as building up any other set of key-value > pairs in > > memory to pass to an init function. > > > > Hope this is a little clearer now. > > > I'm fine with the idea of reusing the config file library that > currently exists, > or more to the point, modifying it to be usable as a configuration > API, rather > than a configuration file parser. My primary interest is in > separating the user > configuration mechanism from the internal library configuration lookup > mechanism. What I would really like to be able to see is > application developers > have the flexibiilty to choose their own configuration method and > format, and > programatically build a configuration for the dpdk on a per-instance > basis prior > to calling rte_eal_init > > It seems like this approach satisfies that requirement > Neil > > > If the there is no configuration structure , rather an opaque > configuration key/value store , > the user applications can set and get knobs that are not seen by anyone > (library) that does not know them by name > > e.g > > int num_nodes = getCfgInt ( cfgObject , "eal" , "num_numa_nodes"); > int delay = getCfgInt ( cfgObject , "drivers.ixgbe" , "some_delay"); > setCfgInt (cfgObject , "my_app" , "num_days" , 7); > setCfgString (cfgObject , "my_app" , "best_day" , "Wednesday"); I dont see why it would not be possible to have the libraries export their known config keys in one way or the other. Or more. One aspect is runtime queries which would need an API of some kind. Being able to query default values should work for that purpose and be handy for various other uses as well. Another one is build-time sanity checking which could be doen by auto-generating header(s) from the library known keys, eg #define CFG_NUM_NUMA_NODES "num_numa_nodes" so if you use the macro instead of the actual string, you'll get a compiler error in case of unknown key instead of runtime misbehavior in case of typoed values etc. Whether that's worth it is an entirely different question. - Panu - > /Arnon >