From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FCDFA0561; Fri, 5 Mar 2021 02:43:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8D0D22A30B; Fri, 5 Mar 2021 02:43:34 +0100 (CET) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id F0D5B22A2FA; Fri, 5 Mar 2021 02:43:32 +0100 (CET) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Ds9SJ6QRdzMjHh; Fri, 5 Mar 2021 09:41:20 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Fri, 5 Mar 2021 09:43:27 +0800 To: Ferruh Yigit , Chas Williams , Liang Zhang CC: , Vadim Podovinnikov , , Declan Doherty References: <20191126115508.11138-1-podovinnikov@protei.ru> <20210217162656.1983277-1-ferruh.yigit@intel.com> From: "Min Hu (Connor)" Message-ID: Date: Fri, 5 Mar 2021 09:43:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20210217162656.1983277-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v3] net/bonding: fix LACP system address check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: Min Hu (Connor) ÔÚ 2021/2/18 0:26, Ferruh Yigit дµÀ: > From: Vadim Podovinnikov > > In bond (LACP) we have several NICs (ports), when we have negotiation > with peer about what port we prefer, we send information about what > system we preferred in partner system name field. Peer also sends us > what partner system name it prefer. > > When we receive a message from it we must compare its preferred system > name with our system name, but not with our port mac address > > In my test I have several problems with that: > 1. If master port (mac address same as system address) shuts down (I > have two ports) I loose connection > 2. If secondary port (mac address not same as system address) receives > message before master port, my connection is not established. > > Fixes: 56cbc0817399 ("net/bonding: fix LACP negotiation") > Cc: stable@dpdk.org > > Signed-off-by: Vadim Podovinnikov > --- > Cc: zhangliang@bigo.sg > Cc: Declan Doherty > > v3: Re-sent with rebase > * Patch title updated, commit log updated with info shared in email > * Sign-off updated with full name > * Debug log slightly updated > * Syntax slightly updated > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c > index 5fe004e551de..128754f4595a 100644 > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c > @@ -804,19 +804,34 @@ rx_machine_update(struct bond_dev_private *internals, uint16_t slave_id, > struct rte_mbuf *lacp_pkt) { > struct lacpdu_header *lacp; > struct lacpdu_actor_partner_params *partner; > + struct port *port, *agg; > > if (lacp_pkt != NULL) { > lacp = rte_pktmbuf_mtod(lacp_pkt, struct lacpdu_header *); > RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP); > > partner = &lacp->lacpdu.partner; > + port = &bond_mode_8023ad_ports[slave_id]; > + agg = &bond_mode_8023ad_ports[port->aggregator_port_id]; > + > if (rte_is_zero_ether_addr(&partner->port_params.system) || > rte_is_same_ether_addr(&partner->port_params.system, > - &internals->mode4.mac_addr)) { > + &agg->actor.system)) { > /* This LACP frame is sending to the bonding port > * so pass it to rx_machine. > */ > rx_machine(internals, slave_id, &lacp->lacpdu); > + } else { > + char preferred_system_name[RTE_ETHER_ADDR_FMT_SIZE]; > + char self_system_name[RTE_ETHER_ADDR_FMT_SIZE]; > + > + rte_ether_format_addr(preferred_system_name, > + RTE_ETHER_ADDR_FMT_SIZE, &partner->port_params.system); > + rte_ether_format_addr(self_system_name, > + RTE_ETHER_ADDR_FMT_SIZE, &agg->actor.system); > + MODE4_DEBUG("preferred partner system %s " > + "is not equal with self system: %s\n", > + preferred_system_name, self_system_name); > } > rte_pktmbuf_free(lacp_pkt); > } else >