From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77F6541C62; Sat, 11 Feb 2023 01:35:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12D7F40E50; Sat, 11 Feb 2023 01:35:21 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id E5E3240E0F for ; Sat, 11 Feb 2023 01:35:19 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aHWaPk4r2+z/VYD0pAr4UCP7lHIVkgxM65Cvs/8DdpOAMl5KViKpQ3bl6SGvekmadpJCypPndZUxrxl1pSfDeycq8MiI3g24YpNXV+IpkJ2UjvFbgu304nAhdfR3Vt+adYaR/djVW813BEymycPts4bBW5P1VYffXTjw3IduVYAsQcdBQGWCdpdLWbR1ncqU89h41mOp0pnadbZeLvJ+bnyuKnPc+Fh3ojy5fheVlQnnzJQoNZo7/T65zvMc+gmjXeOqNkJj0DQVp0NmMTNIeRyjXQI7qLiEfuru3eG1P5SB2uJ09VOtF7N2UBVCnxVBkm/48G1qoTQAUGm6jcxxtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6kxCByAXnnsb9HGlg19ptRuF3dwGAlbOhezQizQBd10=; b=JPS99LJzyPRMa51oYXJCq77pci72O5nThLA3W6VAsGI+QF4lHrj9OU/Cr3FEmgm0KHSbIOxDqNEAlb7H+u7OqaM4vPAHLcGi3fzoxFoLZFCw5vf10P4wMhU1YyVwCpf30p4psTbv+WvEolyHRB+DY4jw/rXSNKe9l8+cB+a1ccDE80jBHM1Nv+JLOI6kW9lY5UXifywZPVu/a9u58m6c9E1fZpjP9fOlSxpElewjimc2j1NQpcRLTn6d8AMJeT/FKzhq9yNhJ7lq3I4TiUmLmePB3wOwLc8Ji5boE43cyPkFiKgkI0HUBrztXNJFhOzQBpyNuy5ZgOPlWoABTpqwLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6kxCByAXnnsb9HGlg19ptRuF3dwGAlbOhezQizQBd10=; b=eoxQCjWm+9T8IHyWwh3f+5HOKMLGkpUje1I3GAMp4WYjs/9lcQiWhtInR5gyQMJYtMlZ2bj4dEp4SEC0lAjWReuoCI+lTvjlr8N0AbyuzCgmdsLa21nQ7FjUVDrTSXIVPQai2F1E8pOTIJGIzYi34c/nehPx2F8XZNAV0Ak0x/8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB6375.namprd12.prod.outlook.com (2603:10b6:8:a2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Sat, 11 Feb 2023 00:35:17 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6086.021; Sat, 11 Feb 2023 00:35:17 +0000 Message-ID: Date: Sat, 11 Feb 2023 00:35:11 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Rakesh Kudurumalla , Ori Kam , Thomas Monjalon , Andrew Rybchenko Cc: jerinj@marvell.com, ndabilpuram@marvell.com, dev@dpdk.org, David Marchand References: <20230210081422.1004901-1-rkudurumalla@marvell.com> <20230210082623.1005496-1-rkudurumalla@marvell.com> From: Ferruh Yigit Subject: Re: [PATCH v6 1/3] ethdev: skip congestion management configuration In-Reply-To: <20230210082623.1005496-1-rkudurumalla@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0353.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB6375:EE_ X-MS-Office365-Filtering-Correlation-Id: f251b95c-a798-4c0d-9e74-08db0bc7d922 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l4LBcNHAwI/Rt97gLyB+q7AZitmbI7+Tt9j7dVELMRTBYqKo1svLqaYEzqSLCAi3RI4u+s+R5MZHGE9wxy2MXx1NqCkClPnJc/r/8f2HyS86sLnuzC3P2IZnN9K0YP332EJyG5MBHjeYIL5Xs56MQYw07lC+rqWJ/ArKI4/qyxP9Nz3eaUsHmnIrJYJa0t8kwmWVM+fXg0lJ60JxX8YE1h5zC/oEDpONi1/QS/FT2lykolLBcg9kXdzP6mierXwfBrPcNJWsxf7KLVxm0ENSFIcE/12AV70WLJuaJU9ITaqkyY+O+lVi0sPPQLJBaVGa69/djb9k8llj+hF9Dx6pW+LMAzHAciV2P0wDFU+FpBSMLOjnf7BR5c/lOpH2I28Otldp4Yunmc+Pk5ocBgYzYlhx+/q2vBLmzOwoxToFC2o3zm0MX53wH0zTvN2zWMkwZFxXdn8ehAv9u2TxB82/4cJDeC+ZePB+ETjMIw2Y5vtoSVNUeK8huh///6j/avHmcqci4r6dL1ocqPMbBWcYPFzOn43MvX/1lAzwykMtufBDYVqdwnIuUtIntLIGTvBskwLhPxt80R7h26Y5cwXJkMXayhweIP9nKWXWA690groc2wY39731E3Y2kvn9Bjj9pPqG4l5AIdRRNYFZomkWKx8pTqnKFrly5k8aebaTvjhomkRTNpu64gYyN6IT+gH9ZvCw3BhaL4Rdp7+m1srpQervKPbiQn1M2+20WoDxp24= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(376002)(366004)(346002)(39860400002)(396003)(451199018)(44832011)(2906002)(36756003)(6666004)(6486002)(8936002)(5660300002)(31686004)(31696002)(316002)(110136005)(86362001)(6512007)(2616005)(41300700001)(478600001)(38100700002)(186003)(66946007)(66476007)(66556008)(53546011)(8676002)(4326008)(26005)(6506007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NktXOExKTFNXNUNVYjlXRTl2VkJFMXJoaTYxeCtqR3BYSGM5bjJ2aDRKcEZk?= =?utf-8?B?WjlUMGNPZXNQbjdSRHBYYUI4cXlWSjVGSTUxdVhaYUp3cXV4SzlGbXhPb0dl?= =?utf-8?B?YXl5NnVTVFIrZWxxaTZqWVg1bnlDVFpIUWJiZlFabTNlRitGOTFMR0tXMXh4?= =?utf-8?B?bXNMRWZZWGI5eUMyV04wL09hWU9rTmprNlQySUo0VHhzUkM2QWM0bUhRakU5?= =?utf-8?B?L01xRWgrT2RpR2l6czVKTGpEU3ErSVBZMW1aK0lqd1JIMGVzOXVqWm1oUndq?= =?utf-8?B?RlEwdlBHUmY0bWVXNlcyS2VaS3lRTDhjSDlUQVJnbWp4V2MzcENsMldoQ2RI?= =?utf-8?B?Rm1zcUROQjZPcEcxK1BTUXNxMnl6bVVyT1c3Smk0OGF0akF0Uy9nMkxJY0Z1?= =?utf-8?B?UXJCMTYyRE8venhSam54RU10YVpLWUV6dVMvMHE4Y0g0QS9FM3JPbE9vQk53?= =?utf-8?B?YWFSVVZ1Qnpnak1wK0FpRmRmWExUUUhzcm55YlJPM0xDbVhJSFVJaWFvQkE1?= =?utf-8?B?Wm1MZkN3YTRYMlhGdjl0TUNLTFM2U0Q0STVUTk9XbXJJL2dpdVVQUGZBY0lj?= =?utf-8?B?bEZYWVdHc1YraVo5TXlVVXVuMkIyWTRaSFBmWGZaNW1XU08wV1c3OUpVeW5n?= =?utf-8?B?eXJZQnJBbEpXRTNtajRiRS94VHZIdkhuTVBLWWtVUjNqdW1UTENwTlVyaldZ?= =?utf-8?B?bEpodEhPYis0SHNWVEhERm5iRFZTVUMybUpOVXRqaEhmWENSV0Y1REIwQmlM?= =?utf-8?B?VE5IeDU5bHFlVVo4WFZHYjBJamFoNE5CTHdPRWJteFJqOFRMaFROZHhBdFVl?= =?utf-8?B?czJiTFFBMDdkdkhmUEJQWTRUbVh2VE12VTMxZ3FQb1d2a3E2bHhnR3dIN3ZY?= =?utf-8?B?U2hKRHl1U3cwRGNBdDFhalVJUWsrRCtlVUxiMTVkSDFob092NXBsUThnQ2xY?= =?utf-8?B?djFobEhMVTdlSzNGb25xK1E1djdHTDdyaStPb0lBVGd4MGhJRjlzS2ZzZFdY?= =?utf-8?B?NDJEUnBPWWNtZ244OTJpNGdIajlVRm5oWWRqdEd5cVhyTjFzWjZnQS85K1Ju?= =?utf-8?B?MEpDS25GMTZyRFJoMWJTY3hNbWxFUTRwTWZMZXByaXZCdWpDbmZVaGVHZW12?= =?utf-8?B?c2RJRS96OXR2UEtId2wyandPb1FPTGtCaU55TmREUEdxczRhVWJtR1hva2tM?= =?utf-8?B?a0xreXlkODFodjZTRVFmUUk1TGFqdnFsRC9HSEdQL3J3ODU3WlMwZGdrZGd2?= =?utf-8?B?OUFEdDBvN2pyVlZJaVFOWUhzbWxVaytFTThnWDZoMzFKMnY0Q05hUkJUbkFu?= =?utf-8?B?c0FlalY0MXpHM0Z2L3hmdlFxVlg4a0RSeGMwcWNXZ1kzQW43d2JHWTVUT0l4?= =?utf-8?B?WEo2T3ZtTE9ZNHllUUo3VUt5SVcyQzRFUm9sN0JOMjJjWDBTTDFTY1JKdFA0?= =?utf-8?B?d0ttSzBzbU9oT3pyb3QxUW5YdFIxWE9mdGtQNklvOFJiN0Q0WDZVbld6VXhY?= =?utf-8?B?OVB0YUFhU0p2UXp5NEJOSXdHbnJ0QUdlOGZtU2o4UW40aGx5UTRsaHgxbUwz?= =?utf-8?B?a2RvUWJmRjFGSWhIcTJyakNXZWdEcVZ5MEN4eldydElDTlZGeHFVUnh1Zm9m?= =?utf-8?B?eE9IOGpXdnN0VjBVM1BGV1BBQmcvTUg2a2o1TklWMGR6eWJxaW5YSjZpMk5U?= =?utf-8?B?Um1RK1ZoTnRObXdDTEtzTHh3eHgvc21INUhkSjJ0aW5ucVE5NE9kY2srM1R1?= =?utf-8?B?UFVRbFQ1RlBVYytwMFJhTy8yNG01cmRvcllLVUk4VC9XOVdzQjNKYmdmdm9a?= =?utf-8?B?ajJMM3piWng5TzBoZkp5RHhOM0tXTGEzN1FBUDVqY3d5eEFBbkZ2NTJ5Z2Ja?= =?utf-8?B?cVpKamc4L2R2dlpuRllsUzd4YnVoU1VMZEYwYUNHczdwSDRERUlUejRWcDYz?= =?utf-8?B?VTUxYmxmTmlEVGs1VDFOWEtydHVqdDhHVENtTDMxRzBJamtaa0FLSitPbm9X?= =?utf-8?B?UjV1YXlZV1ZyMzhFY1luL1REanFyYWRnc1FQUzd0YzB0bVhoNXM2VWU3ejVq?= =?utf-8?B?VndiTlczL01Pa0UzVXk2OWhxSzJNMmdITlRBdnByL213ekREMUlvZkp5V2xK?= =?utf-8?Q?0iNUrOPFPNl6KVOZnrTXvykxK?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f251b95c-a798-4c0d-9e74-08db0bc7d922 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2023 00:35:17.5659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iTN6SV6LjtgZvFrtQBjadmEfKna4h6O3KHUcKXEdeoCAWut7lcQ7trkmmuv98dFu X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6375 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/10/2023 8:26 AM, Rakesh Kudurumalla wrote: > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index b60987db4b..f4eb4232d4 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -2203,6 +2203,17 @@ enum rte_flow_action_type { > */ > RTE_FLOW_ACTION_TYPE_DROP, > > + /** > + * Skip congestion management configuration > + * > + * Using rte_eth_cman_config_set() API the application > + * can configure ethdev Rx queue's congestion mechanism. > + * Introducing RTE_FLOW_ACTION_TYPE_SKIP_CMAN flow action to skip the > + * congestion configuration applied to the given ethdev Rx queue. > + * > + */ > + RTE_FLOW_ACTION_TYPE_SKIP_CMAN, > + Inserting new enum item in to the middle of the enum upsets the ABI checks [1], can it go to the end? [1] 1 function with some indirect sub-type change: [C] 'function size_t rte_flow_copy(rte_flow_desc*, size_t, const rte_flow_attr*, const rte_flow_item*, const rte_flow_action*)' at rte_flow.c:1092:1 has some indirect sub-type changes: parameter 1 of type 'rte_flow_desc*' has sub-type changes: in pointed to type 'struct rte_flow_desc' at rte_flow.h:4326:1: type size hasn't changed 1 data member changes (1 filtered): type of 'rte_flow_action* actions' changed: in pointed to type 'struct rte_flow_action' at rte_flow.h:3775:1: type size hasn't changed 1 data member change: type of 'rte_flow_action_type type' changed: type size hasn't changed 1 enumerator insertion: 'rte_flow_action_type::RTE_FLOW_ACTION_TYPE_SKIP_CMAN' value '8' 50 enumerator changes: 'rte_flow_action_type::RTE_FLOW_ACTION_TYPE_COUNT' from value '8' to '9' at rte_flow.h:2216:1 ...