From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0049.outbound.protection.outlook.com [104.47.32.49]) by dpdk.org (Postfix) with ESMTP id E2DD82C6D for ; Tue, 19 Jun 2018 12:04:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xf0azmQ5/cm/h6d+ZudgIR0mXRwyTAAVYfsdxmyStEY=; b=eACMqUySrfTdH6st/5i2285h9/TG92NkZr67WZyWf/dKZiNQJt6MMVvL5YGzMDWArR4R8IIU4yMF729XnX9CMPJkt+JrA4LuwVgRH4/9IPga9HZrJNkaMuzg2TlkY9ynyRFnYDbTEzv6rMZB5NuFBoKKqYSG7Ffo9sb0ovrPZGU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from hyd1ajoseph-dt.caveonetworks.com (115.113.156.2) by SN6PR07MB4909.namprd07.prod.outlook.com (2603:10b6:805:37::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.14; Tue, 19 Jun 2018 10:04:46 +0000 To: Bruce Richardson , Pablo de Lara Cc: Jerin Jacob , Narayana Prasad , dev@dpdk.org References: <1528477766-15788-1-git-send-email-anoob.joseph@caviumnetworks.com> <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> From: Anoob Joseph Message-ID: Date: Tue, 19 Jun 2018 15:34:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: BM1PR0101CA0034.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::20) To SN6PR07MB4909.namprd07.prod.outlook.com (2603:10b6:805:37::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fd7e48c8-46da-4a97-64d6-08d5d5cc178a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4909; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4909; 3:pComdV9cWa49vT4TkkGZxtbSKliDgClbwXzuQv8XSgTMWJRYOAGRHRcq1ff7L0T3IdpKcpEdx6yY00B7WZOKKZLfBBIWLB52chnWbCRNV61kIGCsQDypxhlL4Z34XRW8R1d/h6cuBwkOUzfe23csxHy1n8lpFky6k2Vuq3cEHubrB+9Rn2LCsAjSm60ECVNflQ7SvzFfwjlrGxUL0MZ+xxdSDUIXDtpL0t5Z/ZjoFkW375+VUGILFlQ0Kb2+cWDQ; 25:La5HSrmwc4bKLJKkpSHqWuL4WRecPjRFZcbsUPF0T6VUZTL7CcY1Ma6eLpeaB5MzM0xrVUg4hr/mdBl4aYXndz71BrA/4pOxMTsCl/GrvlF3YG9XB1d4JuS0xoppv9TpRpc9N98Moz7zKOAvgOltq0yP1t6dGCz0d9Y5fIrpzLGqI0IiNOXH6yPAxijkMSoI5cOdxi78ISaqJ4fACmOv4EUu7GqW72TBehhMRjjE6bJhB3VLDnug0S5TSZ5x4VPkgm1fpiZJaQrWxUjl8Hhlu03Dhjz3/cUwiR1cS4+ZBBwPcCKrv2cSgSAQUuYgD4zJeAooeB2r9ktR0QR/1qaLKw==; 31:jGMpABKyBo8XhYZFgdJouJzbL2dedWt1fsDvZXzFhSKtq3ojASKaa/7q3KBKv1hv9ijwft08vvkbEv2Eb7BfChZ5/BZnM3kXirUdeksqvo0Y9FOrR3VzvrmT5o2pSUrOWkemz3pberDqyVQtanQ/NYOEZRWb+s2VtCN/mR0uez90h3HRPwpQvJIvw2oMr9yJbjWlcDE0bWI14j91TPOpnoeoVJZaVoEPfe1k5A3J3WM= X-MS-TrafficTypeDiagnostic: SN6PR07MB4909: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4909; 20:2akaLj79SWlJEP6kJn0UBndrfHJW5tZXs8YMPm6d/YFVsBbmeDCwI4KYwNukFu1NutQnUWmbQEC8XiLfu3lBDOP38B4xPCg81SL8OaC4rWVQXA3uKSTurOiHTyx3yWjvxNfWeFz7DL/5VI8LZ7DTijihHBWIXpukorLGoBJMXRYKEBsbmXM/0quSqMDPZA+Robou6+pClwzkRuOyU3jGA1j8pvP+uq8nXmLaZmnIJpJZflgiq0M9qcsCDMyTcZ4vihA7jOj4vzqV7+W/lCKqsATRn/wR6uuLNjus1YiqferfWmF2/JmiA/Pg43ERG9RigY1K55Cm3Y1YhAkgn1eSbg5ntHGnFx96muXnSj8PGuP62nNOzONiyGc+BKjJ0p8IwpFDARex/2IiQhDUjTolNwFAglFS5Xa0kPM7c5CGFAVNFmX2O+7HhCYgvqeMx7M7mcSfTixvQH7AdH5gcxgulA7STnsup3e9dvJ2M8Dw8izeh29nJFRA54BxX1zLPfJehcqIAcXYGE9RbKZ62G47ytuStna21ucqplC4eA/5EoaygLz60Y8t7+CGu/VwjqNqwuXSHuYlXumaDKnQ4BZAK3OQUYXA7ViBhQ8SyIMEaUM=; 4:2x2ryg7O7KIXW/67XX0SU+x8OwYcXOiM1qSOYEb6rcTB0TM5OurL6RKX4HWxivrGHZ8XjBtlEs6PsOiH0CAHLhGtavHjPjQhZXt/Pbq6v34Pjs1t9F8bL850W3juRamVBikWVVqbKNmNMsxiiCh1WZi1N2TExdedp17DvzLjyBhjiC7BcWbV9GuJfe6UAtZpIyVPceXQ0N8HFJbqaOuhf0p57gQ1mcA0yL4YE05iq5I90WS2YvOpYiAkwcPbDVAzuFRBMXbeL6nssA9ij7IjlQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(3002001)(93006095)(10201501046)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:SN6PR07MB4909; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4909; X-Forefront-PRVS: 07083FF734 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39860400002)(346002)(376002)(39380400002)(199004)(189003)(69596002)(58126008)(59450400001)(2616005)(486006)(386003)(31696002)(6246003)(55236004)(305945005)(97736004)(16526019)(316002)(53546011)(6506007)(25786009)(956004)(446003)(54906003)(8676002)(110136005)(26005)(2906002)(476003)(186003)(3846002)(5660300001)(11346002)(65826007)(6512007)(7736002)(2486003)(6486002)(65806001)(67846002)(72206003)(6116002)(81166006)(42882007)(81156014)(478600001)(64126003)(4326008)(76176011)(47776003)(50466002)(52146003)(23676004)(36756003)(31686004)(66066001)(230700001)(68736007)(52116002)(8936002)(229853002)(53936002)(65956001)(6666003)(105586002)(53416004)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4909; H:hyd1ajoseph-dt.caveonetworks.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjZQUjA3TUI0OTA5OzIzOkR4VnBrS2VlSEZmRkk1V2RzL1NibWI3STJo?= =?utf-8?B?cmtPb2xRWUJjM1hBVTg4NWd3TVUwSHhVYjgwTk96QjR5eU1ud1AwcUgyaVBX?= =?utf-8?B?NVlnMGFOT3BHR0RGUi9hSHQ2Y2I2aWtJZE1VaVhzWkpNZGJldzJDUVpoazhL?= =?utf-8?B?Wm1TL3JySUdCZFRObjg3OVcwMHRpeDFiQ3R3S1EwMDJXVjloeGpiSFRNTHBq?= =?utf-8?B?ZW14dFpyZlFxT3A1djFlNU5kZ2lyNzQ3MldVcmwrT3h4TE9DdHFPallQZkZa?= =?utf-8?B?SjYxUEtRZ0xtS3lSTGdYUWlNWkxveVlPRUdYbm9OTytheFJtY0Q4Y0RLTEF0?= =?utf-8?B?VmxCVDJzRlQvVFlIdmZoYTZDZ1dya0FpUVlkYXVmS3ZCdjM3a1pCL2JITnZt?= =?utf-8?B?SEFqUXNDeFNJRnpLR1FYR0JJK01COU1Pc1BHMGNlN28rRVBJRGhWakJLMmhI?= =?utf-8?B?YlhKSCtVRm1SNjkzMnhWQW9ndk85a1RqMG84SVB6ditkejlLUmE0UkpwS01v?= =?utf-8?B?cFp3QWZ1WXp4aUpSQnJxbUZkMGVKMFdQaG5teFJkZUphSGN4eVVFa0NlT0Ru?= =?utf-8?B?L0c3NjBvUlhlY2ZUSmYwYm5odVZkY0c2bVV6c0xFVmpjdExtOCt3QlY3Nlkx?= =?utf-8?B?bE9qRkdtVzM2YzBiemNTeWdjMUR6NnRsazFtcElOenJEVnMzTEdVZmpMRXNZ?= =?utf-8?B?enhOS1NuSTBkTGI0TEJyVEFCOE5Cd2lNSWFSbldlWWJvSTF1RVdaeVNFOTJv?= =?utf-8?B?bDNhWk1ydDFKUEZiRHBPY2wzWjg3WldlQVhCRWxNYnNESG9ObXJWYjhkRXhm?= =?utf-8?B?UWh4dUN1bFlHVnQ2aFY4d0g5aG80M3dYU3lOZTJiQXZGMFBtaGg0bWFpemdC?= =?utf-8?B?UlFTTVNKeFRTQUVwb000d1VHdmR1NFNHZWp1bURRSkJQb2V6Q1FPcmplWHh5?= =?utf-8?B?dSs0dnNhWUwxc1BoeEJOM2NIdUR3WVlsRDlkS3pMNlBycGdkYW5TSnpZaWMr?= =?utf-8?B?OHpEUHF6aUEvdXkwRkx4di90ZEs0M05SMzU5V3c1d0doV2Y3NEJQNUI4VkhD?= =?utf-8?B?aGRPdEdLUEQ0NXJGUXJEY1o0RmphK291QnNMSG5VdHF6anVUNXA1ZXRQK2sx?= =?utf-8?B?KzNtdkkyTmk5UzFvSGpPZlVJS0E2bUV6cXI1VFhEYk9oTkFqYXBMbkJGOUVm?= =?utf-8?B?RVJrazE0KzdhcWJvMTdPV3M5QTZjbkJ5V3lHSVZPbUtKbTdHbWVQUldZTFhX?= =?utf-8?B?VGE1V0ludktEWDFoVjAvQWRJNGMxSkJpMlZRUEl2RHZEZmNoamdFbXh1dFZh?= =?utf-8?B?VGh1d2ZoV3J0UFJVWFR2aldWSUpyeCt3OWFrT2R4VW0ybUJBN0VIS0hBSWNC?= =?utf-8?B?RU5scEdmKy9JdC9NZCtYc2Y5VUpra1VvZExqRFlJK0ViTG9HVzdGOThGdHJJ?= =?utf-8?B?Y2ZzcThHUjFHWGhPeDN4dldtT2lpR0kxbmg2NmNtL0FVZTF2RGhZVVNmdUxH?= =?utf-8?B?QU9NZWU0K0hjS0lod3NESkZsT21FTFgxUGhrckI5dEl6cjAwQU92Y0VhenV1?= =?utf-8?B?R1ljYnR6cWs5US83bUpTRnBpYUF6TkZUQmdRMkNkWmxpbkErOThEY0VYWEpU?= =?utf-8?B?QWl4SEN1YTZoc2xhWlljckJuSWp6L1o3dWRhdG1LMXhjMnE5SmJ4R0pLNUxW?= =?utf-8?B?THZOWHRCQVZyRlNCaDdyd1dUZVpIakRja0cwWWp0ZDREd0dleXJjdHpNY3lv?= =?utf-8?B?Y0plaTZOMGlqTjRGc2tHT1hMKzhPbExxa3JBTlE3QWNUMEdNTW1lWjluNVc4?= =?utf-8?B?Mlg4TzBYVGgrenhMMXQxTDhoSGF5aE1NVGdMelVXY3FrQ011Y28yVEowVkV1?= =?utf-8?B?U29ZVkhpMjFaM1ROTzVJWmZyY3AvME1xeSt5dThLZkVMZDMweXJNeU8vd1U5?= =?utf-8?B?bTJaTUFQODRMUWdMOG9WTFFtRjZoYitnQVpId04zbCtBRXJRN0tpSkhiaFpW?= =?utf-8?B?WS9XZzl5QjdGRXRrSUtPKzlUV0EzZUhnYUdTYkxXSXpFNGJmOTRyMmFqcFNj?= =?utf-8?B?WWVncTd2RWhCQjRvVW9VY2duK3RqZ1VUODBLK2MxdkNWSGxHVWpDUnJzcG1X?= =?utf-8?B?MlE9PQ==?= X-Microsoft-Antispam-Message-Info: fkD5G5H2oXZLPldZ7zmn+oTH9m1wqzv8D2WehK9zdbQ8aNo7uEwtP8NT0Bb3RGBbDM3w4NFJKpOXJQUiQxR4ZSPf7oLs8Y1gfd6WKXTFsmZJv/h0PFZ3ifm9Vhgv71lBsve1iUtyCX4FOEe/HVUaD60q2+vhzxeMgx1VP6YEnamYXySR+NWHqd0TD8qsCH16h+qq1jTncJntibEUC9zfApDG9e6G9+TipwKOvcX7ExevNSo6ASq2IzaevliohQ/tDYXYds6oI3XswMc+xnbusc/n2k8Pdoa7igm71YuQ91N0GutWHA6eEJ8ZoGiz65gB X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4909; 6:xvcUCvaG3cU3uSnlQeUsCzLyUxaIg27B51YIYxkBgU/Ny065vJDI2KXdCFJckBL5G2wY5hEZJ9lLYQdilS1kWD21gyEmu/+zN+MFItNZUUbBEy/jCu/L3owYpLS2cLNGWLxECtoMNxhueXDLkhyWOqUBL0+H7lGRzx1FL6O/IVY9Bg3Dn2IVH1uVxXiTJNiCKM1R3ufde5T/W80LlAUgBRtEfz87iSssOt71BSF+HfxQZtTL57YuoqWoUCW0m0ohaHKuX9If7VhWnY2/zJ/v+oiylX1g0JpFng8qBZS81wD590Ga4C1nI9EBp1jWf1OPbaOZisFq7ejacMW0Yf2zZzETb0bo/w+dhzSGU33e6DI8dGsDysTgMp3kSHlL8FaCFvm05O2UUHr0tFmxvYDUfRS9QZsblqwxLphguKVH4BnEqK+j+47koIJs0ieIMVY9R80loFpivbc1LQ8IO1ZxRg==; 5:1blD2K03VD4PxmMakXGKpgh122eaKl6Z8qpwsy8Z+cgRRurh7ZcGgMPjedCOb7HVXwQtHTydcQvUbaLPAMnbIVus5XYz2rekgNwixqjqRQ8nzqSiTU9yRt8QA8bMyAe7hdhZkaW/uP1DDFihyjdz58Vk477i5YoNNL9oF+dSi1Y=; 24:QWXQ/dzDo+YNZtr9Tw/0U++iZnGWYmkcgBU0H1y6USBY5hN+QcK8G5dLDabmXfkkEuqKA/zfB3lbtqPCChmTwUV9HggWMxdy4gkREFCU+fM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4909; 7:SZBhwmgADd3js6AxDQRlq2EDJuajU4JR55jzhvvwJn/TgaOuqD2xQfrA33iB1NUzsU6KiXflJo0kbOC7aNP8dtQnS6MmA52h6LS1BbX44P9xlSwy1UTnvwR9HCHwP0u1wb6GhKohelHu3Gwqb289XOedRSD93SYR9rBJQjmYDGgAcQZWuxrZI8Q4NqcZ1/Tqr8HLJ8w89+buyNXqgHTgkWAASopkamedKSucM3sULV+w7FjyKjfRz/j1apo2sKxK X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2018 10:04:46.8199 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fd7e48c8-46da-4a97-64d6-08d5d5cc178a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4909 Subject: Re: [dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 10:04:51 -0000 Hi Bruce, Pablo, Any comments on this series? Thanks, Anoob On 14/06/18 17:18, Anoob Joseph wrote: > This patchset modularizes l2fwd application to prepare it for eventmode > additions. This patchset doesn't change the code flow or logic, except > for few minor improvements. Some of the newly added functions are used > in just one place, but is added for efficient usage with eventmode. > > v1: > * Fix all checkpatch reported issues > > Anoob Joseph (15): > examples/l2fwd: add new header to move common code > examples/l2fwd: move macro definitions to common header > examples/l2fwd: move structure definitions to common header > examples/l2fwd: move globally accessed vars to common header > examples/l2fwd: add missing space > examples/l2fwd: fix lines exceeding 80 char limit > examples/l2fwd: move dataplane code to new file > examples/l2fwd: remove unused header includes > examples/l2fwd: move drain buffers to new function > examples/l2fwd: optimize check for master core > examples/l2fwd: move periodic tasks to new function > examples/l2fwd: skip timer updates for non master cores > examples/l2fwd: move pkt send code to a new function > examples/l2fwd: use fprint instead of printf for usage print > examples/l2fwd: improvements to the usage print > > examples/l2fwd/Makefile | 1 + > examples/l2fwd/l2fwd_common.h | 63 ++++++++++ > examples/l2fwd/l2fwd_worker.c | 249 +++++++++++++++++++++++++++++++++++++ > examples/l2fwd/l2fwd_worker.h | 16 +++ > examples/l2fwd/main.c | 276 ++++++------------------------------------ > 5 files changed, 364 insertions(+), 241 deletions(-) > create mode 100644 examples/l2fwd/l2fwd_common.h > create mode 100644 examples/l2fwd/l2fwd_worker.c > create mode 100644 examples/l2fwd/l2fwd_worker.h >