From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C75F641D9C; Tue, 28 Feb 2023 12:34:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB2CF40EE4; Tue, 28 Feb 2023 12:34:59 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2041.outbound.protection.outlook.com [40.107.237.41]) by mails.dpdk.org (Postfix) with ESMTP id 21C244021F for ; Tue, 28 Feb 2023 12:34:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J1ka0xnGD7EKQ4e/EX51lIiCTdlygThkvvWJ6PIYf0Zm02z1H7VQ8mrR8Nhe856mmaaxDwXoqhO+IU/eomJiV8EKuNtK3Fzqiu9fje+CCJPzoAzZPYBJRB/YWtOo9thy2XrRm9QuBcp/fUgzkPls8Jiw8okLUSD0ltuEVSUlcszs19B8fF9aJ4HEcDxzOrH9nE83sQkgtTVkYs0vta6Ewj1t2qZ4nxaZODN8DfXylo7ROgpata+FIYKqJIiU1iYN1Pkf9SLOW6YTMeKw+uLAGzsE45NamS7GyzbfMT9uPOjjEa8VX3rGUuG/Y1dH8i6gd+jlSOMgPjCuUBzkPQC6dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XYZDp8r6ZskZUwd6rkXGrS+jiuNmiM43rKr2pAxR2A0=; b=GJpQfsiOVLKAwP+c1TjPpGnE2+J3MtKJgeQa4j4s+uOwc7bXyLeFd8XiirLRR8D7uyKk9zTLZGDWuFv1qzg9IPwj5eRq6wGSWi1RfK7+FPEON/JDd8A8qDDZ2Azr+D4oKte4q5Yoe+oKAkOdj/eoVYdK1pPilEs2+ABP/QFacyHEunUqCeaXJ0KLBBReK/x9RHl65m9mWD77iP97WFkzzrmtJxm+Y/w5dkkra7u7swtDoLI6pyEFpxy0/d4+IYp2xL3p7+6wuoZLNSVQr6yLGop1nGowFgL1eMHDVH65CzcLuJUBSpunFMgaq/xDrknpQ1xC0e+BkUj3Fx5nsIJMWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XYZDp8r6ZskZUwd6rkXGrS+jiuNmiM43rKr2pAxR2A0=; b=tvOzM26pVvke8DVjzIJWT62siTlgaEq3D/nvLK4waCSs2OzwTC5XeLekxZCo/tWNu2s48Le4uq5YXm/FByfMDu0sPfReHCko4Kle8w3TnozUS9Eze2WebBMatTD5XmFdW1BH3W9voVBsR2WFFfp9dKStQ428Nuzj2OZAse07y6w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB6423.namprd12.prod.outlook.com (2603:10b6:8:bd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 11:34:57 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 11:34:56 +0000 Message-ID: Date: Tue, 28 Feb 2023 11:34:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v7 12/21] net/cpfl: support RSS Content-Language: en-US To: "Liu, Mingxia" , "dev@dpdk.org" , "Xing, Beilei" , "Zhang, Yuying" References: <20230213021956.2953088-1-mingxia.liu@intel.com> <20230216003010.3439881-1-mingxia.liu@intel.com> <20230216003010.3439881-13-mingxia.liu@intel.com> <0ca019d8-19dc-2e5a-3910-7eaf12d9fb83@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0572.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB6423:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f7d1bc8-cc21-46d3-e702-08db197fd14c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A1yVql+f82A4aQEa5go6OZfdGfbaZfrPrFQMuKqhO/5Ze1e91h41pr0WgS/fWxWnxg6JWZYBDWAmmn1dzgteohKuXtQXJsHw0908dafxgL5AlZXOfb7G3RoWaLRAxBm0gyHoJd2C3kHu+kWO5cXCYsjSNts70COQ1ALx6Ya5leMgo0Pt9ilmScZmHaZeniy4cyUvfUmlAF8kwL1sUC0zLh3laTjfHtyJse++HW6nc+SJzbnjHmtrcNSurtmnfMm6kw+LkNdLsivYowdYfCZ5VD7p3UqW5Ou11srJTGcS+V4jTGFEg5BsysYlB9ZvtNfJXL+LuHFYj71ZrZpwsoYWhM6ys6A11qfd1Y6XWy3M9id7O5qsr+pTakXzQfUgKBbZOKyIrE9P6zes8Xy5x8WpGuX0XCql25LHOt0dNMJcMhbkleWFL85g5X8ejDxHP6dTURt+S5oxynXl1er4m1aYuZyi4uFFKLUcWEWtLxgoxcTCIglC++WwDydaqu4zNppHaZxB48m0c5qdsIqCjUIDAhLWtrVrZYT8HXfprjksNBveHGfDvKyCpp6ek6PX8OUGRwXr4C9xEyPGQPyqhf7YdFo4rs0mnaHR3qj2MuFx3j1UUXiv21CKq4VMceqK7ZPtr9gBW2noQIG5n0RsTIo5oeCaQre0bzE6ezh41lrIhe3eTesUaoZDrhgRSI7pyjUrKqbndnDM8LApMTqMOBVbYoPG6aZEix65XQX4mKO/1uw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(451199018)(36756003)(6666004)(53546011)(6506007)(6486002)(2616005)(186003)(26005)(6512007)(316002)(41300700001)(110136005)(8676002)(66476007)(66556008)(44832011)(2906002)(8936002)(5660300002)(478600001)(38100700002)(86362001)(31696002)(83380400001)(66946007)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UW43OHBvbDZSK213anJCM3FTelIrMkl5MnFBWEFzQ0srVmtLSEVPZWFnL3hz?= =?utf-8?B?YXEvTTNML3IvQUxzSXBvakQwazBiT0EySU9uM2ZUTW90Ri82bW1SakpVbWJ4?= =?utf-8?B?dUZKZGIyYTZKWWFkYStnMWQrZmsyNGF5QkpUclR5R0lORTNoTThZV3crcFVp?= =?utf-8?B?RkgyL2VTT3BiVk9QcFZlMlo4WC9LQkdCaDl2Zm5FeTRGN055aU5FcnRvekZi?= =?utf-8?B?MmJvNmVFTHZSeXA4ek5obU5nZEtjUkRVNVcyRFlGODVIUkV6S2pidlhHTW9T?= =?utf-8?B?ck1mZTNNU21jUWw0NWl0THFkanZtVTl0Z1hORmYvYVNvbGZkeXFnVU83M0Z3?= =?utf-8?B?ck9pMUdOVURSdldvWVN0RlQxSURJaUhiZzVjQjJaLzJlTVZub3h6ZXBxRksz?= =?utf-8?B?OTBEVnd4OUxwWXhXN1lMN3JNYXpQaW13NVhBbVA0ZHg1RHYzZCtRRlVaZWw0?= =?utf-8?B?K0NaNDNvQjVBY2p3M1dJLzVqQVJNNEtzMkxhOTVCRUJZRlpmTGhZK1NLckFr?= =?utf-8?B?eitMMkgxQmtNdjRRS2xGc2RZZnE2YmxwKzhIY2tLYVdNN3I0MllJcW5pbGF5?= =?utf-8?B?SDhuanZ2WmRRS3MxZnN0YTZkcUcrcUdnbEpObXpHV1F5YXlaeTdqS1VjWFl0?= =?utf-8?B?VDIvNkZrTllOQ0xwaFRIZDlCTHpaYVRESzZMY1VweXQ1N1o0STFqaVBBWVM1?= =?utf-8?B?STA2eER1RzFGeFR0L1BGeG5Yd3JZL0Q5eWxnU1YrK3VwKzhnYlNBMDBLWTV5?= =?utf-8?B?RXJUMFhjeU1DdThSTTNUL2RCNWtVN3VpU1Q1UFpQNmhHbTZycFJ5ZkRrQXZy?= =?utf-8?B?WVpjUWt6ZFh3amUwRXUzOUNmWjhUR2NtUGxmOEVHZnZBYkRaczNYUGtYMytq?= =?utf-8?B?dXEzN2h3dDl3cDRkVFVZb1k0cEVEcWUwdkpubk5kcERBeElZNHAzOVdaMm80?= =?utf-8?B?ZlhTVThUYnpCR1VNZndiN0JFMVpzYWZha2hEMktsNXkxTHpibkRrUXI2eHlT?= =?utf-8?B?aFppM1dDZlVDVGdwM0tGalU3ZkVPQzF0MENhMks0Sjd6UkdRV2IxMGE3RGgy?= =?utf-8?B?dWZqQ3orL01QOURhNzcwNU5CME9sMWFFQXNJZnUyeHV0aVUyWHRCbGVqN1du?= =?utf-8?B?a2FaRkgrZENZeWdBT3lMTldUbkE4UG5NYnZBNk1ETGYyOFppUFZUcmo1d0d1?= =?utf-8?B?OXFlVm1jMTZsTUpWT2JtQzJTT0FOOGNqWkU2bzZZdGNiTTRFd2o2RmNqR205?= =?utf-8?B?WEVrdzMzeVdrTlVaSFN4VG5VTk1tdTVucUtWN25CUzRLWXJaOEc3UkprdDFG?= =?utf-8?B?a0UzbWdaWC94ZFZNZDNKV0RnN2RHTXR5bUZza1E4MWdUM2VJWmI3eU5udGFE?= =?utf-8?B?RUlLMGRUZm5uUDFrVXJZUE1EZU1hWllyOFNEVXNxTkYzd1ByeVk5OHhBcEp4?= =?utf-8?B?ZllOZ1ByM2d0bVplT1BNYVRPN3Nyb3dvL3hXdjV0ZVUxVFo3MHZqZk5FS2Z1?= =?utf-8?B?VFJ4ZE82LzJhMHJ3WEtQaUJDRUFnTmcwc2VhcWsrZ1lGdDFucm9MM1NBMlZN?= =?utf-8?B?SEdDenlYWHV1UjV6UTh0Rm1zUG5nMEMzQi9WL3dETnZMYXBJS3FHdEkxNEsx?= =?utf-8?B?b2dJelJ4WWtUQk5aYmM0OE9NMTZJUUd4UmptZzc5ZWZsdWsyV2F1ZGdDSGxK?= =?utf-8?B?aTMrcGJuWC9QZzIweVAyd3dwRnp4b0k3V2RaZG1xMU4wZVZhWFdtZ0VTMFo3?= =?utf-8?B?QlFOOU9RVHFqTmxDYVVqM1dTaHhYN2FvVWdlNU8veGF5Wmkzc2FBcjVkZkg2?= =?utf-8?B?VmhxYnNjYVkyM2pDc3UzMnlNNEhpRFR4N3MvZlZmdGg5Z1A3ZVlKYzFrY0Nh?= =?utf-8?B?MzFTRm1ubU50a1VEK0wyVTFGZTdJK01IeTlhOE1DdlJPRlZNM3RWQmE0cmJU?= =?utf-8?B?Ry9hREc4UVd1T29BSDY3WFJ6YVdraUNBVUZDY042NEd2SzRqM01KZUNpRWxi?= =?utf-8?B?ZUlLVlc0TEhQWUpwL3d2ZnlHbzFBY2V6dG5PUE1SSkYvd0tsYWpYK2t6SU9t?= =?utf-8?B?aVl3eWtwU05wZkxOL1AzU1RsZEUxdng3MzBkbXdGY0xVSWRTeVFxZzNUZ1I4?= =?utf-8?Q?spZ9AzsbJvNs3Tt/8yj93FWJL?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f7d1bc8-cc21-46d3-e702-08db197fd14c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 11:34:56.8107 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GSMGfc6jQzGNlOvfR72aaYFM84PkplYU5WMh2wGjf+NF92MqJ7qF64+FutpJwQBE X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6423 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/28/2023 11:28 AM, Liu, Mingxia wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, February 28, 2023 5:50 AM >> To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei >> ; Zhang, Yuying >> Subject: Re: [PATCH v7 12/21] net/cpfl: support RSS >> >> On 2/16/2023 12:30 AM, Mingxia Liu wrote: >>> Add RSS support. >>> >>> Signed-off-by: Mingxia Liu >> >> <...> >> >>> static int >>> cpfl_dev_configure(struct rte_eth_dev *dev) { >>> struct idpf_vport *vport = dev->data->dev_private; >>> struct rte_eth_conf *conf = &dev->data->dev_conf; >>> + struct idpf_adapter *adapter = vport->adapter; >>> + int ret; >>> >>> if (conf->link_speeds & RTE_ETH_LINK_SPEED_FIXED) { >>> PMD_INIT_LOG(ERR, "Setting link speed is not supported"); >> @@ -205,6 >>> +245,17 @@ cpfl_dev_configure(struct rte_eth_dev *dev) >>> return -ENOTSUP; >>> } >>> >>> + if (adapter->caps.rss_caps != 0 && dev->data->nb_rx_queues != 0) { >>> + ret = cpfl_init_rss(vport); >>> + if (ret != 0) { >>> + PMD_INIT_LOG(ERR, "Failed to init rss"); >>> + return ret; >>> + } >>> + } else { >>> + PMD_INIT_LOG(ERR, "RSS is not supported."); >>> + return -1; >>> + } >> >> >> Shouldn't driver take into account 'conf->rxmode->mq_mode' and 'conf- >>> rx_adv_conf->rss_conf->*' ? > [Liu, Mingxia] Thanks for your comments, we will add checking of 'conf->rxmode->mq_mode'. > As for 'conf- >rx_adv_conf->rss_conf->*', we checked rss_conf->rss_key_len and rss_conf->rss_key in cpfl_dev_configure()-> cpfl_init_rss(). > > But for now pmd only support default rss_hf according to packge, so ignore the conf->rx_adv_conf->rss_conf->rss_hf. > In the future, it will support configuring rss_hf. > ack, thanks.