From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63BD4A0613 for ; Tue, 30 Jul 2019 19:45:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3748D1BFDD; Tue, 30 Jul 2019 19:45:32 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by dpdk.org (Postfix) with ESMTP id 2D2D71BFDC for ; Tue, 30 Jul 2019 19:45:30 +0200 (CEST) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6UHh2Me038930 for ; Tue, 30 Jul 2019 13:45:29 -0400 Received: from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206]) by mx0b-001b2d01.pphosted.com with ESMTP id 2u2qrxya1n-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 30 Jul 2019 13:45:27 -0400 Received: from localhost by e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 30 Jul 2019 18:45:26 +0100 Received: from b01cxnp22036.gho.pok.ibm.com (9.57.198.26) by e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 30 Jul 2019 18:45:22 +0100 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6UHjMrO15926114 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jul 2019 17:45:22 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F0841AC059; Tue, 30 Jul 2019 17:45:21 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C3119AC05B; Tue, 30 Jul 2019 17:45:20 +0000 (GMT) Received: from davids-mbp.usor.ibm.com (unknown [9.70.84.210]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 30 Jul 2019 17:45:20 +0000 (GMT) To: Jerin Jacob Kollanukkaran , Bruce Richardson , Thomas Monjalon Cc: "dev@dpdk.org" , "stable@dpdk.org" , hgovindh , Marko Kovacevic , Ori Kam , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , "ruifeng.wang@arm.com" , "maciej.czekaj@caviumnetworks.com" References: <20190726132758.55217-1-hariprasad.govindharajan@intel.com> <20190726135858.55792-1-hariprasad.govindharajan@intel.com> <2414234.RRTHkAQoda@xps> <20190730094721.GB1641@bricha3-MOBL.ger.corp.intel.com> From: David Christensen Date: Tue, 30 Jul 2019 10:45:20 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19073017-0072-0000-0000-0000044E6D7A X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011524; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000287; SDB=6.01239692; UDB=6.00653660; IPR=6.01021104; MB=3.00027962; MTD=3.00000008; XFM=3.00000015; UTC=2019-07-30 17:45:26 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19073017-0073-0000-0000-00004CBEDA24 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-30_08:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=728 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907300186 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] examples/l3fwd: fix unaligned memory access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >> On Tue, Jul 30, 2019 at 10:50:14AM +0200, Thomas Monjalon wrote: >>> Review please? >>> >>> 26/07/2019 15:58, hgovindh: >>>> Fix unaligned memory access when reading IPv6 header which leads to >>>> segmentation fault by changing aligned memory read to unaligned >>>> memory read. >>>> >>>> Bugzilla ID: 279 >>>> Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") >>>> Cc: maciej.czekaj@caviumnetworks.com >>>> Cc: stable@dpdk.org >>>> Signed-off-by: hgovindh >>>> --- a/examples/l3fwd/l3fwd_em.c >>>> +++ b/examples/l3fwd/l3fwd_em.c >>>> +#if defined RTE_ARCH_X86 >>>> + key.xmm[1] = _mm_loadu_si128(data1); #else >>>> key.xmm[1] = *(xmm_t *)data1; >>>> - >>>> +#endif >>> >> >> The blank line should be re-added below the #ifdef. Apart from that the fix looks >> correct to me. >> >> Reviewed-by: Bruce Richardson > Reviewed-by: Jerin Jacob Reviewed-by: David Christensen