From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0578A00C3; Sun, 31 Jul 2022 11:40:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 929564067B; Sun, 31 Jul 2022 11:40:43 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id C48C64021E for ; Sun, 31 Jul 2022 11:40:42 +0200 (CEST) Received: from [192.168.1.39] (unknown [188.170.75.116]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 67321FF; Sun, 31 Jul 2022 12:40:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 67321FF DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1659260442; bh=UHR/TEc0NatoLcx3mmD4l3ZXnM43xVSUgjNICi51Te0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=LkqL9QlsJumXwRqwk3bcSdv9jgrflMQeZZcH1GSF5sHVrssTrQMj0uI5Ri39yZezz vnh/FdMW+8twf4HGwQdD/1r4DhYVeJ7TyyHom2GgrRtTKKbQeT23tA0II9zMjrqZ48 bLXblAeOQc6sDzSk8qKtQWB1+ai8CrE287mN/1h8= Message-ID: Date: Sun, 31 Jul 2022 12:40:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Question about pattern types for rte_flow RSS rule Content-Language: en-US To: "lihuisong (C)" , "orika@nvidia.com >> Ori Kam" , "dev@dpdk.org" Cc: Stephen Hemminger , Thomas Monjalon , Ferruh Yigit , huangdaode , "fengchengwen@huawei.com" , "liudongdong (C)" References: <8c5019cf-312e-708a-d1d5-cba666443f87@huawei.com> <6c38207f-d5cb-3b61-c65c-8e22239ff6b2@huawei.com> From: Andrew Rybchenko In-Reply-To: <6c38207f-d5cb-3b61-c65c-8e22239ff6b2@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Huisong! On 7/29/22 05:30, lihuisong (C) wrote: > Hi Ori, and all, > > For RSS flow rule, pattern item types and RSS types in action > are an inclusive relationship, and RSS types contain pattern item > types. I disagree with the statement. We can redirect various packets, but apply RSS on subset only. Everything else goes to the first queue (first entry in the redirection table in fact). > Is it necessary to set pattern item types when specify RSS > types to create a rule? No, it is not strictly required. It depends on what you want. > How should the user set and how should the > driver do? Pattern and action are not strictly related in the case of RSS. Pattern defines on which packets the rule is applied. Action defines what the rule does. If hash function is not applicable to a packet, e.g. ARP packet and ipv4-tcp hash function, the hash is 0 and goes via redirection table entry 0. Andrew. > > Looking forward to your reply. > > Regards, > Huisong > > 在 2022/7/13 9:34, lihuisong (C) 写道: >> Hi all, >> >> Can someone open my confusion? >> I'm looking forward to your reply. >> >> Thanks, >> Huisong. >> >> 在 2022/7/7 11:50, lihuisong (C) 写道: >>> Hi all, >>> >>> From following testpmd command: >>> 'flow create 0 ingress pattern eth / ipv4 / tcp / end actions rss >>> types ipv4-tcp l3-src-only end queues end / end' >>> and >>> "flow create 0 ingress pattern end actions rss types ipv4-tcp >>> l3-src-only end queues end / end" >>> >>> I have some confusions about rte_flow RSS rule: >>> 1> Do pattern item types need to set when configure rte_flow RSS rule? >>> 2> Does the driver need to check and process the pattern? (After all, >>> the RSS types in actions alreadly contain all RSS offload types.) >>> >>> Have someone explains it? >>> >>> Regards, >>> Huisong >>> >>> . >> .