From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 16F4B1B879 for ; Thu, 10 Jan 2019 19:16:21 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6755013AA7; Thu, 10 Jan 2019 18:16:20 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-163.ams2.redhat.com [10.36.117.163]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D9716091D; Thu, 10 Jan 2019 18:16:18 +0000 (UTC) To: Dekel Peled , adrien.mazarguil@6wind.com Cc: dev@dpdk.org, orika@mellanox.com, jackmin@mellanox.com References: <1546520931-60894-1-git-send-email-dekelp@mellanox.com> <1547033879-42061-1-git-send-email-dekelp@mellanox.com> From: Kevin Traynor Organization: Red Hat Message-ID: Date: Thu, 10 Jan 2019 18:16:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <1547033879-42061-1-git-send-email-dekelp@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 10 Jan 2019 18:16:20 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] doc: fix MAC address rewrite actions documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 18:16:21 -0000 On 01/09/2019 11:37 AM, Dekel Peled wrote: > This patch fixes a typo in SET_MAC_DST action description. > It also adds restriction note for set MAC src/dst actions description. > > Fixes: 15dbcdaada77 ("ethdev: add generic MAC address rewrite actions") Cc: stable@dpdk.org unless there's a reason not to > Cc: jackmin@mellanox.com > > Signed-off-by: Dekel Peled > --- > doc/guides/prog_guide/rte_flow.rst | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst > index c186375..dbf4999 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -2314,7 +2314,10 @@ in pattern, Some PMDs will reject rule because behaviour will be undefined. > Action: ``SET_MAC_SRC`` > ^^^^^^^^^^^^^^^^^^^^^^^ > > -Set source MAC address > +Set source MAC address. > + > +It must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern item. > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. > > .. _table_rte_flow_action_set_mac_src: > > @@ -2329,7 +2332,10 @@ Set source MAC address > Action: ``SET_MAC_DST`` > ^^^^^^^^^^^^^^^^^^^^^^^ > > -Set source MAC address > +Set destination MAC address. > + > +It must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern item. > +Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned. > > .. _table_rte_flow_action_set_mac_dst: > >