From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id A49F942D09;
Tue, 20 Jun 2023 16:27:19 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 885EA4068E;
Tue, 20 Jun 2023 16:27:19 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id BB27340EDF
for <dev@dpdk.org>; Tue, 20 Jun 2023 16:27:17 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1687271237;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=Oimj9uatMsUMSX7o2Q6kpla5INYbVXyZhvdQ5YX8hdc=;
b=idRq0CLA2y4cL3yEH/2N8GirUelYfN2xNPx/Fmmg1R4cW9xwApr3b4K9qW7d1ceEg8SCZu
rmoMU0xDTZualA5ubSupd1NN/X+SUZ0zVME0C+u3lPDdmcvNafGF/PSiyXmv8dH+BAswqI
xka0ZuUGNl18SXkvmUXkgRMF0dp0/fo=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
[66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
us-mta-219-_tRmUsdUMky-q-XlrO_rhQ-1; Tue, 20 Jun 2023 10:27:09 -0400
X-MC-Unique: _tRmUsdUMky-q-XlrO_rhQ-1
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com
[10.11.54.9])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0F0801C0A5B8;
Tue, 20 Jun 2023 14:21:35 +0000 (UTC)
Received: from RHTPC1VM0NT (unknown [10.22.34.71])
by smtp.corp.redhat.com (Postfix) with ESMTPS id B8467492B01;
Tue, 20 Jun 2023 14:21:34 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org, Michael Santana
<maicolgabriel@hotmail.com>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] ci: fix libabigail cache in GHA
References: <20230620132955.46852-1-david.marchand@redhat.com>
Date: Tue, 20 Jun 2023 10:21:34 -0400
In-Reply-To: <20230620132955.46852-1-david.marchand@redhat.com> (David
Marchand's message of "Tue, 20 Jun 2023 15:29:55 +0200")
Message-ID: <f7t1qi6uscx.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
David Marchand <david.marchand@redhat.com> writes:
> In repositories where multiple branches run the ABI checks using
> different versions of libabigail (for example, a 22.11 branch using
> libabigail-1.8 and a main branch using libabigail-2.1), a collision
> happens on the libabigail binary cache entry.
> As a single cache entry is used, the content of the cache (let's say the
> cache was built for libabigail 2.1) won't match what the branch wants to
> use (in this example running the check for 22.11 branch requires
> libabigail 1.8).
> .ci/linux-build.sh then tries to recompile libabigail but it fails as
> the packages used for building libabigail are missing.
>
> Add the version to the cache entry name to avoid this collision.
>
> Fixes: 443267090edc ("ci: enable v21 ABI checks")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Aaron Conole <aconole@redhat.com>