From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BCAFA0093; Thu, 9 Dec 2021 14:15:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BED3410DC; Thu, 9 Dec 2021 14:15:13 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A592C40FDF for ; Thu, 9 Dec 2021 14:15:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639055712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9DQlXYcSIS1F0wBjZqAegZUXer3KsE18oRrQZyoIHiU=; b=X/Kc+0kIR0TEmNjYI8zaxGUaXeQbgERsKk+XdYfB88TlXrJzwLIEZxgdaypVaKJM2y8Lfs 7/zpkeWSQmh215L0eYEfh5TRSlc5ajEc9GvKBUiaPyozt7WmFskBmy9fJDrUldfsoHpwBi Kwxp0+SlvuCtFImnFxSyZUhYNF5zgaM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-36-uWhi1xihNDiyQZkYpRYt9Q-1; Thu, 09 Dec 2021 08:15:05 -0500 X-MC-Unique: uWhi1xihNDiyQZkYpRYt9Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1484110144E3; Thu, 9 Dec 2021 13:15:04 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.35.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B4F5F197FC; Thu, 9 Dec 2021 13:15:02 +0000 (UTC) From: Aaron Conole To: Jerin Jacob Cc: Jie Zhou , dpdk-dev , Dmitry Kozlyuk , "Richardson, Bruce" , roretzla@microsoft.com, Narcisa Ana Maria Vasile , "Dmitry Malloy (MESHCHANINOV)" , Pallavi Kadam , talshn@nvidia.com, Thomas Monjalon Subject: Re: [PATCH v14 04/11] app/test: skip interrupt tests on Windows References: <1638928262-13177-1-git-send-email-jizh@linux.microsoft.com> <1638990000-3228-1-git-send-email-jizh@linux.microsoft.com> <1638990000-3228-5-git-send-email-jizh@linux.microsoft.com> Date: Thu, 09 Dec 2021 08:15:01 -0500 In-Reply-To: (Jerin Jacob's message of "Thu, 9 Dec 2021 13:19:42 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Jerin Jacob writes: > On Thu, Dec 9, 2021 at 12:30 AM Jie Zhou wrote: >> >> Even though test_interrupts.c can compile on Windows, skip interrupt >> tests for now since majority of eal_interrupt on Windows are stubs. >> Will remove the skip after interrupt being fully enabled on Windows. >> >> Signed-off-by: Jie Zhou >> Acked-by: Dmitry Kozlyuk >> >> --- >> app/test/test_interrupts.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/app/test/test_interrupts.c b/app/test/test_interrupts.c >> index 2a05399f96..eec9b2805b 100644 >> --- a/app/test/test_interrupts.c >> +++ b/app/test/test_interrupts.c >> @@ -12,6 +12,15 @@ >> >> #include "test.h" >> >> +#ifdef RTE_EXEC_ENV_WINDOWS > > Across the series, > Instead of adding conditional compilation everywhere, Why not disable > specific file > for compilation for windows? > Purpose of EAL to abstract the differences in execution environment > and application > should not know that. I think this was done because there would be two test lists in the meson unit test file. But this is the second comment about these ifdef's, and maybe we should revisit that discussion. Is there a different way to accomplish not running the tests which are not appropriate for windows builds, while not having two overlapping lists of unit tests in the meson build file? >> +static int >> +test_interrupt(void) >> +{ >> + printf("Interrupt on Windows is not fully supported yet, skipping test\n"); >> + return TEST_SKIPPED; >> +} >> +#else >> + >> #define TEST_INTERRUPT_CHECK_INTERVAL 100 /* ms */ >> >> /* predefined interrupt handle types */ >> @@ -590,5 +599,6 @@ test_interrupt(void) >> >> return ret; >> } >> +#endif /*ifdef RTE_EXEC_ENV_WINDOWS*/ >> >> REGISTER_TEST_COMMAND(interrupt_autotest, test_interrupt); >> -- >> 2.31.0.vfs.0.1 >>