From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1790A0A0A; Mon, 5 Apr 2021 14:10:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B540140EC5; Mon, 5 Apr 2021 14:10:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 77D36140EC4 for <dev@dpdk.org>; Mon, 5 Apr 2021 14:10:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617624630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TALwQiGNnt9i0qMzpCNivd4FXRuJbhBOpWIV6xge5e0=; b=dL+TxllmRdbkwdnAbh25c6HvclUAL4UKo/26UaCRVtHn6Mjp+Eqi9ZZXTEVW1y6VjmspnX 8+A6QAW+2HX/sGgyzQe+Oddgdp6IcDg0Z9t/GAOl/L4ho9r8VvgPnHUY8+sqc+hnFzlHeu 5/jKQhg1RRx8P41AfPbcnQBWegeWLJo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-47-DRFFh_-lPE-_EWcwxVu-eg-1; Mon, 05 Apr 2021 08:10:26 -0400 X-MC-Unique: DRFFh_-lPE-_EWcwxVu-eg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E6423108BD0D; Mon, 5 Apr 2021 12:10:24 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-113-108.rdu2.redhat.com [10.10.113.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B6AA19704; Mon, 5 Apr 2021 12:10:23 +0000 (UTC) From: Aaron Conole <aconole@redhat.com> To: Ciara Power <ciara.power@intel.com> Cc: dev@dpdk.org, declan.doherty@intel.com, gakhil@marvell.com, hemant.agrawal@nxp.com, anoobj@marvell.com, ruifeng.wang@arm.com, asomalap@amd.com, ajit.khaparde@broadcom.com, g.singh@nxp.com References: <20210402142424.1353789-1-ciara.power@intel.com> <20210402142424.1353789-2-ciara.power@intel.com> Date: Mon, 05 Apr 2021 08:10:22 -0400 In-Reply-To: <20210402142424.1353789-2-ciara.power@intel.com> (Ciara Power's message of "Fri, 2 Apr 2021 14:24:19 +0000") Message-ID: <f7t1rbprky9.fsf@dhcp-25.97.bos.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH v2 1/6] app/test: refactor of unit test suite runner X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Ciara Power <ciara.power@intel.com> writes: > Some small changes were made to the unit test suite runner for > readability and to enable reuse of some of the function in a later patch. > > On test suite setup skip/fail, the loop to count testcases as > skipped/failed has been moved to another function. > This will allow for recursion in a later patch when nested sub-testsuites > are used. > > The unit test suite runner accessed the list of testcases in the suite > structure every time the testcase was used. This is now replaced by a > testcase variable which improves readability. > > A macro has been introduced for readability, instead of using open > coded loops. > > Rather than keep local variable status counts for testcases, > these are added to the test suite structure. > > The summary output now prints the suite name, this will be useful later > when multiple nested sub-testsuites are being run. > > Signed-off-by: Ciara Power <ciara.power@intel.com> > > --- > v2: > - Added macro to loop testcases in suite. > - Testcase counts added to the test suite structure. > --- Acked-by: Aaron Conole <aconole@redhat.com>