From: Aaron Conole <aconole@redhat.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Joyce Kong <Joyce.Kong@arm.com>,
"maxime.coquelin\@redhat.com" <maxime.coquelin@redhat.com>,
"chenbo.xia\@intel.com" <chenbo.xia@intel.com>,
"jerinj\@marvell.com" <jerinj@marvell.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
"dev\@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
David Marchand <david.marchand@redhat.com>,
"thomas\@monjalon.net" <thomas@monjalon.net>,
"dpdklab\@iol.unh.edu" <dpdklab@iol.unh.edu>, "Chen\,
Zhaoyan" <zhaoyan.chen@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 2/4] net/virtio: add vectorized packed ring Rx NEON path
Date: Mon, 11 Jan 2021 08:05:00 -0500 [thread overview]
Message-ID: <f7t1rer8w03.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <DBAPR08MB5814F4E1B149BAB0403140D898AE0@DBAPR08MB5814.eurprd08.prod.outlook.com> (Honnappa Nagarahalli's message of "Fri, 8 Jan 2021 22:26:13 +0000")
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> writes:
> <snip>
>
>>
>> On 11/17/2020 10:06 AM, Joyce Kong wrote:
>> > + /**
>> > + * Update data length and packet length for descriptor.
>> > + * structure of pkt_mb:
>> > + * --------------------------------------------------------------------
>> > + * |32 bits pkt_type|32 bits pkt_len|16 bits data_len|16 bits
>> vlan_tci|
>> > + * --------------------------------------------------------------------
>> > + */
>> > + pkt_mb[0] = vreinterpretq_u64_u8(vqtbl1q_u8(
>> > + vreinterpretq_u8_u64(desc[0]), shuf_msk1));
>> > + pkt_mb[1] = vreinterpretq_u64_u8(vqtbl1q_u8(
>> > + vreinterpretq_u8_u64(desc[0]), shuf_msk2));
>> > + pkt_mb[2] = vreinterpretq_u64_u8(vqtbl1q_u8(
>> > + vreinterpretq_u8_u64(desc[1]), shuf_msk1))'
>>
>> s\'\;
>>
>> I will fix in next-net but my concern is why this has been not caught by any of
>> our automated builds?
>>
>> In patchwork only test report seems from the 'checkpatch':
>> https://patches.dpdk.org/patch/84260/
>
> Looking at [1], Travis CI has not run and the UNH CI did not have Arm
> builds enabled at the time this patch was submitted.
Seem my other email. Travis CI doesn't run 'patch-at-a-time' for
execution time reasons.
> [1] https://patches.dpdk.org/patch/84262/
next prev parent reply other threads:[~2021-01-11 13:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 12:09 [dpdk-dev] [RFC 0/3] Vectorize packed ring RX path with NEON Joyce Kong
2020-09-11 12:09 ` [dpdk-dev] [RFC 1/3] net/virtio: move AVX based Rx and Tx code to separate file Joyce Kong
2020-09-11 12:09 ` [dpdk-dev] [RFC 2/3] net/virtio: add vectorized packed ring Rx NEON path Joyce Kong
2020-09-11 12:09 ` [dpdk-dev] [RFC 3/3] net/virtio: add election for packed vector " Joyce Kong
2020-10-05 7:34 ` [dpdk-dev] [RFC 0/3] Vectorize packed ring RX path with NEON Maxime Coquelin
2020-10-08 6:54 ` Joyce Kong
2020-10-15 9:01 ` Ruifeng Wang
2020-10-15 9:02 ` Maxime Coquelin
2020-11-17 10:06 ` [dpdk-dev] [PATCH v1 0/4] Vectorize packed ring RX/TX " Joyce Kong
2020-11-17 10:06 ` [dpdk-dev] [PATCH v1 1/4] net/virtio: move AVX based Rx and Tx code to separate file Joyce Kong
2021-01-05 14:06 ` Maxime Coquelin
2020-11-17 10:06 ` [dpdk-dev] [PATCH v1 2/4] net/virtio: add vectorized packed ring Rx NEON path Joyce Kong
2021-01-05 14:16 ` Maxime Coquelin
2021-01-05 14:27 ` Maxime Coquelin
2021-01-07 10:39 ` Maxime Coquelin
2021-01-08 7:29 ` Joyce Kong
2021-01-08 17:02 ` Ferruh Yigit
2021-01-08 22:26 ` Honnappa Nagarahalli
2021-01-11 13:05 ` Aaron Conole [this message]
2021-01-11 10:45 ` Maxime Coquelin
2021-01-11 13:04 ` Aaron Conole
2020-11-17 10:06 ` [dpdk-dev] [PATCH v1 3/4] net/virtio: add vectorized packed ring Tx " Joyce Kong
2021-01-05 14:33 ` Maxime Coquelin
2020-11-17 10:06 ` [dpdk-dev] [PATCH v1 4/4] net/virtio: add election for packed vector " Joyce Kong
2021-01-05 14:42 ` Maxime Coquelin
2021-01-08 9:11 ` [dpdk-dev] [PATCH v1 0/4] Vectorize packed ring RX/TX path with NEON Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7t1rer8w03.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Joyce.Kong@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dpdklab@iol.unh.edu \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=maxime.coquelin@redhat.com \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
--cc=zhaoyan.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).