From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <aconole@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id A0E51C13E
for <dev@dpdk.org>; Mon, 7 Dec 2015 20:58:20 +0100 (CET)
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
by mx1.redhat.com (Postfix) with ESMTPS id 9D31167C21
for <dev@dpdk.org>; Mon, 7 Dec 2015 19:58:19 +0000 (UTC)
Received: from aconole.bos.csb (dhcp-25-142.bos.redhat.com [10.18.25.142])
by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
tB7JwIGn007336
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
Mon, 7 Dec 2015 14:58:19 -0500
From: Aaron Conole <aconole@redhat.com>
To: Panu Matilainen <pmatilai@redhat.com>
References: <ad61f137b8749b71ca2756b8c4f888309ce44790.1449484596.git.pmatilai@redhat.com>
<1fa0db8a2358e8afc33cd9d440ac8bd6d302eb56.1449484978.git.pmatilai@redhat.com>
Date: Mon, 07 Dec 2015 14:58:18 -0500
In-Reply-To: <1fa0db8a2358e8afc33cd9d440ac8bd6d302eb56.1449484978.git.pmatilai@redhat.com>
(Panu Matilainen's message of "Mon, 7 Dec 2015 12:45:36 +0200")
Message-ID: <f7t1tayjajp.fsf@aconole.bos.csb>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: fix external shared library
dependencies of drivers, round 2
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Dec 2015 19:58:21 -0000
Panu Matilainen <pmatilai@redhat.com> writes:
> Similar to commit 5f9115e58cc6f304ff4ade694cf5823d32887d1a, but
> for qat and mpipe drivers. The former did not exist when the
> previous patch was sent and latter I just missed.
>
> Fixes: 5f9115e58cc6 ("mk: fix shared library dependencies of drivers")
>
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> ---
>
> v2:
> - typo/copy-paste error -gxio -> -lgxio
>
> drivers/crypto/qat/Makefile | 1 +
> drivers/net/mpipe/Makefile | 1 +
> mk/rte.app.mk | 8 +++++---
> 3 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/qat/Makefile b/drivers/crypto/qat/Makefile
> index e027ff9..258c2d5 100644
> --- a/drivers/crypto/qat/Makefile
> +++ b/drivers/crypto/qat/Makefile
> @@ -41,6 +41,7 @@ CFLAGS += $(WERROR_FLAGS)
>
> # external library include paths
> CFLAGS += -I$(SRCDIR)/qat_adf
> +LDLIBS += -lcrypto
>
> # library source files
> SRCS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += qat_crypto.c
> diff --git a/drivers/net/mpipe/Makefile b/drivers/net/mpipe/Makefile
> index 552b303..46f046d 100644
> --- a/drivers/net/mpipe/Makefile
> +++ b/drivers/net/mpipe/Makefile
> @@ -32,6 +32,7 @@ include $(RTE_SDK)/mk/rte.vars.mk
> LIB = librte_pmd_mpipe.a
>
> CFLAGS += $(WERROR_FLAGS) -O3
> +LDLIBS += -lgxio
>
> EXPORT_MAP := rte_pmd_mpipe_version.map
>
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 90ec33d..856cac0 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -108,6 +108,9 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -libverbs
> _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -libverbs
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SZEDATA2) += -lsze2
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lxenstore
> +# QAT PMD has a dependency on libcrypto (from openssl) for
> calculating HMAC precomputes
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += -lcrypto
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_MPIPE_PMD) += -lgxio
> endif # CONFIG_RTE_BUILD_COMBINE_LIBS or not CONFIG_RTE_BUILD_SHARED_LIBS
>
> _LDLIBS-y += --start-group
> @@ -144,14 +147,13 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_E1000_PMD) +=
> -lrte_pmd_e1000
> _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -lrte_pmd_mlx4
> _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -lrte_pmd_mlx5
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SZEDATA2) += -lrte_pmd_szedata2
> -_LDLIBS-$(CONFIG_RTE_LIBRTE_MPIPE_PMD) += -lrte_pmd_mpipe -lgxio
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_MPIPE_PMD) += -lrte_pmd_mpipe
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_RING) += -lrte_pmd_ring
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += -lrte_pmd_pcap
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += -lrte_pmd_af_packet
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += -lrte_pmd_null
>
> -# QAT PMD has a dependency on libcrypto (from openssl) for
> calculating HMAC precomputes
> -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += -lrte_pmd_qat -lcrypto
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += -lrte_pmd_qat
>
> # AESNI MULTI BUFFER is dependent on the IPSec_MB library
> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += -lrte_pmd_aesni_mb
Acked-by: Aaron Conole <aconole@redhat.com>