From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net,
Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [PATCH 1/2] ci: treat warning as error for MSVC builds in GHA
Date: Thu, 12 Jun 2025 08:54:35 -0400 [thread overview]
Message-ID: <f7t34c5t910.fsf@redhat.com> (raw)
In-Reply-To: <20250610083643.8466-1-david.marchand@redhat.com> (David Marchand's message of "Tue, 10 Jun 2025 10:36:41 +0200")
David Marchand <david.marchand@redhat.com> writes:
> Some trivial builds warnings with MSVC were missed as those were not
> treated as errors.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Aaron Conole <aconole@redhat.com>
> .github/workflows/build.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
> index 1e289979e3..e5f17ef6ac 100644
> --- a/.github/workflows/build.yml
> +++ b/.github/workflows/build.yml
> @@ -198,7 +198,7 @@ jobs:
> shell: cmd
> run: |
> call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64
> - meson setup -Denable_stdatomic=true build
> + meson setup -Denable_stdatomic=true -Dwerror=true build
> - name: Build
> shell: cmd
> run: |
prev parent reply other threads:[~2025-06-12 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 8:36 David Marchand
2025-06-10 8:36 ` [PATCH 2/2] test/lcore: fix build with MSVC David Marchand
2025-06-11 8:46 ` David Marchand
2025-06-12 12:54 ` Aaron Conole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7t34c5t910.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).