From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4250D41CC0; Fri, 17 Feb 2023 15:25:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C7AAF40EE3; Fri, 17 Feb 2023 15:25:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8FD8E40EE1 for ; Fri, 17 Feb 2023 15:25:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676643929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wmrbs5X6drm/fRERhHks6UQ7FxVrJg3pm+bHhN1deuo=; b=A0h0Nsuzf9Sgiu9+YrBMYr37U0MsUF3vxQXSzvoj6//1iWWq9AAcsvktIrAVYBYCC3D/QM eK6UO6IUdlpzm55GPiFVoYRkAGvnmAPVBgUgSVIxA9TdMuMfYARn+wzfZQGgW5XRfHOEtD Rbt+v/w3nv5cw9iNoXgujljknopRlIA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-642-943d-A96PVq-CGhBasN9Mw-1; Fri, 17 Feb 2023 09:25:24 -0500 X-MC-Unique: 943d-A96PVq-CGhBasN9Mw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 39F953804501; Fri, 17 Feb 2023 14:25:23 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.18.173]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2834E1121314; Fri, 17 Feb 2023 14:25:22 +0000 (UTC) From: Aaron Conole To: Morten =?utf-8?Q?Br=C3=B8rup?= Cc: "Ferruh Yigit" , "Lu, Wenzhuo" , "Kamalakshitha Aligeri" , "Zhang, Yuying" , "Xing, Beilei" , "Matz, Olivier" , , "Richardson, Bruce" , , , , , , "Lincoln Lavoie" , , Subject: Re: [PATCH v3 1/2] net/i40e: replace put function References: <20230210065407.209567-2-kamalakshitha.aligeri@arm.com> <20230213181826.145685-1-kamalakshitha.aligeri@arm.com> <20230213181826.145685-2-kamalakshitha.aligeri@arm.com> <98CBD80474FA8B44BF855DF32C47DC35D87743@smartserver.smartshare.dk> <8597de36-9026-3c4d-f1ed-7d759e8242b9@amd.com> <98CBD80474FA8B44BF855DF32C47DC35D8774E@smartserver.smartshare.dk> Date: Fri, 17 Feb 2023 09:25:21 -0500 In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8774E@smartserver.smartshare.dk> ("Morten =?utf-8?Q?Br=C3=B8rup=22's?= message of "Fri, 17 Feb 2023 12:24:13 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Morten Br=C3=B8rup writes: >> From: Ferruh Yigit [mailto:ferruh.yigit@amd.com] >> Sent: Friday, 17 February 2023 11.05 >>=20 >> On 2/17/2023 7:52 AM, Morten Br=C3=B8rup wrote: >> >> From: Lu, Wenzhuo [mailto:wenzhuo.lu@intel.com] >> >> Sent: Friday, 17 February 2023 03.03 >> >> >> >> Hi Kamalakshitha, >> >> >> >>> From: Kamalakshitha Aligeri >> >>> Sent: Tuesday, February 14, 2023 2:18 AM >> >>> >> >>> Integrated zero-copy put API in mempool cache in i40e PMD. >> >>> On Ampere Altra server, l3fwd single core's performance improves by >> >> 5% with >> >>> the new API >> >>> >> >>> Signed-off-by: Kamalakshitha Aligeri >> >> >>> Reviewed-by: Ruifeng Wang >> >>> Reviewed-by: Feifei Wang >> >> We're trying to check the performance improvement. But met compile >> >> failure. The same as CI reported, >> http://mails.dpdk.org/archives/test- >> >> report/2023-February/353245.html. >> > >> > It depends on this patch: >> > https://patchwork.dpdk.org/project/dpdk/patch/20230213122437.122858- >> 1-mb@smartsharesystems.com/ >> > >> > Does anyone know how to formally add such a dependency to the patch >> description, so the CI can understand it? >> > >>=20 >> Hi Morten, >>=20 >> This has been discussed in the past and a syntax defined: >> https://doc.dpdk.org/guides/contributing/patches.html#patch- >> dependencies > > So for this patch, Kamalakshitha should add the tag: > > Depends-on: series-26984 ("[v9] mempool cache: add zero-copy get and put = functions") I think just: Depends-on: series-26984 In the first patch, or cover letter. That said, I did a quick test and the 0day bot should support it now. >>=20 >> But the problem is CI not implemented it yet, it was in the CI backlog >> last time I remember but I don't know current status. @Aaron may know.