DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: dev@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>,
	 ci@dpdk.org,  Michael Santana <msantana@redhat.com>,
	 Ilya Maximets <i.maximets@ovn.org>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2] test: remove strict timing requirements from alarm and cycles tests
Date: Wed, 26 May 2021 09:06:10 -0400	[thread overview]
Message-ID: <f7t5yz5ablp.fsf@redhat.com> (raw)
In-Reply-To: <f7tk0nlaeq7.fsf@redhat.com> (Aaron Conole's message of "Wed, 26 May 2021 07:58:40 -0400")

Aaron Conole <aconole@redhat.com> writes:

> The tests 'alarm_autotest' and 'cycles_autotest' rely on the underlying
> system having very accurate and precise timing.  On systems where the
> timing isn't as rigid, or the load is particularly high, these tests are
> unreliable since the wake latency from the scheduler can be high enough
> to miss the timing window.
>
> Remove the timing related tests from the test suites.  These tests now
> ensure the add/remove callback infrastructure unit tests, but drop the
> waits and reliance on system timing and load.
>
> This avoids FAIL on various testing infrastructures.
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
> v2: Drop the timing requirements, but keep the API calls

NAK - I have a v3 for this with some stuff that was missed.


  reply	other threads:[~2021-05-26 13:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25  0:16 [dpdk-dev] [PATCH] test: drop 'alarm_autotest' and 'cycles_autotest' from test suite Aaron Conole
2021-05-25  8:05 ` [dpdk-dev] [dpdk-ci] " Thomas Monjalon
2021-05-25 13:21   ` Aaron Conole
2021-05-26 11:58 ` [dpdk-dev] [PATCH v2] test: remove strict timing requirements from alarm and cycles tests Aaron Conole
2021-05-26 13:06   ` Aaron Conole [this message]
2021-06-03 13:46 ` [dpdk-dev] [PATCH v3] " Aaron Conole
2021-06-03 15:22   ` [dpdk-dev] [PATCH v4] " Aaron Conole
2021-06-03 16:13     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7t5yz5ablp.fsf@redhat.com \
    --to=aconole@redhat.com \
    --cc=ci@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=i.maximets@ovn.org \
    --cc=msantana@redhat.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).