From: Aaron Conole <aconole@redhat.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, thomas@monjalon.net,
ruifeng.wang@arm.com, nd@arm.com
Subject: Re: [dpdk-dev] [PATCH] test/ring: fix long compilation time
Date: Fri, 01 May 2020 08:56:58 -0400 [thread overview]
Message-ID: <f7t5zdfertx.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <f7tzhatdtg5.fsf@dhcp-25.97.bos.redhat.com> (Aaron Conole's message of "Thu, 30 Apr 2020 08:55:06 -0400")
Aaron Conole <aconole@redhat.com> writes:
> Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> writes:
>
>> test_ring.c takes lot of time to compile with clang. It is
>> reproducable with compiler version 8.0 on Ubuntu 18.04.
>> Amount of testing is reduced, but attempt is made to keep
>> the same coverage.
>>
>> Reported-by: Aaron Conole <aconole@redhat.com>
>> Reported-by: Thomas Monjalon <thomas@monjalon.net>
>> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
>> ---
>
> Thanks, Honnappa!
>
> One thing to note, I don't see this with just clang - it occurs with gcc
> as well. I'm going to test this patch today.
Sorry I forgot to send the reply. This got me further in my work, so
I'm happy with it from that perspective.
BUT, it still did take a bit longer with this version than with
Konstantin's patch. I have no opinion which is the more "technically
correct" version.
prev parent reply other threads:[~2020-05-01 12:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 1:56 Honnappa Nagarahalli
2020-04-30 10:23 ` Thomas Monjalon
2020-06-16 12:47 ` Thomas Monjalon
2020-06-25 8:19 ` David Marchand
2020-06-25 11:05 ` Ananyev, Konstantin
2020-07-02 20:42 ` Honnappa Nagarahalli
2020-04-30 12:55 ` Aaron Conole
2020-04-30 16:03 ` Honnappa Nagarahalli
2020-04-30 17:01 ` Aaron Conole
2020-04-30 19:51 ` Honnappa Nagarahalli
2020-05-01 12:56 ` Aaron Conole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7t5zdfertx.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).