Re: [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods

[Aaron Conole <aconole@redhat.com>]

Thomas Monjalon <thomas@monjalon.net> writes:

> The kernel modules are not built by default since below commit.
> The Travis CI matrix can be simplified
> by removing the redundant option enable_kmods=false,
> and by removing some jobs which become redundant.
>
> Note: there is no benefit in checking kmods in Travis Ubuntu.
> Anyway different kernel versions and distributions are needed,
> and the Technical Board is looking at moving the Linux kmods
> out of this repository.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---

Looks good to me, but do you think there's no benefit to even compiling
the kernel modules that get shipped?

Otherwise,
Acked-by: Aaron Conole <aconole@redhat.com>


>  .travis.yml | 28 ++++------------------------
>  1 file changed, 4 insertions(+), 24 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 22539d8238..19422d4b3c 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -38,8 +38,6 @@ before_install: ./.ci/${TRAVIS_OS_NAME}-setup.sh
>  env:
>    - DEF_LIB="static"
>    - DEF_LIB="shared"
> -  - DEF_LIB="static" OPTS="-Denable_kmods=false"
> -  - DEF_LIB="shared" OPTS="-Denable_kmods=false"
>    - DEF_LIB="shared" RUN_TESTS=1
>  
>  matrix:
> @@ -50,13 +48,13 @@ matrix:
>        apt:
>          packages:
>            - *build_32b_packages
> -  - env: DEF_LIB="static" OPTS="-Denable_kmods=false" AARCH64=1
> +  - env: DEF_LIB="static" AARCH64=1
>      compiler: gcc
>      addons:
>        apt:
>          packages:
>            - *aarch64_packages
> -  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" AARCH64=1
> +  - env: DEF_LIB="shared" AARCH64=1
>      compiler: gcc
>      addons:
>        apt:
> @@ -75,13 +73,7 @@ matrix:
>          packages:
>            - *extra_packages
>            - *doc_packages
> -  - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
> -    compiler: gcc
> -    addons:
> -      apt:
> -        packages:
> -          - *extra_packages
> -  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
> +  - env: DEF_LIB="static" EXTRA_PACKAGES=1
>      compiler: gcc
>      addons:
>        apt:
> @@ -106,18 +98,6 @@ matrix:
>          packages:
>            - *extra_packages
>            - *doc_packages
> -  - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
> -    compiler: clang
> -    addons:
> -      apt:
> -        packages:
> -          - *extra_packages
> -  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
> -    compiler: clang
> -    addons:
> -      apt:
> -        packages:
> -          - *extra_packages
>    - env: DEF_LIB="static"
>      arch: arm64
>      compiler: gcc
> @@ -146,7 +126,7 @@ matrix:
>        apt:
>          packages:
>            - *required_packages
> -  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" BUILD_DOCS=1
> +  - env: DEF_LIB="shared" BUILD_DOCS=1
>      arch: arm64
>      compiler: gcc
>      addons: