From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46298A0553; Mon, 17 Feb 2020 17:42:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 254121D9C1; Mon, 17 Feb 2020 17:42:44 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 7CCA01C037 for ; Mon, 17 Feb 2020 17:42:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581957763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vI+i+d5oZ7DAOw2sLk0a79VHcwJpZiBNd1xOqvoFDrQ=; b=LFQPrbXPkv8TsA1wjEgfDp9XxQuvbgdAUy6tl8KxxUx7LsNsS8r7jpIa599mzjDSolucuS G+Ql4y3rlAif9OKo3JT6UaYm3p+qFvcg9CjHZarwi+950PoRlSrvqjbeEQvObbAoOEBqcA z0QuVG98vhE9OmwvxEfAc72B9r5KfmY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-ZU9e2dQfMzmjGNXQfobSdQ-1; Mon, 17 Feb 2020 11:42:39 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6D58C107ACC5; Mon, 17 Feb 2020 16:42:38 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.126]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C990E2CC39; Mon, 17 Feb 2020 16:42:37 +0000 (UTC) From: Aaron Conole To: Thomas Monjalon Cc: dev@dpdk.org, Michael Santana References: <20200217113547.1889436-1-thomas@monjalon.net> <20200217113547.1889436-2-thomas@monjalon.net> Date: Mon, 17 Feb 2020 11:42:37 -0500 In-Reply-To: <20200217113547.1889436-2-thomas@monjalon.net> (Thomas Monjalon's message of "Mon, 17 Feb 2020 12:35:46 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: ZU9e2dQfMzmjGNXQfobSdQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thomas Monjalon writes: > The kernel modules are not built by default since below commit. > The Travis CI matrix can be simplified > by removing the redundant option enable_kmods=3Dfalse, > and by removing some jobs which become redundant. > > Note: there is no benefit in checking kmods in Travis Ubuntu. > Anyway different kernel versions and distributions are needed, > and the Technical Board is looking at moving the Linux kmods > out of this repository. > > Signed-off-by: Thomas Monjalon > --- Looks good to me, but do you think there's no benefit to even compiling the kernel modules that get shipped? Otherwise, Acked-by: Aaron Conole > .travis.yml | 28 ++++------------------------ > 1 file changed, 4 insertions(+), 24 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 22539d8238..19422d4b3c 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -38,8 +38,6 @@ before_install: ./.ci/${TRAVIS_OS_NAME}-setup.sh > env: > - DEF_LIB=3D"static" > - DEF_LIB=3D"shared" > - - DEF_LIB=3D"static" OPTS=3D"-Denable_kmods=3Dfalse" > - - DEF_LIB=3D"shared" OPTS=3D"-Denable_kmods=3Dfalse" > - DEF_LIB=3D"shared" RUN_TESTS=3D1 > =20 > matrix: > @@ -50,13 +48,13 @@ matrix: > apt: > packages: > - *build_32b_packages > - - env: DEF_LIB=3D"static" OPTS=3D"-Denable_kmods=3Dfalse" AARCH64=3D1 > + - env: DEF_LIB=3D"static" AARCH64=3D1 > compiler: gcc > addons: > apt: > packages: > - *aarch64_packages > - - env: DEF_LIB=3D"shared" OPTS=3D"-Denable_kmods=3Dfalse" AARCH64=3D1 > + - env: DEF_LIB=3D"shared" AARCH64=3D1 > compiler: gcc > addons: > apt: > @@ -75,13 +73,7 @@ matrix: > packages: > - *extra_packages > - *doc_packages > - - env: DEF_LIB=3D"static" OPTS=3D"-Denable_kmods=3Dfalse" EXTRA_PACKAG= ES=3D1 > - compiler: gcc > - addons: > - apt: > - packages: > - - *extra_packages > - - env: DEF_LIB=3D"shared" OPTS=3D"-Denable_kmods=3Dfalse" EXTRA_PACKAG= ES=3D1 > + - env: DEF_LIB=3D"static" EXTRA_PACKAGES=3D1 > compiler: gcc > addons: > apt: > @@ -106,18 +98,6 @@ matrix: > packages: > - *extra_packages > - *doc_packages > - - env: DEF_LIB=3D"static" OPTS=3D"-Denable_kmods=3Dfalse" EXTRA_PACKAG= ES=3D1 > - compiler: clang > - addons: > - apt: > - packages: > - - *extra_packages > - - env: DEF_LIB=3D"shared" OPTS=3D"-Denable_kmods=3Dfalse" EXTRA_PACKAG= ES=3D1 > - compiler: clang > - addons: > - apt: > - packages: > - - *extra_packages > - env: DEF_LIB=3D"static" > arch: arm64 > compiler: gcc > @@ -146,7 +126,7 @@ matrix: > apt: > packages: > - *required_packages > - - env: DEF_LIB=3D"shared" OPTS=3D"-Denable_kmods=3Dfalse" BUILD_DOCS= =3D1 > + - env: DEF_LIB=3D"shared" BUILD_DOCS=3D1 > arch: arm64 > compiler: gcc > addons: