From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Michael Santana <msantana@redhat.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests
Date: Fri, 02 Aug 2019 09:37:42 -0400 [thread overview]
Message-ID: <f7t5znf7knt.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <CAJFAV8xFun1Xd7qLNZmKL-2TtxaCfPqaUmsNrSq_=06+vdXPDQ@mail.gmail.com> (David Marchand's message of "Thu, 1 Aug 2019 14:29:21 +0200")
David Marchand <david.marchand@redhat.com> writes:
> On Thu, Aug 1, 2019 at 2:28 PM David Marchand <david.marchand@redhat.com> wrote:
>>
>> The memory tests currently check that, for normal mode (not legacy mode),
>> there is no memory left behind when exiting.
>>
>> The problem is that if a ethdev port is allocated when scanning pci
>> devices (even if the driver probe fails like when you have a virtio
>> management interface attached to the kernel), on exit, dpdk won't free
>> the associated memory since ethdev never frees the ethdev memzone.
>>
>> Workaround this by disabling pci scan.
>
> Not entirely happy with this patch.
> I am open to suggestions :-)
Seems like an order of allocation / free issue. Is it possible to
change the order to be consistent? IE: we only allocate something after
we know there's good reason to do so and then we can be sure to always
free? I don't know the code in this area well enough yet to comment any
more than that.
>>
>> Fixes: 651cc78f83b5 ("test: fix hugepage file handling in EAL flags autotest")
>> Fixes: 690fd3577e90 ("test/eal: add cases for in-memory and single-file-segments")
>> Cc: stable@dpdk.org
>
> And we might want to drop stable.
next prev parent reply other threads:[~2019-08-02 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 12:27 [dpdk-dev] " David Marchand
2019-08-01 12:29 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-08-01 13:22 ` Gaëtan Rivet
2019-08-01 13:24 ` David Marchand
2019-08-01 13:26 ` David Marchand
2019-08-02 11:13 ` David Marchand
2019-08-02 13:37 ` Aaron Conole [this message]
2019-08-02 13:45 ` David Marchand
2019-08-02 20:57 ` Thomas Monjalon
2019-08-03 9:51 ` David Marchand
2019-08-05 10:19 ` Thomas Monjalon
2019-08-08 11:23 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7t5znf7knt.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=msantana@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).