From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 796584625E; Tue, 18 Feb 2025 20:45:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 15252402A3; Tue, 18 Feb 2025 20:45:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 260F340264 for ; Tue, 18 Feb 2025 20:45:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739907952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OIDAxaqXYVKgm+iNxZCqsCNC38jDMkbbdg0/WPhb2dc=; b=c8QJGUABrrX/Y856AhwQRxLy6XkPAaO0ncDwWV6mLBvdQ+BP9Nb6qvKrz9teKXA9GhDWdy X324p/tV638QxCrJKs7whcwvY2/ch5FMQnHu5DDnzufkUp60nJd6d8ONmp4IsUsLh23F+a nm3KKV/+oxpxg3uSiK4ZhuOJwcxY0k4= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-466-psqoyVd3P7mHW57u3GOAfQ-1; Tue, 18 Feb 2025 14:45:51 -0500 X-MC-Unique: psqoyVd3P7mHW57u3GOAfQ-1 X-Mimecast-MFC-AGG-ID: psqoyVd3P7mHW57u3GOAfQ_1739907950 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D8E641800879; Tue, 18 Feb 2025 19:45:49 +0000 (UTC) Received: from RHTRH0061144 (unknown [10.22.80.189]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2D7D91800359; Tue, 18 Feb 2025 19:45:47 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, andremue@linux.microsoft.com, Michael Santana Subject: Re: [PATCH] ci: build with MSVC in GHA In-Reply-To: (David Marchand's message of "Tue, 18 Feb 2025 15:10:13 +0100") References: <20250213075010.2670431-1-david.marchand@redhat.com> Date: Tue, 18 Feb 2025 14:45:45 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Vm17EtJmEIeYGdt3Ehp4rVUMu33S18WatOFMAm10_oU_1739907950 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org David Marchand writes: > On Tue, Feb 18, 2025 at 2:32=E2=80=AFPM Aaron Conole = wrote: >> >> David Marchand writes: >> >> > Add a build target in Windows 2022 for MSVC. >> > >> > Loading MSVC environment and having successive commands in a single >> > (cmd or pwsh) shell does not seem to correctly report if one of the >> > commands failed. >> > For now, load MSVC environment and run commands in separate shells. >> > >> > Signed-off-by: David Marchand >> > --- >> >> LGTM. >> >> Acked-by: Aaron Conole >> >> How far back will this work (ie: can we backport this to older branches?= ) > > MSVC was added in 23.11. > The patch applies cleanly and runs on 23.11 (where only lib/kvargs, > lib/log and lib/telemetry are compiled) and 24.11. > > I can add Cc: stable if you think it is worth having it in LTS (UNH > provides some coverage in LTS releases). I usually prefer to back-port CI related changes because it helps us catch issues / improve the stable release cycle.