From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FAA6A0C40; Mon, 29 Mar 2021 20:32:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9287A406B4; Mon, 29 Mar 2021 20:32:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 52B514069D for ; Mon, 29 Mar 2021 20:32:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617042719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DFh1on945Ne+OW1O3O1pFFhr7ONEWdKZEMvKzeIRpRk=; b=akDiUOgqkvh/YY77/y+zS8rA284L0A6v8LwQeDpQek7FKztbPl6CrEikxFnUHKoau1qGfA J88lOwRSu3FDivYm81gqxEw+2dMqAYrUlWH9pZgPNMFZ3d3lf9zuCRE3U9laXKCTrYgSTV doygSr4zUucFUTmJp9p7Ok1LvU7mit8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-aUEvU-YUOsKcgburfCyZ6w-1; Mon, 29 Mar 2021 14:31:57 -0400 X-MC-Unique: aUEvU-YUOsKcgburfCyZ6w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A99E783DD20; Mon, 29 Mar 2021 18:31:55 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-113-108.rdu2.redhat.com [10.10.113.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 69D98196E3; Mon, 29 Mar 2021 18:31:51 +0000 (UTC) From: Aaron Conole To: Ferruh Yigit Cc: "Min Hu \(Connor\)" , dev@dpdk.org, Honnappa Nagarahalli , David Marchand , Thomas Monjalon References: <1616507156-35880-1-git-send-email-humin29@huawei.com> <1616507156-35880-3-git-send-email-humin29@huawei.com> Date: Mon, 29 Mar 2021 14:31:50 -0400 In-Reply-To: (Ferruh Yigit's message of "Mon, 29 Mar 2021 17:10:08 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ferruh Yigit writes: > On 3/23/2021 1:45 PM, Min Hu (Connor) wrote: >> From: Huisong Li >> >> The 'queue_full_cnt' stats have been encapsulated in 'dfx_stats'. >> However, the modification in the SVE algorithm is omitted. >> As a result, the driver fails to be compiled when the SVE >> algorithm is used. >> >> Fixes: 9b77f1fe303f ("net/hns3: encapsulate DFX stats in datapath") >> >> Signed-off-by: Huisong Li >> Signed-off-by: Min Hu (Connor) >> --- >> drivers/net/hns3/hns3_rxtx_vec_sve.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c b/drivers/net/hns3/hns3_rxtx_vec_sve.c >> index f8655fa..e1a1731 100644 >> --- a/drivers/net/hns3/hns3_rxtx_vec_sve.c >> +++ b/drivers/net/hns3/hns3_rxtx_vec_sve.c >> @@ -439,7 +439,7 @@ hns3_xmit_fixed_burst_vec_sve(void *__restrict tx_queue, >> nb_pkts = RTE_MIN(txq->tx_bd_ready, nb_pkts); >> if (unlikely(nb_pkts == 0)) { >> - txq->queue_full_cnt++; >> + txq->dfx_stats.queue_full_cnt++; >> return 0; >> } >> >> > > Hi Connor, > > This is a very obvious build error, I am concerned how this is > released. Do you have any internal testing? > > + Aaron & Honnappa, > > If we can have a build test in our public CI with SVE? Maybe it's possible - we might need to expand the aarch64 cross builds with a bit of extra information. I'm not sure which compiler is needed, though. Currently, we install whatever ubuntu18.04 is providing - I don't know if it has the SVE extensions needed. Honnappa/ARM folks can provide more information that way - though I would expect it's just a setting that can be changed in the host_machine or properties section of the cross-config file. If that's known (maybe we need to use the thunderx2 config or something else? I don't know too much about enabling compiler support for SVE), then we should probably hook it up.