From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id F37FF1B1A5 for ; Mon, 9 Oct 2017 16:00:31 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 34667267C4; Mon, 9 Oct 2017 14:00:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 34667267C4 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=aconole@redhat.com Received: from dhcp-25-97.bos.redhat.com (unknown [10.18.25.172]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AAB416246E; Mon, 9 Oct 2017 14:00:30 +0000 (UTC) From: Aaron Conole To: Ferruh Yigit Cc: John Daley , Nelson Escobar , dev@dpdk.org References: <20170926185329.2776-1-aconole@redhat.com> <516d27ee-d2a8-421b-20b8-4a43edbc0791@intel.com> Date: Mon, 09 Oct 2017 10:00:29 -0400 In-Reply-To: <516d27ee-d2a8-421b-20b8-4a43edbc0791@intel.com> (Ferruh Yigit's message of "Tue, 3 Oct 2017 17:16:54 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 09 Oct 2017 14:00:31 +0000 (UTC) Subject: Re: [dpdk-dev] [RFC 0/4] misc enic fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 14:00:32 -0000 Ferruh Yigit writes: > On 9/26/2017 7:53 PM, Aaron Conole wrote: >> These still need some testing, and I will cc to stable >> with the official patch. >> >> I'm especially interested in the comments on base. >> >> Aaron Conole (4): >> enic: update format string to match arg types >> enic: fix assignment >> enic: remove unused code >> enic: remove anscillary assignment > > Series Reviewed-by: Ferruh Yigit Thanks for the review, Ferruh! > And please add the maintainers to cc next time. Sorry about that. It was sent in haste with John standing next to me - I'll make sure not to repeat the mistake. > Since this is RFC, I assume you will send v1 of the patchset, when > sending v1 can you please add "Fixes:" and "Cc: stable@dpdk.org" tags in > commit log for fixes, these assure patches will be picked by stable tree. Will do. John wanted some early feedback opportunity, so happy to oblige :) > > Thanks, > ferruh