From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 627D9A0542; Fri, 2 Dec 2022 14:39:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F8DF40687; Fri, 2 Dec 2022 14:39:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D8425400D6 for ; Fri, 2 Dec 2022 14:39:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669988392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jx4dPOaWSd1G/8NcmApDiU20z5wrHpI1qYvCbP5R/o0=; b=A+jYPhWIdOF8N8hrCfjbvYVzmQvq2frDRVGIK71QWsbY0cTdZodG47Jx2zPFV59LEOZCbC Uy5gaY85tqZ44CtE0ukXZJmTPcBHJwRx97LYGhoM8LOXS+tql0uxugdV3dRgzXQ3nVrCsl uGC+rO6wtaD5buuP3LegWTLRk+lVUgs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-70-Qr4dLnytP3mMX_JvsIOS_w-1; Fri, 02 Dec 2022 08:39:47 -0500 X-MC-Unique: Qr4dLnytP3mMX_JvsIOS_w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E3BF81C0CE67; Fri, 2 Dec 2022 13:39:46 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.32.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 69A5140C947B; Fri, 2 Dec 2022 13:39:46 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: dev@dpdk.org, ferruh.yigit@amd.com, stable@dpdk.org, Luca Boccassi , Bruce Richardson , Michael Santana , Thomas Monjalon , Abdullah =?utf-8?B?w5ZtZXIgWWFtYcOn?= Subject: Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted References: <20221129140032.35940-1-david.marchand@redhat.com> <20221202110945.519708-1-david.marchand@redhat.com> Date: Fri, 02 Dec 2022 08:39:44 -0500 In-Reply-To: <20221202110945.519708-1-david.marchand@redhat.com> (David Marchand's message of "Fri, 2 Dec 2022 12:09:43 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org David Marchand writes: > ld exports any global symbol by default if no version script is passed. > As a consequence, the incriminated change let any public symbol leak > out of the driver shared libraries. > > Hide again those symbols by providing a default map file which > unexports any global symbol using a local: * catch-all statement. > > The checks are skipped for this default map file as it is intentionnally > an empty map (see commit b67bdda86cd4 ("devtools: catch empty symbol > maps")) and there is nothing else to check in this map. > > This change impacts the exported symbols, hence, bump the version in the > ABI check to the v22.11.1 from the 22.11 LTS branch. > > Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded") > Cc: stable@dpdk.org > > Reported-by: Luca Boccassi > Signed-off-by: David Marchand > Tested-by: Ferruh Yigit > Reviewed-by: Bruce Richardson > --- Acked-by: Aaron Conole