From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FB5FA00C2; Thu, 6 Oct 2022 15:43:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E09E42C67; Thu, 6 Oct 2022 15:43:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 447C342C66 for ; Thu, 6 Oct 2022 15:43:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665063802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3cqoKRTYDXISyfH/suKiwCbqb08Cdp2Tf6XNteEafXw=; b=Svyr6QorscBvRVNdN8/GKOzmGU9rhb4hsVJLczGGnLX03vwm9/WPG64G32s02hfCc7yiJ5 agTyDMNZ5DniyexFrD/JvOutBiCH/ozWpGGyEZmOoaZWg1eNX6Uo48Pt4WTu1oaH0FvgUi FCULOYrDyP6J7QCL3mg/feHfQwmOF1k= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-493-IaoqcK8mO_SbnZjA-8RA5Q-1; Thu, 06 Oct 2022 09:43:19 -0400 X-MC-Unique: IaoqcK8mO_SbnZjA-8RA5Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2F93C1C09C90; Thu, 6 Oct 2022 13:43:19 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.32.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D01B2166B2E; Thu, 6 Oct 2022 13:43:18 +0000 (UTC) From: Aaron Conole To: Morten =?utf-8?Q?Br=C3=B8rup?= Cc: "Andrew Rybchenko" , , , , , "Yuying Zhang" , "Beilei Xing" Subject: Re: [PATCH v2] mempool: fix get objects from mempool with cache References: <98CBD80474FA8B44BF855DF32C47DC35D86DB2@smartserver.smartshare.dk> <20220202081426.77975-1-mb@smartsharesystems.com> <43c333f7-83fa-3072-8db1-8b3a6ece5999@oktetlabs.ru> <98CBD80474FA8B44BF855DF32C47DC35D8738B@smartserver.smartshare.dk> Date: Thu, 06 Oct 2022 09:43:17 -0400 In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8738B@smartserver.smartshare.dk> ("Morten =?utf-8?Q?Br=C3=B8rup=22's?= message of "Tue, 4 Oct 2022 17:13:07 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Morten Br=C3=B8rup writes: > @Aaron, do you have any insights or comments to my curiosity below? Sorry, the perf tests from Feb to Oct should *generally* be comparable but keep in mind that they are based on different baseline versions of DPDK. Also, the perf tests are done as thresholds rather than hard limits (because there can be some minor variations run to run, iirc). >> From: Andrew Rybchenko [mailto:andrew.rybchenko@oktetlabs.ru] >> Sent: Tuesday, 4 October 2022 14.58 >>=20 >> Hi Morten, >>=20 >> In general I agree that the fix is required. >> In sent v3 I'm trying to make it a bit better from my point of >> view. See few notes below. > > I stand by my review and accept of v3 - this message is not intended to c= hange that! I'm just curious... > > I wonder how accurate the automated performance tests ([v2], [v3]) > are, and if they are comparable between February and October? > > [v2]: http://mails.dpdk.org/archives/test-report/2022-February/256462.htm= l > [v3]: http://mails.dpdk.org/archives/test-report/2022-October/311526.html > > > Ubuntu 20.04 > Kernel: 4.15.0-generic > Compiler: gcc 7.4 > NIC: Intel Corporation Ethernet Converged Network Adapter XL710-QDA2 4000= 0 Mbps > Target: x86_64-native-linuxapp-gcc > Fail/Total: 0/4 > > Detail performance results: > ** V2 **: > +----------+-------------+---------+------------+------------------------= ------+ > | num_cpus | num_threads | txd/rxd | frame_size | throughput difference = from | > | | | | | expected = | > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+= =3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D+ > | 1 | 2 | 512 | 64 | 0.5% = | > +----------+-------------+---------+------------+------------------------= ------+ > | 1 | 2 | 2048 | 64 | -1.5% = | > +----------+-------------+---------+------------+------------------------= ------+ > | 1 | 1 | 512 | 64 | 4.3% = | > +----------+-------------+---------+------------+------------------------= ------+ > | 1 | 1 | 2048 | 64 | 10.9% = | > +----------+-------------+---------+------------+------------------------= ------+ > > ** V3 **: > +----------+-------------+---------+------------+------------------------= ------+ > | num_cpus | num_threads | txd/rxd | frame_size | throughput difference = from | > | | | | | expected = | > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+= =3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D+ > | 1 | 2 | 512 | 64 | -0.7% = | > +----------+-------------+---------+------------+------------------------= ------+ > | 1 | 2 | 2048 | 64 | -2.3% = | > +----------+-------------+---------+------------+------------------------= ------+ > | 1 | 1 | 512 | 64 | 0.5% = | > +----------+-------------+---------+------------+------------------------= ------+ > | 1 | 1 | 2048 | 64 | 7.9% = | > +----------+-------------+---------+------------+------------------------= ------+