From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12C2FA04F1; Mon, 9 Dec 2019 19:00:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3789F2C17; Mon, 9 Dec 2019 19:00:41 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 7AD672C12 for ; Mon, 9 Dec 2019 19:00:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575914438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FRiYH+lsepymBUGyxQJwVDYkmYI8F4oZF140qoD9dMw=; b=YhAYJRvCL5whmHKy1D5DSrmZq3dUzgo5jQYslSVl1L/XpwV+vqEVai2DYN6ELuzK+BdzaJ sai3NHiYMPKh6QxTrDMY07T24mj5+fE90R+lSRzE3H0LVBpn9yxGH/kleY4An7Cc6nKLFG GvH5iVqjqc+gDFO+SOqPDmRIGFVw9j8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-315-F4a0H1MWMZyjFLEeGcItiA-1; Mon, 09 Dec 2019 13:00:37 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5A1DA801E7A; Mon, 9 Dec 2019 18:00:35 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B9BB85C1B2; Mon, 9 Dec 2019 18:00:31 +0000 (UTC) From: Aaron Conole To: Ferruh Yigit Cc: "Pattan\, Reshma" , David Marchand , "Rao\, Nikhil" , dev , dpdk stable , Chas Williams , "Richardson\, Bruce" , Stephen Hemminger References: <20191017111628.5396-1-reshma.pattan@intel.com> <20191025153808.31753-1-reshma.pattan@intel.com> <3AEA2BF9852C6F48A459DA490692831F2A4E6F3D@irsmsx110.ger.corp.intel.com> Date: Mon, 09 Dec 2019 13:00:31 -0500 In-Reply-To: (Ferruh Yigit's message of "Mon, 9 Dec 2019 16:54:52 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: F4a0H1MWMZyjFLEeGcItiA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/test: fix build when ring PMD is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ferruh Yigit writes: > On 12/9/2019 1:38 PM, Pattan, Reshma wrote: >>=20 >>=20 >>>>> -----Original Message----- >>>>> From: David Marchand >>>>>> v3: add missing test event_eth_tx_adapter_autotest. >>=20 >> Just wondering, if is it ok to send me the v4 by reverting the test >> case addition from run for this patch to get accepted, as fixing the >> test case can be handled separately. > > Is the root cause of the failures missing '-d' parameter, why not provide= that > instead of not executing the test cases? +1 > David, Aaron, Can it be possible to test providing '-d' paramter in travi= s and > see if it fixes the issue? It's always possible. The best way would be to use one's own github repo and travis-ci instance to test the changes and ensure they are correct. It's also possible to submit a patch to the list that has the change and it will be applied and a build + test should happen. > And what do you think splitting the patch into two, one fixes the build i= ssues > and other adding the missing testcases to the test suit? > > >>=20 >>>> Is this something that Nikhil should look into this as maintainer and = fix in >>> separate patch, I am afraid this is not my area of expertise. >>> >>> I agree that someone knowing of this test should be looking at it. >>> >>> My suggestion on adding this test was based on the fact that we were bu= ilding >>> this code test. >>> But I was expecting that you test this addition. >>> >>> You shall not break the CI :-) +1000 to this >>> Please add this to your checklist for future submissions, or at least c= heck the >>> robot reports. >>> >>> >>> Thanks. >>> >>> -- >>> David Marchand >>=20