From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <aconole@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 80B324A63
 for <dev@dpdk.org>; Tue,  3 Jan 2017 17:06:26 +0100 (CET)
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
 (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id EE2804E4F6;
 Tue,  3 Jan 2017 16:06:26 +0000 (UTC)
Received: from dhcp-25-97.bos.redhat.com (dhcp-25-172.bos.redhat.com
 [10.18.25.172])
 by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 v03G6P9G024272
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 3 Jan 2017 11:06:26 -0500
From: Aaron Conole <aconole@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
References: <1483111580-5397-1-git-send-email-aconole@redhat.com>
 <1909688.GKiQWP6byZ@xps13>
Date: Tue, 03 Jan 2017 11:06:25 -0500
In-Reply-To: <1909688.GKiQWP6byZ@xps13> (Thomas Monjalon's message of "Mon, 02
 Jan 2017 15:22:40 +0100")
Message-ID: <f7t8tqs9lha.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.38]); Tue, 03 Jan 2017 16:06:26 +0000 (UTC)
Subject: Re: [dpdk-dev] [RFC 00/23] Refactor eal_init to remove panic() calls
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jan 2017 16:06:26 -0000

Thomas Monjalon <thomas.monjalon@6wind.com> writes:

> Hi Aaron,
>
> 2016-12-30 10:25, Aaron Conole:
>> In many cases, it's enough to simply let the application know that the
>> call to initialize DPDK has failed.  A complete halt can then be
>> decided by the application based on error returned (and the app could
>> even attempt a possible re-attempt after some corrective action by the
>> user or application).
>> 
>> There is still some work left in this series.
>
> Thanks for starting the work.
> I think it is candidate for 17.05 and can be promoted in the roadmap:
> 	http://dpdk.org/dev/roadmap

Okay.

> Have you checked wether these changes are modifying the API?

That'll be my last pass through.

> Some doxygen comments may need to be updated when a new error code
> is used.

Agreed;  I also want to ensure that there's a consistent set of error
codes, and a consistent place to check for them.

I'll probably prefer to put them in rte_errno.

Thanks for your thoughts, Thomas!