DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH 1/2] ci: bump tested distributions in GHA
@ 2024-01-31 17:44 David Marchand
  2024-01-31 17:44 ` [PATCH 2/2] ci: update versions of actions " David Marchand
  2024-02-08 14:32 ` [PATCH 1/2] ci: bump tested distributions " Aaron Conole
  0 siblings, 2 replies; 5+ messages in thread
From: David Marchand @ 2024-01-31 17:44 UTC (permalink / raw)
  To: dev; +Cc: Aaron Conole, Michael Santana

Fedora 37 has reached end of life in December 2023.
Ubuntu 20.04 is getting quite old.

Switch to more recent versions.

With this move, some packages provided by those distributions are now
recent enough to extend our build coverage.
Install additional dependencies like ipsec-mb, isal and other
libbpf/libxdp devel packages.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 .github/workflows/build.yml | 54 ++++++++++++++++++-------------------
 1 file changed, 27 insertions(+), 27 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index af514e9545..421207c241 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -36,37 +36,37 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          - os: ubuntu-20.04
+          - os: ubuntu-22.04
             compiler: gcc
             mini: mini
-          - os: ubuntu-20.04
+          - os: ubuntu-22.04
             compiler: gcc
             checks: stdatomic
-          - os: ubuntu-20.04
+          - os: ubuntu-22.04
             compiler: clang
             checks: stdatomic
-          - os: ubuntu-20.04
+          - os: ubuntu-22.04
             compiler: gcc
             checks: abi+debug+doc+examples+tests
-          - os: ubuntu-20.04
+          - os: ubuntu-22.04
             compiler: clang
             checks: asan+doc+tests
-          - os: ubuntu-20.04
+          - os: ubuntu-22.04
             compiler: gcc
             library: static
             cross: i386
-          - os: ubuntu-20.04
+          - os: ubuntu-22.04
             compiler: gcc
             library: static
             cross: mingw
-          - os: ubuntu-20.04
+          - os: ubuntu-22.04
             compiler: gcc
             library: shared
             cross: aarch64
-          - os: ubuntu-20.04
+          - os: ubuntu-22.04
             compiler: gcc
             cross: ppc64le
-          - os: ubuntu-20.04
+          - os: ubuntu-22.04
             compiler: gcc
             cross: riscv64
 
@@ -105,10 +105,10 @@ jobs:
     - name: Update APT cache
       run: sudo apt update || true
     - name: Install packages
-      run: sudo apt install -y ccache libarchive-dev libbsd-dev libfdt-dev
-        libibverbs-dev libjansson-dev libnuma-dev libpcap-dev libssl-dev
-        ninja-build pkg-config python3-pip python3-pyelftools python3-setuptools
-        python3-wheel zlib1g-dev
+      run: sudo apt install -y ccache libarchive-dev libbsd-dev libbpf-dev
+        libfdt-dev libibverbs-dev libipsec-mb-dev libisal-dev libjansson-dev
+        libnuma-dev libpcap-dev libssl-dev ninja-build pkg-config python3-pip
+        python3-pyelftools python3-setuptools python3-wheel zlib1g-dev
     - name: Install libabigail build dependencies if no cache is available
       if: env.ABI_CHECKS == 'true' && steps.libabigail-cache.outputs.cache-hit != 'true'
       run: sudo apt install -y autoconf automake libdw-dev libtool libxml2-dev
@@ -162,7 +162,7 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          - image: fedora:37
+          - image: fedora:39
 
     steps:
     - name: Generate various keys
@@ -187,11 +187,11 @@ jobs:
       run: docker exec -i dpdk dnf update -y
     - name: Install packages
       if: steps.image_cache.outputs.cache-hit != 'true'
-      run: docker exec -i dpdk dnf install -y ccache jansson-devel
-        libarchive-devel libatomic libbsd-devel libbpf-devel libfdt-devel
-        libpcap-devel ninja-build numactl-devel openssl-devel python3-pip
-        python3-pyelftools python3-setuptools python3-wheel rdma-core-devel
-        zlib-devel
+      run: docker exec -i dpdk dnf install -y ccache intel-ipsec-mb-devel
+        isa-l-devel jansson-devel libarchive-devel libatomic libbsd-devel
+        libbpf-devel libfdt-devel libpcap-devel libxdp-devel ninja-build
+        numactl-devel openssl-devel python3-pip python3-pyelftools
+        python3-setuptools python3-wheel rdma-core-devel zlib-devel
     - name: Save image in cache
       if: steps.image_cache.outputs.cache-hit != 'true'
       run: |
@@ -211,9 +211,9 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          - image: fedora:37
+          - image: fedora:39
             compiler: gcc
-          - image: fedora:37
+          - image: fedora:39
             compiler: clang
 
     steps:
@@ -262,11 +262,11 @@ jobs:
     - name: Update
       run: docker exec -i dpdk dnf update -y || true
     - name: Install packages
-      run: docker exec -i dpdk dnf install -y ccache jansson-devel
-        libarchive-devel libatomic libbsd-devel libxdp-devel libfdt-devel
-        libpcap-devel ninja-build numactl-devel openssl-devel python3-pip
-        python3-pyelftools python3-setuptools python3-wheel rdma-core-devel
-        zlib-devel
+      run: docker exec -i dpdk dnf install -y ccache intel-ipsec-mb-devel
+        isa-l-devel jansson-devel libarchive-devel libatomic libbsd-devel
+        libbpf-devel libfdt-devel libpcap-devel libxdp-devel ninja-build
+        numactl-devel openssl-devel python3-pip python3-pyelftools
+        python3-setuptools python3-wheel rdma-core-devel zlib-devel
         ${{ matrix.config.compiler }}
     - name: Run setup
       run: docker exec -i dpdk .ci/linux-setup.sh
-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ci: update versions of actions in GHA
  2024-01-31 17:44 [PATCH 1/2] ci: bump tested distributions in GHA David Marchand
@ 2024-01-31 17:44 ` David Marchand
  2024-02-08 14:32   ` Aaron Conole
  2024-02-08 14:32 ` [PATCH 1/2] ci: bump tested distributions " Aaron Conole
  1 sibling, 1 reply; 5+ messages in thread
From: David Marchand @ 2024-01-31 17:44 UTC (permalink / raw)
  To: dev; +Cc: stable, Aaron Conole, Michael Santana

GitHub started deprecating GHA actions based on Node 16 [1].
For now, only warnings are raised, but we might as well switch to v4
versions of the common actions, now.

Link: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 .github/workflows/build.yml | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 421207c241..776fbf6f30 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -72,7 +72,7 @@ jobs:
 
     steps:
     - name: Checkout sources
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
     - name: Generate cache keys
       id: get_ref_keys
       run: |
@@ -80,7 +80,7 @@ jobs:
         echo 'libabigail=libabigail-${{ env.LIBABIGAIL_VERSION }}-${{ matrix.config.os }}' >> $GITHUB_OUTPUT
         echo 'abi=abi-${{ matrix.config.os }}-${{ matrix.config.compiler }}-${{ matrix.config.cross }}-${{ env.REF_GIT_TAG }}' >> $GITHUB_OUTPUT
     - name: Retrieve ccache cache
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       with:
         path: ~/.ccache
         key: ${{ steps.get_ref_keys.outputs.ccache }}-${{ github.ref }}
@@ -88,13 +88,13 @@ jobs:
           ${{ steps.get_ref_keys.outputs.ccache }}-refs/heads/main
     - name: Retrieve libabigail cache
       id: libabigail-cache
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       if: env.ABI_CHECKS == 'true'
       with:
         path: libabigail
         key: ${{ steps.get_ref_keys.outputs.libabigail }}
     - name: Retrieve ABI reference cache
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       if: env.ABI_CHECKS == 'true'
       with:
         path: reference
@@ -143,7 +143,7 @@ jobs:
       run: .ci/linux-build.sh
     - name: Upload logs on failure
       if: failure()
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: meson-logs-${{ join(matrix.config.*, '-') }}
         path: |
@@ -171,7 +171,7 @@ jobs:
         echo 'image=image-${{ matrix.config.image }}-'$(date -u +%Y-%m-%d) >> $GITHUB_OUTPUT
     - name: Retrieve image cache
       id: image_cache
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       with:
         path: ~/.image
         key: ${{ steps.get_keys.outputs.image }}
@@ -218,7 +218,7 @@ jobs:
 
     steps:
     - name: Checkout sources
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
     - name: Generate various keys
       id: get_keys
       run: |
@@ -226,7 +226,7 @@ jobs:
         echo 'logs=meson-logs-${{ join(matrix.config.*, '-') }}' | tr -d ':' >> $GITHUB_OUTPUT
     - name: Retrieve image cache
       id: image_cache
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       with:
         path: ~/.image
         key: ${{ needs.prepare-container-images.outputs.image }}
@@ -236,7 +236,7 @@ jobs:
         echo 'Image ${{ matrix.config.image }} is not cached.'
         false
     - name: Retrieve ccache cache
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       with:
         path: ~/.ccache
         key: ${{ steps.get_keys.outputs.ccache }}-${{ github.ref }}
@@ -276,7 +276,7 @@ jobs:
       run: docker kill dpdk
     - name: Upload logs on failure
       if: failure()
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: ${{ steps.get_keys.outputs.logs }}
         path: |
-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ci: bump tested distributions in GHA
  2024-01-31 17:44 [PATCH 1/2] ci: bump tested distributions in GHA David Marchand
  2024-01-31 17:44 ` [PATCH 2/2] ci: update versions of actions " David Marchand
@ 2024-02-08 14:32 ` Aaron Conole
  2024-02-13  9:35   ` David Marchand
  1 sibling, 1 reply; 5+ messages in thread
From: Aaron Conole @ 2024-02-08 14:32 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Michael Santana

David Marchand <david.marchand@redhat.com> writes:

> Fedora 37 has reached end of life in December 2023.
> Ubuntu 20.04 is getting quite old.
>
> Switch to more recent versions.
>
> With this move, some packages provided by those distributions are now
> recent enough to extend our build coverage.
> Install additional dependencies like ipsec-mb, isal and other
> libbpf/libxdp devel packages.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] ci: update versions of actions in GHA
  2024-01-31 17:44 ` [PATCH 2/2] ci: update versions of actions " David Marchand
@ 2024-02-08 14:32   ` Aaron Conole
  0 siblings, 0 replies; 5+ messages in thread
From: Aaron Conole @ 2024-02-08 14:32 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, stable, Michael Santana

David Marchand <david.marchand@redhat.com> writes:

> GitHub started deprecating GHA actions based on Node 16 [1].
> For now, only warnings are raised, but we might as well switch to v4
> versions of the common actions, now.
>
> Link:
> https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
>
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ci: bump tested distributions in GHA
  2024-02-08 14:32 ` [PATCH 1/2] ci: bump tested distributions " Aaron Conole
@ 2024-02-13  9:35   ` David Marchand
  0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2024-02-13  9:35 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Michael Santana, Aaron Conole

On Thu, Feb 8, 2024 at 3:32 PM Aaron Conole <aconole@redhat.com> wrote:
> > Fedora 37 has reached end of life in December 2023.
> > Ubuntu 20.04 is getting quite old.
> >
> > Switch to more recent versions.
> >
> > With this move, some packages provided by those distributions are now
> > recent enough to extend our build coverage.
> > Install additional dependencies like ipsec-mb, isal and other
> > libbpf/libxdp devel packages.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Aaron Conole <aconole@redhat.com>

Series applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-02-13  9:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-31 17:44 [PATCH 1/2] ci: bump tested distributions in GHA David Marchand
2024-01-31 17:44 ` [PATCH 2/2] ci: update versions of actions " David Marchand
2024-02-08 14:32   ` Aaron Conole
2024-02-08 14:32 ` [PATCH 1/2] ci: bump tested distributions " Aaron Conole
2024-02-13  9:35   ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).