DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: 583493798@qq.com
Cc: dev@dpdk.org, thomas@monjalon.net,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2] ip_frag: fix fragmenting ipv4 packet with header option
Date: Thu, 25 Mar 2021 09:09:18 -0400
Message-ID: <f7ta6qr2xdt.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <tencent_8FA596830F4F89E9E2169503B40DF0FF0307@qq.com> (583493798@qq.com's message of "Thu, 25 Mar 2021 19:11:30 +0800")

583493798@qq.com writes:

> From: Pu Xu <583493798@qq.com>
>
> When fragmenting ipv4 packet, the data offset should be calculated through
> the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr).
>
> Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper library")
>
> Signed-off-by: Pu Xu <583493798@qq.com>
> ---

Thanks for this patch, it looks okay.

Can you please add a test case to app/test/test_ipfrag.c so that we can
catch any breakage in this area in the future?


  reply	other threads:[~2021-03-25 13:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 16:16 [dpdk-dev] [PATCH] " Pu Xu
2021-03-25 10:48 ` [dpdk-dev] [PATCH v2] When fragmenting ipv4 packet, the data offset should be calculated through the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr) 583493798
2021-03-25 11:11 ` [dpdk-dev] [PATCH v2] ip_frag: fix fragmenting ipv4 packet with header option 583493798
2021-03-25 13:09   ` Aaron Conole [this message]
2021-04-06 13:53   ` Ananyev, Konstantin
2021-04-21 14:50     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ta6qr2xdt.fsf@dhcp-25.97.bos.redhat.com \
    --to=aconole@redhat.com \
    --cc=583493798@qq.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=thomas.monjalon@6wind.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git