* [dpdk-dev] [PATCH] meson: remove build warnings
@ 2019-03-18 16:28 Jerin Jacob Kollanukkaran
2019-03-18 16:28 ` Jerin Jacob Kollanukkaran
` (2 more replies)
0 siblings, 3 replies; 16+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-03-18 16:28 UTC (permalink / raw)
To: Thomas Monjalon, Bruce Richardson; +Cc: dev, Jerin Jacob Kollanukkaran
From: Jerin Jacob <jerinj@marvell.com>
Remove the following meson build warnings
1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
but uses features which were added in newer versions:
* 0.48.0: {'console arg in custom_target'}
2) config/arm/meson.build:153: WARNING: Trying to compare values of
different types (list, str) using ==.
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
config/arm/meson.build | 4 ++--
meson.build | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 8e892fa77..170a4981a 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -116,8 +116,8 @@ else
cmd_output = cmd.stdout().to_lower().strip().split(' ')
endif
# Set to generic if variable is not found
- machine = get_variable('impl_' + cmd_output[0], 'generic')
- if machine == 'generic'
+ machine = get_variable('impl_' + cmd_output[0], ['generic'])
+ if machine[0] == 'generic'
machine = impl_generic
cmd_output = cmd_generic
endif
diff --git a/meson.build b/meson.build
index 69833de82..f1abf1e59 100644
--- a/meson.build
+++ b/meson.build
@@ -5,7 +5,7 @@ project('DPDK', 'C',
version: '19.05.0-rc0',
license: 'BSD',
default_options: ['buildtype=release', 'default_library=static'],
- meson_version: '>= 0.47.1'
+ meson_version: '>= 0.48.0'
)
# set up some global vars for compiler, platform, configuration, etc.
--
2.20.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* [dpdk-dev] [PATCH] meson: remove build warnings
2019-03-18 16:28 [dpdk-dev] [PATCH] meson: remove build warnings Jerin Jacob Kollanukkaran
@ 2019-03-18 16:28 ` Jerin Jacob Kollanukkaran
2019-03-18 17:15 ` Luca Boccassi
2019-03-19 17:22 ` [dpdk-dev] [PATCH v2] " Jerin Jacob Kollanukkaran
2 siblings, 0 replies; 16+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-03-18 16:28 UTC (permalink / raw)
To: Thomas Monjalon, Bruce Richardson; +Cc: dev, Jerin Jacob Kollanukkaran
From: Jerin Jacob <jerinj@marvell.com>
Remove the following meson build warnings
1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
but uses features which were added in newer versions:
* 0.48.0: {'console arg in custom_target'}
2) config/arm/meson.build:153: WARNING: Trying to compare values of
different types (list, str) using ==.
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
config/arm/meson.build | 4 ++--
meson.build | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 8e892fa77..170a4981a 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -116,8 +116,8 @@ else
cmd_output = cmd.stdout().to_lower().strip().split(' ')
endif
# Set to generic if variable is not found
- machine = get_variable('impl_' + cmd_output[0], 'generic')
- if machine == 'generic'
+ machine = get_variable('impl_' + cmd_output[0], ['generic'])
+ if machine[0] == 'generic'
machine = impl_generic
cmd_output = cmd_generic
endif
diff --git a/meson.build b/meson.build
index 69833de82..f1abf1e59 100644
--- a/meson.build
+++ b/meson.build
@@ -5,7 +5,7 @@ project('DPDK', 'C',
version: '19.05.0-rc0',
license: 'BSD',
default_options: ['buildtype=release', 'default_library=static'],
- meson_version: '>= 0.47.1'
+ meson_version: '>= 0.48.0'
)
# set up some global vars for compiler, platform, configuration, etc.
--
2.20.1
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [PATCH] meson: remove build warnings
2019-03-18 16:28 [dpdk-dev] [PATCH] meson: remove build warnings Jerin Jacob Kollanukkaran
2019-03-18 16:28 ` Jerin Jacob Kollanukkaran
@ 2019-03-18 17:15 ` Luca Boccassi
2019-03-18 17:15 ` Luca Boccassi
2019-03-19 9:50 ` Bruce Richardson
2019-03-19 17:22 ` [dpdk-dev] [PATCH v2] " Jerin Jacob Kollanukkaran
2 siblings, 2 replies; 16+ messages in thread
From: Luca Boccassi @ 2019-03-18 17:15 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, Thomas Monjalon, Bruce Richardson; +Cc: dev
On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote:
> From: Jerin Jacob <jerinj@marvell.com>
>
> Remove the following meson build warnings
>
> 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
> but uses features which were added in newer versions:
> * 0.48.0: {'console arg in custom_target'}
>
> 2) config/arm/meson.build:153: WARNING: Trying to compare values of
> different types (list, str) using ==.
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> config/arm/meson.build | 4 ++--
> meson.build | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 8e892fa77..170a4981a 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -116,8 +116,8 @@ else
> cmd_output =
> cmd.stdout().to_lower().strip().split(' ')
> endif
> # Set to generic if variable is not found
> - machine = get_variable('impl_' + cmd_output[0],
> 'generic')
> - if machine == 'generic'
> + machine = get_variable('impl_' + cmd_output[0],
> ['generic'])
> + if machine[0] == 'generic'
> machine = impl_generic
> cmd_output = cmd_generic
> endif
> diff --git a/meson.build b/meson.build
> index 69833de82..f1abf1e59 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -5,7 +5,7 @@ project('DPDK', 'C',
> version: '19.05.0-rc0',
> license: 'BSD',
> default_options: ['buildtype=release',
> 'default_library=static'],
> - meson_version: '>= 0.47.1'
> + meson_version: '>= 0.48.0'
> )
>
> # set up some global vars for compiler, platform, configuration,
> etc.
Bumping minimum dependency requirements needs an approval from the tech
board. Incidentally we just got it, and the bump to 0.47.1 just
happened.
You can remove this and ignore the warning about the console arg - it's
harmless if ran on a previous version which does not support it.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [PATCH] meson: remove build warnings
2019-03-18 17:15 ` Luca Boccassi
@ 2019-03-18 17:15 ` Luca Boccassi
2019-03-19 9:50 ` Bruce Richardson
1 sibling, 0 replies; 16+ messages in thread
From: Luca Boccassi @ 2019-03-18 17:15 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, Thomas Monjalon, Bruce Richardson; +Cc: dev
On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote:
> From: Jerin Jacob <jerinj@marvell.com>
>
> Remove the following meson build warnings
>
> 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
> but uses features which were added in newer versions:
> * 0.48.0: {'console arg in custom_target'}
>
> 2) config/arm/meson.build:153: WARNING: Trying to compare values of
> different types (list, str) using ==.
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> config/arm/meson.build | 4 ++--
> meson.build | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 8e892fa77..170a4981a 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -116,8 +116,8 @@ else
> cmd_output =
> cmd.stdout().to_lower().strip().split(' ')
> endif
> # Set to generic if variable is not found
> - machine = get_variable('impl_' + cmd_output[0],
> 'generic')
> - if machine == 'generic'
> + machine = get_variable('impl_' + cmd_output[0],
> ['generic'])
> + if machine[0] == 'generic'
> machine = impl_generic
> cmd_output = cmd_generic
> endif
> diff --git a/meson.build b/meson.build
> index 69833de82..f1abf1e59 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -5,7 +5,7 @@ project('DPDK', 'C',
> version: '19.05.0-rc0',
> license: 'BSD',
> default_options: ['buildtype=release',
> 'default_library=static'],
> - meson_version: '>= 0.47.1'
> + meson_version: '>= 0.48.0'
> )
>
> # set up some global vars for compiler, platform, configuration,
> etc.
Bumping minimum dependency requirements needs an approval from the tech
board. Incidentally we just got it, and the bump to 0.47.1 just
happened.
You can remove this and ignore the warning about the console arg - it's
harmless if ran on a previous version which does not support it.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [PATCH] meson: remove build warnings
2019-03-18 17:15 ` Luca Boccassi
2019-03-18 17:15 ` Luca Boccassi
@ 2019-03-19 9:50 ` Bruce Richardson
2019-03-19 9:50 ` Bruce Richardson
2019-03-27 15:28 ` Aaron Conole
1 sibling, 2 replies; 16+ messages in thread
From: Bruce Richardson @ 2019-03-19 9:50 UTC (permalink / raw)
To: Luca Boccassi; +Cc: Jerin Jacob Kollanukkaran, Thomas Monjalon, dev
On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote:
> On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote:
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > Remove the following meson build warnings
> >
> > 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
> > but uses features which were added in newer versions:
> > * 0.48.0: {'console arg in custom_target'}
> >
> > 2) config/arm/meson.build:153: WARNING: Trying to compare values of
> > different types (list, str) using ==.
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > ---
> > config/arm/meson.build | 4 ++--
> > meson.build | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/config/arm/meson.build b/config/arm/meson.build
> > index 8e892fa77..170a4981a 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -116,8 +116,8 @@ else
> > cmd_output =
> > cmd.stdout().to_lower().strip().split(' ')
> > endif
> > # Set to generic if variable is not found
> > - machine = get_variable('impl_' + cmd_output[0],
> > 'generic')
> > - if machine == 'generic'
> > + machine = get_variable('impl_' + cmd_output[0],
> > ['generic'])
> > + if machine[0] == 'generic'
> > machine = impl_generic
> > cmd_output = cmd_generic
> > endif
> > diff --git a/meson.build b/meson.build
> > index 69833de82..f1abf1e59 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -5,7 +5,7 @@ project('DPDK', 'C',
> > version: '19.05.0-rc0',
> > license: 'BSD',
> > default_options: ['buildtype=release',
> > 'default_library=static'],
> > - meson_version: '>= 0.47.1'
> > + meson_version: '>= 0.48.0'
> > )
> >
> > # set up some global vars for compiler, platform, configuration,
> > etc.
>
> Bumping minimum dependency requirements needs an approval from the tech
> board. Incidentally we just got it, and the bump to 0.47.1 just
> happened.
>
> You can remove this and ignore the warning about the console arg - it's
> harmless if ran on a previous version which does not support it.
>
+1 to this. The first fix is good though - perhaps do a V2 with just that.
Sadly meson warnings for versions have too many false positives right now -
the devs are aware of it, but don't have any good fixes for it yet, as far
as I know. For our case, we will continue to have meson warnings, most of
which are false positives like this one.
Regards,
/Bruce
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [PATCH] meson: remove build warnings
2019-03-19 9:50 ` Bruce Richardson
@ 2019-03-19 9:50 ` Bruce Richardson
2019-03-27 15:28 ` Aaron Conole
1 sibling, 0 replies; 16+ messages in thread
From: Bruce Richardson @ 2019-03-19 9:50 UTC (permalink / raw)
To: Luca Boccassi; +Cc: Jerin Jacob Kollanukkaran, Thomas Monjalon, dev
On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote:
> On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote:
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > Remove the following meson build warnings
> >
> > 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
> > but uses features which were added in newer versions:
> > * 0.48.0: {'console arg in custom_target'}
> >
> > 2) config/arm/meson.build:153: WARNING: Trying to compare values of
> > different types (list, str) using ==.
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > ---
> > config/arm/meson.build | 4 ++--
> > meson.build | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/config/arm/meson.build b/config/arm/meson.build
> > index 8e892fa77..170a4981a 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -116,8 +116,8 @@ else
> > cmd_output =
> > cmd.stdout().to_lower().strip().split(' ')
> > endif
> > # Set to generic if variable is not found
> > - machine = get_variable('impl_' + cmd_output[0],
> > 'generic')
> > - if machine == 'generic'
> > + machine = get_variable('impl_' + cmd_output[0],
> > ['generic'])
> > + if machine[0] == 'generic'
> > machine = impl_generic
> > cmd_output = cmd_generic
> > endif
> > diff --git a/meson.build b/meson.build
> > index 69833de82..f1abf1e59 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -5,7 +5,7 @@ project('DPDK', 'C',
> > version: '19.05.0-rc0',
> > license: 'BSD',
> > default_options: ['buildtype=release',
> > 'default_library=static'],
> > - meson_version: '>= 0.47.1'
> > + meson_version: '>= 0.48.0'
> > )
> >
> > # set up some global vars for compiler, platform, configuration,
> > etc.
>
> Bumping minimum dependency requirements needs an approval from the tech
> board. Incidentally we just got it, and the bump to 0.47.1 just
> happened.
>
> You can remove this and ignore the warning about the console arg - it's
> harmless if ran on a previous version which does not support it.
>
+1 to this. The first fix is good though - perhaps do a V2 with just that.
Sadly meson warnings for versions have too many false positives right now -
the devs are aware of it, but don't have any good fixes for it yet, as far
as I know. For our case, we will continue to have meson warnings, most of
which are false positives like this one.
Regards,
/Bruce
^ permalink raw reply [flat|nested] 16+ messages in thread
* [dpdk-dev] [PATCH v2] meson: remove build warnings
2019-03-18 16:28 [dpdk-dev] [PATCH] meson: remove build warnings Jerin Jacob Kollanukkaran
2019-03-18 16:28 ` Jerin Jacob Kollanukkaran
2019-03-18 17:15 ` Luca Boccassi
@ 2019-03-19 17:22 ` Jerin Jacob Kollanukkaran
2019-03-19 17:22 ` Jerin Jacob Kollanukkaran
2019-03-19 17:36 ` Luca Boccassi
2 siblings, 2 replies; 16+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-03-19 17:22 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, bruce.richardson, bluca, Jerin Jacob Kollanukkaran, stable
From: Jerin Jacob <jerinj@marvell.com>
Remove the following warning by comparing string to string.
config/arm/meson.build:153: WARNING: Trying to compare values of
different types (list, str) using ==.
Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for ARM")
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
v2: Remove meson version related warning as bumbing the version needs
techboard approval.
---
config/arm/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 8e892fa77..170a4981a 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -116,8 +116,8 @@ else
cmd_output = cmd.stdout().to_lower().strip().split(' ')
endif
# Set to generic if variable is not found
- machine = get_variable('impl_' + cmd_output[0], 'generic')
- if machine == 'generic'
+ machine = get_variable('impl_' + cmd_output[0], ['generic'])
+ if machine[0] == 'generic'
machine = impl_generic
cmd_output = cmd_generic
endif
--
2.21.0
^ permalink raw reply [flat|nested] 16+ messages in thread
* [dpdk-dev] [PATCH v2] meson: remove build warnings
2019-03-19 17:22 ` [dpdk-dev] [PATCH v2] " Jerin Jacob Kollanukkaran
@ 2019-03-19 17:22 ` Jerin Jacob Kollanukkaran
2019-03-19 17:36 ` Luca Boccassi
1 sibling, 0 replies; 16+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-03-19 17:22 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, bruce.richardson, bluca, Jerin Jacob Kollanukkaran, stable
From: Jerin Jacob <jerinj@marvell.com>
Remove the following warning by comparing string to string.
config/arm/meson.build:153: WARNING: Trying to compare values of
different types (list, str) using ==.
Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for ARM")
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
v2: Remove meson version related warning as bumbing the version needs
techboard approval.
---
config/arm/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 8e892fa77..170a4981a 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -116,8 +116,8 @@ else
cmd_output = cmd.stdout().to_lower().strip().split(' ')
endif
# Set to generic if variable is not found
- machine = get_variable('impl_' + cmd_output[0], 'generic')
- if machine == 'generic'
+ machine = get_variable('impl_' + cmd_output[0], ['generic'])
+ if machine[0] == 'generic'
machine = impl_generic
cmd_output = cmd_generic
endif
--
2.21.0
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [PATCH v2] meson: remove build warnings
2019-03-19 17:22 ` [dpdk-dev] [PATCH v2] " Jerin Jacob Kollanukkaran
2019-03-19 17:22 ` Jerin Jacob Kollanukkaran
@ 2019-03-19 17:36 ` Luca Boccassi
2019-03-19 17:36 ` Luca Boccassi
2019-03-26 22:32 ` Thomas Monjalon
1 sibling, 2 replies; 16+ messages in thread
From: Luca Boccassi @ 2019-03-19 17:36 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, Thomas Monjalon; +Cc: dev, bruce.richardson, stable
On Tue, 2019-03-19 at 17:22 +0000, Jerin Jacob Kollanukkaran wrote:
> From: Jerin Jacob <jerinj@marvell.com>
>
> Remove the following warning by comparing string to string.
>
> config/arm/meson.build:153: WARNING: Trying to compare values of
> different types (list, str) using ==.
>
> Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for
> ARM")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>
> v2: Remove meson version related warning as bumbing the version needs
> techboard approval.
>
> ---
> config/arm/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 8e892fa77..170a4981a 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -116,8 +116,8 @@ else
> cmd_output =
> cmd.stdout().to_lower().strip().split(' ')
> endif
> # Set to generic if variable is not found
> - machine = get_variable('impl_' + cmd_output[0],
> 'generic')
> - if machine == 'generic'
> + machine = get_variable('impl_' + cmd_output[0],
> ['generic'])
> + if machine[0] == 'generic'
> machine = impl_generic
> cmd_output = cmd_generic
> endif
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [PATCH v2] meson: remove build warnings
2019-03-19 17:36 ` Luca Boccassi
@ 2019-03-19 17:36 ` Luca Boccassi
2019-03-26 22:32 ` Thomas Monjalon
1 sibling, 0 replies; 16+ messages in thread
From: Luca Boccassi @ 2019-03-19 17:36 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, Thomas Monjalon; +Cc: dev, bruce.richardson, stable
On Tue, 2019-03-19 at 17:22 +0000, Jerin Jacob Kollanukkaran wrote:
> From: Jerin Jacob <jerinj@marvell.com>
>
> Remove the following warning by comparing string to string.
>
> config/arm/meson.build:153: WARNING: Trying to compare values of
> different types (list, str) using ==.
>
> Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for
> ARM")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>
> v2: Remove meson version related warning as bumbing the version needs
> techboard approval.
>
> ---
> config/arm/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 8e892fa77..170a4981a 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -116,8 +116,8 @@ else
> cmd_output =
> cmd.stdout().to_lower().strip().split(' ')
> endif
> # Set to generic if variable is not found
> - machine = get_variable('impl_' + cmd_output[0],
> 'generic')
> - if machine == 'generic'
> + machine = get_variable('impl_' + cmd_output[0],
> ['generic'])
> + if machine[0] == 'generic'
> machine = impl_generic
> cmd_output = cmd_generic
> endif
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [PATCH v2] meson: remove build warnings
2019-03-19 17:36 ` Luca Boccassi
2019-03-19 17:36 ` Luca Boccassi
@ 2019-03-26 22:32 ` Thomas Monjalon
2019-03-26 22:32 ` Thomas Monjalon
1 sibling, 1 reply; 16+ messages in thread
From: Thomas Monjalon @ 2019-03-26 22:32 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran; +Cc: dev, Luca Boccassi, bruce.richardson, stable
19/03/2019 18:36, Luca Boccassi:
> On Tue, 2019-03-19 at 17:22 +0000, Jerin Jacob Kollanukkaran wrote:
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > Remove the following warning by comparing string to string.
> >
> > config/arm/meson.build:153: WARNING: Trying to compare values of
> > different types (list, str) using ==.
> >
> > Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for
> > ARM")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>
> Acked-by: Luca Boccassi <bluca@debian.org>
Applied, thanks
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [PATCH v2] meson: remove build warnings
2019-03-26 22:32 ` Thomas Monjalon
@ 2019-03-26 22:32 ` Thomas Monjalon
0 siblings, 0 replies; 16+ messages in thread
From: Thomas Monjalon @ 2019-03-26 22:32 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran; +Cc: dev, Luca Boccassi, bruce.richardson, stable
19/03/2019 18:36, Luca Boccassi:
> On Tue, 2019-03-19 at 17:22 +0000, Jerin Jacob Kollanukkaran wrote:
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > Remove the following warning by comparing string to string.
> >
> > config/arm/meson.build:153: WARNING: Trying to compare values of
> > different types (list, str) using ==.
> >
> > Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for
> > ARM")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>
> Acked-by: Luca Boccassi <bluca@debian.org>
Applied, thanks
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [PATCH] meson: remove build warnings
2019-03-19 9:50 ` Bruce Richardson
2019-03-19 9:50 ` Bruce Richardson
@ 2019-03-27 15:28 ` Aaron Conole
2019-03-27 15:28 ` Aaron Conole
2019-03-27 15:44 ` Luca Boccassi
1 sibling, 2 replies; 16+ messages in thread
From: Aaron Conole @ 2019-03-27 15:28 UTC (permalink / raw)
To: Bruce Richardson
Cc: Luca Boccassi, Jerin Jacob Kollanukkaran, Thomas Monjalon, dev
Bruce Richardson <bruce.richardson@intel.com> writes:
> On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote:
>> On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote:
>> > From: Jerin Jacob <jerinj@marvell.com>
>> >
>> > Remove the following meson build warnings
>> >
>> > 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
>> > but uses features which were added in newer versions:
>> > * 0.48.0: {'console arg in custom_target'}
>> >
>> > 2) config/arm/meson.build:153: WARNING: Trying to compare values of
>> > different types (list, str) using ==.
>> >
>> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>> > ---
>> > config/arm/meson.build | 4 ++--
>> > meson.build | 2 +-
>> > 2 files changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/config/arm/meson.build b/config/arm/meson.build
>> > index 8e892fa77..170a4981a 100644
>> > --- a/config/arm/meson.build
>> > +++ b/config/arm/meson.build
>> > @@ -116,8 +116,8 @@ else
>> > cmd_output =
>> > cmd.stdout().to_lower().strip().split(' ')
>> > endif
>> > # Set to generic if variable is not found
>> > - machine = get_variable('impl_' + cmd_output[0],
>> > 'generic')
>> > - if machine == 'generic'
>> > + machine = get_variable('impl_' + cmd_output[0],
>> > ['generic'])
>> > + if machine[0] == 'generic'
>> > machine = impl_generic
>> > cmd_output = cmd_generic
>> > endif
>> > diff --git a/meson.build b/meson.build
>> > index 69833de82..f1abf1e59 100644
>> > --- a/meson.build
>> > +++ b/meson.build
>> > @@ -5,7 +5,7 @@ project('DPDK', 'C',
>> > version: '19.05.0-rc0',
>> > license: 'BSD',
>> > default_options: ['buildtype=release',
>> > 'default_library=static'],
>> > - meson_version: '>= 0.47.1'
>> > + meson_version: '>= 0.48.0'
>> > )
>> >
>> > # set up some global vars for compiler, platform, configuration,
>> > etc.
>>
>> Bumping minimum dependency requirements needs an approval from the tech
>> board. Incidentally we just got it, and the bump to 0.47.1 just
>> happened.
>>
>> You can remove this and ignore the warning about the console arg - it's
>> harmless if ran on a previous version which does not support it.
>>
>
> +1 to this. The first fix is good though - perhaps do a V2 with just that.
>
> Sadly meson warnings for versions have too many false positives right now -
> the devs are aware of it, but don't have any good fixes for it yet, as far
> as I know. For our case, we will continue to have meson warnings, most of
> which are false positives like this one.
In this case, though, the warning isn't a false positive. Here are the
release notes for 0.48.0 that relate to the argument in question:
https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release-notes-for-0.48.0.md#new-kwarg-console-for-custom_target
I probably missed something.
<rant>
Incidentally, I've dropped my own patch related to this from a series I
was developing to run tests on travis. I think it's a bit annoying that
we need the techboard to decide for cases like these, but I guess that's
just a fact of life.
</rant>
> Regards,
> /Bruce
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [PATCH] meson: remove build warnings
2019-03-27 15:28 ` Aaron Conole
@ 2019-03-27 15:28 ` Aaron Conole
2019-03-27 15:44 ` Luca Boccassi
1 sibling, 0 replies; 16+ messages in thread
From: Aaron Conole @ 2019-03-27 15:28 UTC (permalink / raw)
To: Bruce Richardson
Cc: Luca Boccassi, Jerin Jacob Kollanukkaran, Thomas Monjalon, dev
Bruce Richardson <bruce.richardson@intel.com> writes:
> On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote:
>> On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote:
>> > From: Jerin Jacob <jerinj@marvell.com>
>> >
>> > Remove the following meson build warnings
>> >
>> > 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
>> > but uses features which were added in newer versions:
>> > * 0.48.0: {'console arg in custom_target'}
>> >
>> > 2) config/arm/meson.build:153: WARNING: Trying to compare values of
>> > different types (list, str) using ==.
>> >
>> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>> > ---
>> > config/arm/meson.build | 4 ++--
>> > meson.build | 2 +-
>> > 2 files changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/config/arm/meson.build b/config/arm/meson.build
>> > index 8e892fa77..170a4981a 100644
>> > --- a/config/arm/meson.build
>> > +++ b/config/arm/meson.build
>> > @@ -116,8 +116,8 @@ else
>> > cmd_output =
>> > cmd.stdout().to_lower().strip().split(' ')
>> > endif
>> > # Set to generic if variable is not found
>> > - machine = get_variable('impl_' + cmd_output[0],
>> > 'generic')
>> > - if machine == 'generic'
>> > + machine = get_variable('impl_' + cmd_output[0],
>> > ['generic'])
>> > + if machine[0] == 'generic'
>> > machine = impl_generic
>> > cmd_output = cmd_generic
>> > endif
>> > diff --git a/meson.build b/meson.build
>> > index 69833de82..f1abf1e59 100644
>> > --- a/meson.build
>> > +++ b/meson.build
>> > @@ -5,7 +5,7 @@ project('DPDK', 'C',
>> > version: '19.05.0-rc0',
>> > license: 'BSD',
>> > default_options: ['buildtype=release',
>> > 'default_library=static'],
>> > - meson_version: '>= 0.47.1'
>> > + meson_version: '>= 0.48.0'
>> > )
>> >
>> > # set up some global vars for compiler, platform, configuration,
>> > etc.
>>
>> Bumping minimum dependency requirements needs an approval from the tech
>> board. Incidentally we just got it, and the bump to 0.47.1 just
>> happened.
>>
>> You can remove this and ignore the warning about the console arg - it's
>> harmless if ran on a previous version which does not support it.
>>
>
> +1 to this. The first fix is good though - perhaps do a V2 with just that.
>
> Sadly meson warnings for versions have too many false positives right now -
> the devs are aware of it, but don't have any good fixes for it yet, as far
> as I know. For our case, we will continue to have meson warnings, most of
> which are false positives like this one.
In this case, though, the warning isn't a false positive. Here are the
release notes for 0.48.0 that relate to the argument in question:
https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release-notes-for-0.48.0.md#new-kwarg-console-for-custom_target
I probably missed something.
<rant>
Incidentally, I've dropped my own patch related to this from a series I
was developing to run tests on travis. I think it's a bit annoying that
we need the techboard to decide for cases like these, but I guess that's
just a fact of life.
</rant>
> Regards,
> /Bruce
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [PATCH] meson: remove build warnings
2019-03-27 15:28 ` Aaron Conole
2019-03-27 15:28 ` Aaron Conole
@ 2019-03-27 15:44 ` Luca Boccassi
2019-03-27 15:44 ` Luca Boccassi
1 sibling, 1 reply; 16+ messages in thread
From: Luca Boccassi @ 2019-03-27 15:44 UTC (permalink / raw)
To: Aaron Conole, Bruce Richardson
Cc: Jerin Jacob Kollanukkaran, Thomas Monjalon, dev
On Wed, 2019-03-27 at 11:28 -0400, Aaron Conole wrote:
> Bruce Richardson <
> bruce.richardson@intel.com
> > writes:
>
> > On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote:
> > > On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran
> > > wrote:
> > > > From: Jerin Jacob <
> > > > jerinj@marvell.com
> > > > >
> > > >
> > > > Remove the following meson build warnings
> > > >
> > > > 1) WARNING: Project specifies a minimum meson_version '>=
> > > > 0.47.1'
> > > > but uses features which were added in newer versions:
> > > > * 0.48.0: {'console arg in custom_target'}
> > > >
> > > > 2) config/arm/meson.build:153: WARNING: Trying to compare
> > > > values of
> > > > different types (list, str) using ==.
> > > >
> > > > Signed-off-by: Jerin Jacob <
> > > > jerinj@marvell.com
> > > > >
> > > > ---
> > > > config/arm/meson.build | 4 ++--
> > > > meson.build | 2 +-
> > > > 2 files changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/config/arm/meson.build b/config/arm/meson.build
> > > > index 8e892fa77..170a4981a 100644
> > > > --- a/config/arm/meson.build
> > > > +++ b/config/arm/meson.build
> > > > @@ -116,8 +116,8 @@ else
> > > > cmd_output =
> > > > cmd.stdout().to_lower().strip().split(' ')
> > > > endif
> > > > # Set to generic if variable is not found
> > > > - machine = get_variable('impl_' + cmd_output[0],
> > > > 'generic')
> > > > - if machine == 'generic'
> > > > + machine = get_variable('impl_' + cmd_output[0],
> > > > ['generic'])
> > > > + if machine[0] == 'generic'
> > > > machine = impl_generic
> > > > cmd_output = cmd_generic
> > > > endif
> > > > diff --git a/meson.build b/meson.build
> > > > index 69833de82..f1abf1e59 100644
> > > > --- a/meson.build
> > > > +++ b/meson.build
> > > > @@ -5,7 +5,7 @@ project('DPDK', 'C',
> > > > version: '19.05.0-rc0',
> > > > license: 'BSD',
> > > > default_options: ['buildtype=release',
> > > > 'default_library=static'],
> > > > - meson_version: '>= 0.47.1'
> > > > + meson_version: '>= 0.48.0'
> > > > )
> > > >
> > > > # set up some global vars for compiler, platform,
> > > > configuration,
> > > > etc.
> > >
> > > Bumping minimum dependency requirements needs an approval from
> > > the tech
> > > board. Incidentally we just got it, and the bump to 0.47.1 just
> > > happened.
> > >
> > > You can remove this and ignore the warning about the console arg
> > > - it's
> > > harmless if ran on a previous version which does not support it.
> > >
> >
> > +1 to this. The first fix is good though - perhaps do a V2 with
> > just that.
> >
> > Sadly meson warnings for versions have too many false positives
> > right now -
> > the devs are aware of it, but don't have any good fixes for it yet,
> > as far
> > as I know. For our case, we will continue to have meson warnings,
> > most of
> > which are false positives like this one.
>
> In this case, though, the warning isn't a false positive. Here are
> the
> release notes for 0.48.0 that relate to the argument in question:
>
> https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release-notes-for-0.48.0.md#new-kwarg-console-for-custom_target
>
>
> I probably missed something.
>
> <rant>
> Incidentally, I've dropped my own patch related to this from a series
> I
> was developing to run tests on travis. I think it's a bit annoying
> that
> we need the techboard to decide for cases like these, but I guess
> that's
> just a fact of life.
> </rant>
The warning is correct, but it is harmless - simply the feature won't
be available - I forget exactly what is was for, something to do with
verbose console prints. Functionally speaking there's no difference.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [dpdk-dev] [PATCH] meson: remove build warnings
2019-03-27 15:44 ` Luca Boccassi
@ 2019-03-27 15:44 ` Luca Boccassi
0 siblings, 0 replies; 16+ messages in thread
From: Luca Boccassi @ 2019-03-27 15:44 UTC (permalink / raw)
To: Aaron Conole, Bruce Richardson
Cc: Jerin Jacob Kollanukkaran, Thomas Monjalon, dev
On Wed, 2019-03-27 at 11:28 -0400, Aaron Conole wrote:
> Bruce Richardson <
> bruce.richardson@intel.com
> > writes:
>
> > On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote:
> > > On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran
> > > wrote:
> > > > From: Jerin Jacob <
> > > > jerinj@marvell.com
> > > > >
> > > >
> > > > Remove the following meson build warnings
> > > >
> > > > 1) WARNING: Project specifies a minimum meson_version '>=
> > > > 0.47.1'
> > > > but uses features which were added in newer versions:
> > > > * 0.48.0: {'console arg in custom_target'}
> > > >
> > > > 2) config/arm/meson.build:153: WARNING: Trying to compare
> > > > values of
> > > > different types (list, str) using ==.
> > > >
> > > > Signed-off-by: Jerin Jacob <
> > > > jerinj@marvell.com
> > > > >
> > > > ---
> > > > config/arm/meson.build | 4 ++--
> > > > meson.build | 2 +-
> > > > 2 files changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/config/arm/meson.build b/config/arm/meson.build
> > > > index 8e892fa77..170a4981a 100644
> > > > --- a/config/arm/meson.build
> > > > +++ b/config/arm/meson.build
> > > > @@ -116,8 +116,8 @@ else
> > > > cmd_output =
> > > > cmd.stdout().to_lower().strip().split(' ')
> > > > endif
> > > > # Set to generic if variable is not found
> > > > - machine = get_variable('impl_' + cmd_output[0],
> > > > 'generic')
> > > > - if machine == 'generic'
> > > > + machine = get_variable('impl_' + cmd_output[0],
> > > > ['generic'])
> > > > + if machine[0] == 'generic'
> > > > machine = impl_generic
> > > > cmd_output = cmd_generic
> > > > endif
> > > > diff --git a/meson.build b/meson.build
> > > > index 69833de82..f1abf1e59 100644
> > > > --- a/meson.build
> > > > +++ b/meson.build
> > > > @@ -5,7 +5,7 @@ project('DPDK', 'C',
> > > > version: '19.05.0-rc0',
> > > > license: 'BSD',
> > > > default_options: ['buildtype=release',
> > > > 'default_library=static'],
> > > > - meson_version: '>= 0.47.1'
> > > > + meson_version: '>= 0.48.0'
> > > > )
> > > >
> > > > # set up some global vars for compiler, platform,
> > > > configuration,
> > > > etc.
> > >
> > > Bumping minimum dependency requirements needs an approval from
> > > the tech
> > > board. Incidentally we just got it, and the bump to 0.47.1 just
> > > happened.
> > >
> > > You can remove this and ignore the warning about the console arg
> > > - it's
> > > harmless if ran on a previous version which does not support it.
> > >
> >
> > +1 to this. The first fix is good though - perhaps do a V2 with
> > just that.
> >
> > Sadly meson warnings for versions have too many false positives
> > right now -
> > the devs are aware of it, but don't have any good fixes for it yet,
> > as far
> > as I know. For our case, we will continue to have meson warnings,
> > most of
> > which are false positives like this one.
>
> In this case, though, the warning isn't a false positive. Here are
> the
> release notes for 0.48.0 that relate to the argument in question:
>
> https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release-notes-for-0.48.0.md#new-kwarg-console-for-custom_target
>
>
> I probably missed something.
>
> <rant>
> Incidentally, I've dropped my own patch related to this from a series
> I
> was developing to run tests on travis. I think it's a bit annoying
> that
> we need the techboard to decide for cases like these, but I guess
> that's
> just a fact of life.
> </rant>
The warning is correct, but it is harmless - simply the feature won't
be available - I forget exactly what is was for, something to do with
verbose console prints. Functionally speaking there's no difference.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2019-03-27 15:44 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-18 16:28 [dpdk-dev] [PATCH] meson: remove build warnings Jerin Jacob Kollanukkaran
2019-03-18 16:28 ` Jerin Jacob Kollanukkaran
2019-03-18 17:15 ` Luca Boccassi
2019-03-18 17:15 ` Luca Boccassi
2019-03-19 9:50 ` Bruce Richardson
2019-03-19 9:50 ` Bruce Richardson
2019-03-27 15:28 ` Aaron Conole
2019-03-27 15:28 ` Aaron Conole
2019-03-27 15:44 ` Luca Boccassi
2019-03-27 15:44 ` Luca Boccassi
2019-03-19 17:22 ` [dpdk-dev] [PATCH v2] " Jerin Jacob Kollanukkaran
2019-03-19 17:22 ` Jerin Jacob Kollanukkaran
2019-03-19 17:36 ` Luca Boccassi
2019-03-19 17:36 ` Luca Boccassi
2019-03-26 22:32 ` Thomas Monjalon
2019-03-26 22:32 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).