From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B4AEA0548; Thu, 1 Apr 2021 22:37:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09338140ED6; Thu, 1 Apr 2021 22:37:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 6F3BD406FF for ; Thu, 1 Apr 2021 22:37:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617309441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RSePSXImIbmDNMV8WnajkxX4dcycigzRy1Ek0fYYLZk=; b=P61Tw2JduSEa9HZyBwKMZWCK0GZOGZNn7stb3kTwaVS1lVBXSCrqfEYFwXuN2xMB8MoNHA /juNeT0pGUiONtInIx2GmAS5BUgc6v9Y4kyxx6RYmKTw3NmXhqca4amCRh+iEA3msc7+Nd f+eRRYD9scZEkTEZEn7WZAgkKQJL2Sk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-339-X3I7_fKKOKK3DuEbEpJOQQ-1; Thu, 01 Apr 2021 16:37:19 -0400 X-MC-Unique: X3I7_fKKOKK3DuEbEpJOQQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CEA131005D4F; Thu, 1 Apr 2021 20:37:17 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-113-108.rdu2.redhat.com [10.10.113.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6789A1B528; Thu, 1 Apr 2021 20:37:13 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, stable@dpdk.org, John McNamara References: <20210401195842.13044-1-david.marchand@redhat.com> Date: Thu, 01 Apr 2021 16:37:10 -0400 In-Reply-To: <20210401195842.13044-1-david.marchand@redhat.com> (David Marchand's message of "Thu, 1 Apr 2021 21:58:42 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH] doc: fix sphinx rtd theme import in GHA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: > If the rtd theme is available, passing it by name is enough to select > it. Sphinx itself recognises the "sphinx_rtd_theme" name as a special > case and tries to find its path automatically. > > On the other hand, passing a html_theme_path makes sphinx parse all > themes availables in this path, which in some environment (like GHA) is > /usr/share and makes sphinx error on the first zipfile it finds (in GHA, > some Azure CLI thingy) that has no sphinx theme in it. > > Fixes: 46562be65094 ("doc: import sphinx rtd theme when available") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- https://github.com/ovsrobot/dpdk/tree/series_16066 https://github.com/ovsrobot/dpdk/actions/runs/709682570 Acked-by: Aaron Conole > doc/guides/conf.py | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/doc/guides/conf.py b/doc/guides/conf.py > index aceeb62a4f..ec59aeae7e 100644 > --- a/doc/guides/conf.py > +++ b/doc/guides/conf.py > @@ -20,7 +20,6 @@ > import sphinx_rtd_theme > > html_theme = "sphinx_rtd_theme" > - html_theme_path = [sphinx_rtd_theme.get_html_theme_path()] > except: > print('Install the sphinx ReadTheDocs theme for improved html documentation ' > 'layout: https://sphinx-rtd-theme.readthedocs.io/',