From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87109A3295 for ; Wed, 23 Oct 2019 16:13:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2897A1C20F; Wed, 23 Oct 2019 16:13:48 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id DF0261C20D for ; Wed, 23 Oct 2019 16:13:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571840026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dq9EX9icsTDj70/KtE0W0jQFpF67h2bt/BJ736fjf9A=; b=H6Vc4u5iXjCIfYFIuw/33b/n3KjdNZHnwD9295oJt+an4bTDuqD+5NsndH0hj68iTrmpnf CYytJG0yuG86PdSKAAftIQRWyD4kPZ8TIBrKiQWqatAKF9Ug2dUeouWgfStlvivDHE0N+9 uHzrCAA+1UL12l41LihX9sfa63AT6Ow= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-kvZEUjXLNauWgkcADAnDOg-1; Wed, 23 Oct 2019 10:07:37 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1BEC6801E5C; Wed, 23 Oct 2019 14:06:50 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0435E5C1D8; Wed, 23 Oct 2019 14:06:44 +0000 (UTC) From: Aaron Conole To: Pavan Nikhilesh Bhagavatula Cc: David Marchand , Jerin Jacob Kollanukkaran , Stephen Hemminger , dev , dpdk stable References: Date: Wed, 23 Oct 2019 10:06:44 -0400 In-Reply-To: (Pavan Nikhilesh Bhagavatula's message of "Wed, 23 Oct 2019 08:44:55 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: kvZEUjXLNauWgkcADAnDOg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Pavan Nikhilesh Bhagavatula writes: >>> > >>> >Any review? >>> > >>> >Are we missing an update in the unit test to catch this issue? >>> >Thanks. >>> >>> We actually caught it in a unit test >>> >test_reciprocal_division >> >>We had this problem since the very start then. >> >>Both reciprocal_division and reciprocal_division_perf are in the "perf" >>list. >>Can they be promoted to the standard list? > > Both of these tests take >=3D5 min depending on the platform in use which= is why > they are placed in perf tests. Is it possible to write a smaller set of tests that can be put in the standard list? >> >> >>-- >>David Marchand