From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36593A09E4; Fri, 29 Jan 2021 22:39:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E3CC4067B; Fri, 29 Jan 2021 22:39:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 5663240395 for ; Fri, 29 Jan 2021 22:39:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611956347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+DnRzZjBInMvIyXJHeWNpU+Nv3EQCjWqcUTD0cLcITE=; b=X36FymHMMZexxLz++NXJvm0LDjE1xqVc9uJxvDSNetwalvnxSTdqX3ZhRwBiJ9ueJgSPqm 8uaqVAzzndTQU7rEhUPgBe94JeiIjOgw273hL9bqxPVzEyLg330v1eFBWCsvuPyjk6M51h jgqLXOmLRjDY/PeGstjNHvAjxN0Eatg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-484-5AfamlgUObOJE4m2PFG6rA-1; Fri, 29 Jan 2021 16:39:03 -0500 X-MC-Unique: 5AfamlgUObOJE4m2PFG6rA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 971C01005D55; Fri, 29 Jan 2021 21:39:02 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-114-243.rdu2.redhat.com [10.10.114.243]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A42927046C; Fri, 29 Jan 2021 21:38:58 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: Bruce Richardson , Thomas Monjalon , dev , Michael Santana References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210127173330.1671341-1-bruce.richardson@intel.com> <20210127173330.1671341-9-bruce.richardson@intel.com> <3749594.2Ve71FdZX2@thomas> <20210128114144.GF899@bricha3-MOBL.ger.corp.intel.com> <20210128183415.GM899@bricha3-MOBL.ger.corp.intel.com> Date: Fri, 29 Jan 2021 16:38:57 -0500 In-Reply-To: (David Marchand's message of "Fri, 29 Jan 2021 18:42:17 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH v6 8/8] ci: add checking of includes to CI builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: > On Thu, Jan 28, 2021 at 7:34 PM Bruce Richardson > wrote: >> >> On Thu, Jan 28, 2021 at 11:41:44AM +0000, Bruce Richardson wrote: >> > On Thu, Jan 28, 2021 at 12:12:44PM +0100, Thomas Monjalon wrote: >> > > 27/01/2021 18:33, Bruce Richardson: >> > > > For CI builds, turn on the checking of includes. >> > > > >> > > > Signed-off-by: Bruce Richardson Acked-by: >> > > > Aaron Conole --- .ci/linux-build.sh | 1 + 1 file >> > > > changed, 1 insertion(+) >> > > > >> > > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index >> > > > afa3689a09..fdbeb5a616 100755 --- a/.ci/linux-build.sh +++ >> > > > b/.ci/linux-build.sh @@ -57,6 +57,7 @@ fi OPTS="$OPTS >> > > > -Dmachine=default" OPTS="$OPTS --default-library=$DEF_LIB" OPTS="$OPTS >> > > > --buildtype=debugoptimized" +OPTS="$OPTS -Dcheck_includes=true" >> > > >> > > Which percentage of time does it add on GHA? >> > > >> > I'd have to gather some before/after tests to know for sure, but to check >> > it wasn't too heavy-weight I was just monitoring the log at the end of a >> > build on GHA. The specific build I watched took nearly 15 minutes, and I >> > would guess-timate that the extra task took about 20 seconds of that. >> >> Related to this, and to ensure we don't increase the GHA build time >> massively, is there a reliably way to test this out? Looking at the daily >> builds on GHA I see some successful builds completing in 7.5 mins, while >> others take almost 18 minutes. > > I guess it depends on the changes being tested. > We have a ccache regenerated once a week against the main branch. > That might help compilations for changes on drivers only. > > And it might depend on luck too / the resources available on the > system that runs the tests. > We once hit a case with OVS GHA where the cached DPDK binaries were > built on a system that had a more recent cpu (and this is the reason > why we now build with -Dmachine=default). > > >> The extra build time from this chkincs takes very little time on my own >> system but perhaps we want to limit it to a single build on GHA. I'm not >> very familiar with configuring those builds, so perhaps someone could >> suggest how to do so. > > From what I see in ovsrobot/dpdk/actions logs, the impact is small. +1 - it seems negligible from what I can tell.