From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id A23ABA0569;
Wed, 11 Mar 2020 18:08:28 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 892FA1BF7F;
Wed, 11 Mar 2020 18:08:27 +0100 (CET)
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
[205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 1C4B83B5
for <dev@dpdk.org>; Wed, 11 Mar 2020 18:08:25 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1583946505;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=SiGlDlduWwxzh2toAmUt73vMzeLApsK1CSJejD6wp3k=;
b=hJ1VorySTEKmu0jjCaLHZw+bvcoCVCj+PnngQUX12eGIX00FsuV7tapyiR5oEYAyxTJA5/
zjl/VISxcdzFgeaLb7v95TrIabW5BRIycEwW76PGR9lUaFM6jIovINz59nqZqxcKv9AvY1
kCfLGLVBEoCB2XNocLWCT4bijE3rAaU=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-370-0edLdSo4M3eKI86I5S0M0g-1; Wed, 11 Mar 2020 13:08:23 -0400
X-MC-Unique: 0edLdSo4M3eKI86I5S0M0g-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com
[10.5.11.23])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7A6E28010EB;
Wed, 11 Mar 2020 17:08:22 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.84])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 50E1C19C6A;
Wed, 11 Mar 2020 17:08:19 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Harry van Haaren <harry.van.haaren@intel.com>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>
References: <20200310133304.39951-1-harry.van.haaren@intel.com>
<20200311143927.76021-1-harry.van.haaren@intel.com>
<CAJFAV8zTcyE8Swm-s8R3jQ3pajLV6+HXPHRmwUhqw6KktCm1MQ@mail.gmail.com>
Date: Wed, 11 Mar 2020 13:08:18 -0400
In-Reply-To: <CAJFAV8zTcyE8Swm-s8R3jQ3pajLV6+HXPHRmwUhqw6KktCm1MQ@mail.gmail.com>
(David Marchand's message of "Wed, 11 Mar 2020 17:15:49 +0100")
Message-ID: <f7th7yu7rb1.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting
service lcores
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
David Marchand <david.marchand@redhat.com> writes:
> On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren
> <harry.van.haaren@intel.com> wrote:
>>
>> This commit releases all service cores from their role,
>> returning them to ROLE_RTE on rte_service_finalize().
>>
>> This may fix an issue relating to the service cores causing
>
> You don't seem convinced.
>
>
>> a race-condition on eal_cleanup(), where the service core
>> could still be executing while the main thread has already
>> free-d the service memory, leading to a segfault.
>>
>> Fixes: 21698354c832 ("service: introduce service cores concept")
>> Cc: stable@dpdk.org
>>
>> Reported-by: David Marchand <david.marchand@redhat.com>
>> Reported-by: Aaron Conole <aconole@redhat.com>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
>> Acked-by: Aaron Conole <aconole@redhat.com>
>
> I am okay with merging this so that we stop getting random failures of th=
e ut.
I think it could also potentially cause errors in user applications that
regularly exit, and which use the service core architecture. So it's
worth getting in now, anyway.
> I will let this patch on the ml and apply on Friday at worse.
>
> Please take the time to reply to my question.
> Thanks.