From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B46F0A0548; Mon, 19 Apr 2021 21:29:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2ACD41469; Mon, 19 Apr 2021 21:29:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id B124641459 for ; Mon, 19 Apr 2021 21:29:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618860577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XwPU4JPlCIzNzOv8P9GpzeV2KjHOA4hEZC4QCllnMPE=; b=b/vSBuprXm3vtpqcMY6/UXAW+E+oDceZ0hrSR58mWr6I5FRAjY7eeCknhs/oCyrGOs1tZB lELBt/lhFl1BZyMnUjzCUf2swRMbaw4OmdV+MCbUUoudR+xOmxKRcCa/JKo14teYuS2Vx0 PPMqlCk8piTYAvD6RMVHhyaeEntlpuE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-425-cClY1fK-NQu5Vkg5M-IaDg-1; Mon, 19 Apr 2021 15:29:36 -0400 X-MC-Unique: cClY1fK-NQu5Vkg5M-IaDg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7E4B7193578E; Mon, 19 Apr 2021 19:29:34 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-115-147.rdu2.redhat.com [10.10.115.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 19E9660843; Mon, 19 Apr 2021 19:29:33 +0000 (UTC) From: Aaron Conole To: Thomas Monjalon Cc: Tal Shnaiderman , Dmitry Kozlyuk , "dev\@dpdk.org" , "pallavi.kadam\@intel.com" , "navasile\@linux.microsoft.com" , "dmitrym\@microsoft.com" , ci@dpdk.org References: <20210418170803.15684-1-talshn@nvidia.com> <3259972.HMeeyuY8TW@thomas> Date: Mon, 19 Apr 2021 15:29:32 -0400 In-Reply-To: <3259972.HMeeyuY8TW@thomas> (Thomas Monjalon's message of "Mon, 19 Apr 2021 20:15:43 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [dpdk-ci] [PATCH] eal/windows: fix build warnings in MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thomas Monjalon writes: > 19/04/2021 20:06, Tal Shnaiderman: >> > > 2021-04-18 19:04 (UTC+0000), Tal Shnaiderman: >> > > > > 18/04/2021 19:08, Tal Shnaiderman: >> > > > > > the strncasecmp marco defined in rte_os_shim.h is already >> > > > > > defined in MinGW-w64, as a result the compiler prints out the >> > > > > > warning below on function redefinition whenever compiling a file >> > > > > > including the >> > > header. >> > > > > > >> > > > > > ..\lib/librte_eal/windows/include/rte_os_shim.h:21: >> > > > > > warning: "strncasecmp" redefined #define strncasecmp(s1, s2, >> > > > > > count) _strnicmp(s1, s2, count) >> > > > > >> > > > > Why the tests are passing? Are we allowing warnings in build test? >> > > > >> > > > It's a good question, I see CI is passing without warnings, Dmitry >> > > > can you >> > > reproduce it? >> > > > >> > > > On my side the collision is with the following file: >> > > > >> > > > C:/mingw-w64/x86_64/mingw64/x86_64-w64- >> > > mingw32/include/string.h:119: >> > > > note: this is the location of the previous definition #define >> > > > strncasecmp _strnicmp >> > > > >> > > > I'm using: >> > > > -gcc (x86_64-win32-seh-rev0, Built by MinGW-W64 project) 8.1.0 >> > > > -meson >> > > > 0.53.2 >> > > >> > > I can't reproduce it using the same versions. >> > > Do you invoke meson with other options than "-Dexamples=..."? >> > >> > This is the meson line I'm using: >> > >> > meson "-Dexamples=helloworld" build --wipe --default-library=static -- >> > buildtype debug >> > >> > The problem however is that MinGW's string.h defines the macro in line 119, >> > for some reason my build includes it and the rest doesn't. >> >> Hi Dmitry, >> >> I also noticed warnings in clang on my setup that are related to rte_os_shim.h: >> >> [185/314] Compiling C object drivers/a715181@@tmp_rte_common_mlx5@sta/common_mlx5_mlx5_common_mp.c.obj. >> In file included from ../drivers/common/mlx5/mlx5_common_mp.c:13: >> In file included from ..\drivers\common/mlx5/mlx5_common_utils.h:8: >> In file included from ..\drivers\common/mlx5/mlx5_common.h:17: >> ..\lib/librte_eal/windows/include\rte_os_shim.h:22:51: warning: >> token pasting of ',' and __VA_ARGS__ is a GNU extension >> [-Wgnu-zero-variadic-macro-arguments] >> #define open(path, flags, ...) _open(path, flags, ##__VA_ARGS__) >> ^ >> However don't see it in CI, I'm using clang version 9.0.1 > > It seems we should improve our CI. > Please open suggestions in the CI bugzilla. Please do. Will this only be caught by mingw64 on windows? Will we get the same issues with a linux mingw install? I'm guessing yes, but don't know mingw very well. We may be able to install the mingw package under our github actions pipeline.