DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: Luca Boccassi <bluca@debian.org>
Cc: stable@dpdk.org,
	Alejandro Lucero <alejandro.lucero@netronome.com>,
	Eelco Chaudron <echaudro@redhat.com>,
	Yuanhan Liu <yliu@fridaylinux.org>,
	dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] nfp: restore the unlink operation
Date: Fri, 18 May 2018 11:57:04 -0400	[thread overview]
Message-ID: <f7tin7llzxr.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <1526649742.23337.142.camel@debian.org> (Luca Boccassi's message of "Fri, 18 May 2018 14:22:22 +0100")

Luca Boccassi <bluca@debian.org> writes:

> On Mon, 2018-05-14 at 10:46 -0400, Aaron Conole wrote:
>> For the stable versions of DPDK, the NFP driver's NSP user space
>> driver was modified to account for non-root usage.  When that
>> happened, commit 515933ad8385 ("nfp: allow for non-root user")
>> inadvertently removed the unlink() call.
>> 
>> Fixes: 515933ad8385 ("nfp: allow for non-root user")
>> Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
>> Cc: Luca Boccassi <bluca@debian.org>
>> Cc: Eelco Chaudron <echaudro@redhat.com>
>> Cc: Yuanhan Liu <yliu@fridaylinux.org>
>> Signed-off-by: Aaron Conole <aconole@redhat.com>
>> ---
>>  drivers/net/nfp/nfp_nfpu.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c
>> index ae2e07220..c003640c7 100644
>> --- a/drivers/net/nfp/nfp_nfpu.c
>> +++ b/drivers/net/nfp/nfp_nfpu.c
>> @@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc)
>>  	close(desc->lock);
>>  
>>  	nspu_get_lockfile_path(lockname, sizeof(lockname), desc);
>> +	unlink(lockname);
>>  	return 0;
>>  }
>
> Applied and pushed to stable/18.02

Thanks, Luca!

> Next time, please send patches that are only for stable to stable@dpdk.
> org and do not include dev@dpdk.org

Will do.

> Also use --subject-prefix='PATCH <branch>' so that we can understand
> for which branches a patch is

Thanks.  I'll keep this in mind.

      reply	other threads:[~2018-05-18 15:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14 14:46 Aaron Conole
2018-05-14 15:09 ` Eelco Chaudron
2018-05-18  8:45   ` Alejandro Lucero
2018-05-18  9:48 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-05-18 13:11   ` Aaron Conole
2018-05-18 13:22 ` [dpdk-dev] " Luca Boccassi
2018-05-18 15:57   ` Aaron Conole [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7tin7llzxr.fsf@dhcp-25.97.bos.redhat.com \
    --to=aconole@redhat.com \
    --cc=alejandro.lucero@netronome.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=echaudro@redhat.com \
    --cc=stable@dpdk.org \
    --cc=yliu@fridaylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).