From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <aconole@redhat.com>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id F00C44C57;
 Fri, 18 May 2018 17:57:05 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com
 [10.11.54.4])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 82437406F8B0;
 Fri, 18 May 2018 15:57:05 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 1D4AC2026E03;
 Fri, 18 May 2018 15:57:05 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: Luca Boccassi <bluca@debian.org>
Cc: stable@dpdk.org, Alejandro Lucero <alejandro.lucero@netronome.com>,
 Eelco Chaudron <echaudro@redhat.com>, Yuanhan Liu <yliu@fridaylinux.org>,
 dev@dpdk.org
References: <20180514144658.9671-1-aconole@redhat.com>
 <1526649742.23337.142.camel@debian.org>
Date: Fri, 18 May 2018 11:57:04 -0400
In-Reply-To: <1526649742.23337.142.camel@debian.org> (Luca Boccassi's message
 of "Fri, 18 May 2018 14:22:22 +0100")
Message-ID: <f7tin7llzxr.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.7]); Fri, 18 May 2018 15:57:05 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]);
 Fri, 18 May 2018 15:57:05 +0000 (UTC) for IP:'10.11.54.4'
 DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'aconole@redhat.com' RCPT:''
Subject: Re: [dpdk-dev] [PATCH] nfp: restore the unlink operation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 18 May 2018 15:57:06 -0000

Luca Boccassi <bluca@debian.org> writes:

> On Mon, 2018-05-14 at 10:46 -0400, Aaron Conole wrote:
>> For the stable versions of DPDK, the NFP driver's NSP user space
>> driver was modified to account for non-root usage.=C2=A0=C2=A0When that
>> happened, commit 515933ad8385 ("nfp: allow for non-root user")
>> inadvertently removed the unlink() call.
>>=20
>> Fixes: 515933ad8385 ("nfp: allow for non-root user")
>> Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
>> Cc: Luca Boccassi <bluca@debian.org>
>> Cc: Eelco Chaudron <echaudro@redhat.com>
>> Cc: Yuanhan Liu <yliu@fridaylinux.org>
>> Signed-off-by: Aaron Conole <aconole@redhat.com>
>> ---
>> =C2=A0drivers/net/nfp/nfp_nfpu.c | 1 +
>> =C2=A01 file changed, 1 insertion(+)
>>=20
>> diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c
>> index ae2e07220..c003640c7 100644
>> --- a/drivers/net/nfp/nfp_nfpu.c
>> +++ b/drivers/net/nfp/nfp_nfpu.c
>> @@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc)
>> =C2=A0	close(desc->lock);
>> =C2=A0
>> =C2=A0	nspu_get_lockfile_path(lockname, sizeof(lockname), desc);
>> +	unlink(lockname);
>> =C2=A0	return 0;
>> =C2=A0}
>
> Applied and pushed to stable/18.02

Thanks, Luca!

> Next time, please send patches that are only for stable to stable@dpdk.
> org and do not include dev@dpdk.org

Will do.

> Also use --subject-prefix=3D'PATCH <branch>' so that we can understand
> for which branches a patch is

Thanks.  I'll keep this in mind.