From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A82BA051A; Fri, 17 Jan 2020 14:17:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39F512904; Fri, 17 Jan 2020 14:17:06 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 5B32C28F3 for ; Fri, 17 Jan 2020 14:17:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579267024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9osk0d+4rRBCvWE/NpJBvkcp85Hu2Oa44+Cd/4EYWbU=; b=OuWkW71MjlT+c7dsaP14uv/CohdSIpXhVYlfdpntzUatIbZucURz0YozAPvJNILn0Oic+P 3+EllaAhD18zmjjy+kQo4eINhtgfWgPW03BFszDqaATRC7DnQ5NR0yV7VUDv/L7rF7yhPd pv+n7vLgWsJHnjzptRD1VE66OseRSkw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-wa37tJlxP0CGM1gKAFuLpQ-1; Fri, 17 Jan 2020 08:17:00 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AEE548017CC; Fri, 17 Jan 2020 13:16:59 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-124-121.rdu2.redhat.com [10.10.124.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A461048; Fri, 17 Jan 2020 13:16:56 +0000 (UTC) From: Aaron Conole To: Bruce Richardson Cc: david.marchand@redhat.com, dev@dpdk.org References: <20200117104820.71403-1-bruce.richardson@intel.com> <20200117104820.71403-2-bruce.richardson@intel.com> Date: Fri, 17 Jan 2020 08:16:55 -0500 In-Reply-To: <20200117104820.71403-2-bruce.richardson@intel.com> (Bruce Richardson's message of "Fri, 17 Jan 2020 10:48:20 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: wa37tJlxP0CGM1gKAFuLpQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 2/2] doc: pass "werror" setting through to doc build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Bruce Richardson writes: > When werror is set for the build, we should pass that flag through to > sphinx so that it can flag warnings as errors too. > > Signed-off-by: Bruce Richardson > --- I see that this actually works to generate the errors... BUT if we merge this it will break the build. Can you also insert a patch to address the warning so that the series could be merged? > buildtools/call-sphinx-build.py | 5 ++--- > doc/guides/meson.build | 4 ++++ > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/buildtools/call-sphinx-build.py b/buildtools/call-sphinx-bui= ld.py > index 85c9e0156..fc4e9d040 100755 > --- a/buildtools/call-sphinx-build.py > +++ b/buildtools/call-sphinx-build.py > @@ -9,12 +9,11 @@ > from subprocess import run, PIPE, STDOUT > from distutils.version import StrictVersion > =20 > -(sphinx, src, dst) =3D sys.argv[1:] # assign parameters to variables > +(*sphinx_cmd, src, dst) =3D sys.argv[1:] # assign parameters to variabl= es > =20 > # for sphinx version >=3D 1.7 add parallelism using "-j auto" > -ver =3D run([sphinx, '--version'], stdout=3DPIPE, > +ver =3D run(sphinx_cmd + ['--version'], stdout=3DPIPE, > stderr=3DSTDOUT).stdout.decode().split()[-1] > -sphinx_cmd =3D [sphinx] > if StrictVersion(ver) >=3D StrictVersion('1.7'): > sphinx_cmd +=3D ['-j', 'auto'] > =20 > diff --git a/doc/guides/meson.build b/doc/guides/meson.build > index 732e7ad3a..5a2b854e8 100644 > --- a/doc/guides/meson.build > +++ b/doc/guides/meson.build > @@ -7,6 +7,10 @@ if not sphinx.found() > =09subdir_done() > endif > =20 > +if get_option('werror') > +=09sphinx =3D [sphinx, '-W'] > +endif > + > htmldir =3D join_paths(get_option('datadir'), 'doc', 'dpdk') > html_guides =3D custom_target('html_guides', > =09input: files('index.rst'),