From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 87CAEA2EDB
	for <public@inbox.dpdk.org>; Fri,  6 Sep 2019 16:07:14 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 0524B1F407;
	Fri,  6 Sep 2019 16:07:14 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 8E7BE1F3E9
 for <dev@dpdk.org>; Fri,  6 Sep 2019 16:07:12 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com
 [10.5.11.11])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 7CDD985A07;
 Fri,  6 Sep 2019 14:07:11 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.8])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 9AE88600C4;
 Fri,  6 Sep 2019 14:07:01 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,  Xiaolong Ye
 <xiaolong.ye@intel.com>,  Qi Zhang <qi.z.zhang@intel.com>,  Shepard Siegel
 <shepard.siegel@atomicrules.com>,  Ed Czeck <ed.czeck@atomicrules.com>,
 "John Miller" <john.miller@atomicrules.com>,  Igor Russkikh
 <igor.russkikh@aquantia.com>,  Pavel Belous <pavel.belous@aquantia.com>,
 Allain Legacy <allain.legacy@windriver.com>,  Matt Peters
 <matt.peters@windriver.com>,  Ravi Kumar <ravi1.kumar@amd.com>,  Rasesh
 Mody <rmody@marvell.com>,  Shahed Shaikh <shshaikh@marvell.com>,  Ajit
 Khaparde <ajit.khaparde@broadcom.com>,  Somnath Kotur
 <somnath.kotur@broadcom.com>,  Chas Williams <chas3@att.com>,  Rahul
 Lakkireddy <rahul.lakkireddy@chelsio.com>,  Hemant Agrawal
 <hemant.agrawal@nxp.com>,  Sachin Saxena <sachin.saxena@nxp.com>,  Wenzhuo
 Lu <wenzhuo.lu@intel.com>,  Marcin Wojtas <mw@semihalf.com>,  Michal
 Krawczyk <mk@semihalf.com>,  "Guy Tzalik" <gtzalik@amazon.com>,  Evgeny
 Schemeilin <evgenys@amazon.com>,  Gagandeep Singh <g.singh@nxp.com>,  John
 Daley <johndale@cisco.com>,  "Hyong Youb Kim" <hyonkim@cisco.com>,  Gaetan
 Rivet <gaetan.rivet@6wind.com>,  "Xiao Wang" <xiao.w.wang@intel.com>,
 Ziyang Xuan <xuanziyang2@huawei.com>,  "Xiaoyun Wang"
 <cloud.wangxiaoyun@huawei.com>,  Guoyang Zhou <zhouguoyang@huawei.com>,
 Beilei Xing <beilei.xing@intel.com>,  Jingjing Wu
 <jingjing.wu@intel.com>,  Qiming Yang <qiming.yang@intel.com>,  Rosen Xu
 <rosen.xu@intel.com>,  Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>,  Shijith Thotton
 <sthotton@marvell.com>,  Srisivasubramanian Srinivasan
 <srinivasan@marvell.com>,  Jakub Grajciar <jgrajcia@cisco.com>,  Matan
 Azrad <matan@mellanox.com>,  Shahaf Shuler <shahafs@mellanox.com>,
 Yongseok Koh <yskoh@mellanox.com>,  "Viacheslav Ovsiienko"
 <viacheslavo@mellanox.com>,  Zyta Szpak <zr@semihalf.com>,  "Liron Himi"
 <lironh@marvell.com>,  Tomasz Duszynski <tdu@semihalf.com>,  "Stephen
 Hemminger" <sthemmin@microsoft.com>,  "K. Y. Srinivasan"
 <kys@microsoft.com>,  Haiyang Zhang <haiyangz@microsoft.com>,  Rastislav
 Cernay <cernay@netcope.com>,  Jan Remes <remes@netcope.com>,  Alejandro
 Lucero <alejandro.lucero@netronome.com>,  Tetsuya Mukawa
 <mtetsuyah@gmail.com>,  "Jerin Jacob" <jerinj@marvell.com>,  Nithin
 Dabilpuram <ndabilpuram@marvell.com>,  Kiran Kumar K
 <kirankumark@marvell.com>,  Bruce Richardson <bruce.richardson@intel.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>,  Cristian Dumitrescu
 <cristian.dumitrescu@intel.com>,  Keith Wiles <keith.wiles@intel.com>,
 Maciej Czekaj <mczekaj@marvell.com>,  Maxime Coquelin
 <maxime.coquelin@redhat.com>,  Tiwei Bie <tiwei.bie@intel.com>,  Zhihong
 Wang <zhihong.wang@intel.com>,  Yong Wang <yongwang@vmware.com>,  Thomas
 Monjalon <thomas@monjalon.net>,  <dev@dpdk.org>,  Ivan Ilchenko
 <Ivan.Ilchenko@oktetlabs.ru>
References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com>
 <1567755066-31389-1-git-send-email-arybchenko@solarflare.com>
 <1567755066-31389-18-git-send-email-arybchenko@solarflare.com>
 <f7to8zxo8nm.fsf@dhcp-25.97.bos.redhat.com>
 <6772b880-c445-787b-f954-1dbc477281a0@solarflare.com>
Date: Fri, 06 Sep 2019 10:07:00 -0400
In-Reply-To: <6772b880-c445-787b-f954-1dbc477281a0@solarflare.com> (Andrew
 Rybchenko's message of "Fri, 6 Sep 2019 16:33:09 +0300")
Message-ID: <f7tk1alo6wr.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.26]); Fri, 06 Sep 2019 14:07:12 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v3 17/54] ethdev: change device info get
	callback to return int
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Andrew Rybchenko <arybchenko@solarflare.com> writes:

> On 9/6/19 4:29 PM, Aaron Conole wrote:
>> Andrew Rybchenko <arybchenko@solarflare.com> writes:
>>
>>> From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
>>>
>>> Change eth_dev_infos_get_t return value from void to int.
>>> Make eth_dev_infos_get_t implementations across all drivers to return
>>> negative errno values if case of error conditions.
>>>
>>> Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
>>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>>> ---
>> This patch needs a respin.
>>
>>     ../drivers/net/atlantic/atl_ethdev.c
>>     ../drivers/net/atlantic/atl_ethdev.c:123:12: error: conflicting type=
s for =E2=80=98atl_dev_info_get=E2=80=99
>>      static int atl_dev_info_get(struct rte_eth_dev *dev,
>>                 ^
>>     ../drivers/net/atlantic/atl_ethdev.c:48:13: note: previous declarati=
on of =E2=80=98atl_dev_info_get=E2=80=99 was here
>>      static void atl_dev_info_get(struct rte_eth_dev *dev,
>>
>> Looks like the function prototype appears twice in the .c file - I
>> suggest removing one of them.
>
> It is already done:
> http://git.dpdk.org/next/dpdk-next-net/commit/?id=3D2c9202612408baf748609=
d3ee4e49cc183e0366c

Ahh okay.

I wonder if it's possible to get this patch on mainline?

Strange that it went through -next since it's really a fix.