From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D1EFCA0471 for ; Fri, 21 Jun 2019 16:46:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86D001D524; Fri, 21 Jun 2019 16:46:21 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id F07C91D4B0 for ; Fri, 21 Jun 2019 16:46:19 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3F2FD223869; Fri, 21 Jun 2019 14:46:09 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5C46608D0; Fri, 21 Jun 2019 14:46:07 +0000 (UTC) From: Aaron Conole To: Qiming Yang Cc: dev@dpdk.org References: <1559552722-8970-1-git-send-email-qiming.yang@intel.com> <20190621092132.140460-1-qiming.yang@intel.com> Date: Fri, 21 Jun 2019 10:46:07 -0400 In-Reply-To: <20190621092132.140460-1-qiming.yang@intel.com> (Qiming Yang's message of "Fri, 21 Jun 2019 17:21:29 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 21 Jun 2019 14:46:14 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v5 0/3] Enable rte_flow API in ice driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Qiming Yang writes: > This patch set enables the backend of rte_flow, and the generic > filter related functions in ice driver. Supported flows include > ipv4, tcpv4, udpv4, ipv6, tcpv6, udpv6, tunnel, etc. This patch > set depends on shared code update. > > --- > v2 changes: > - added UDP tunnel port support. > - fixed compile issue. > - added document update. > v3 changes: > - removed redundancy parser. > - added License. > - added VXLAN and NVGRE item support. > v4 changes: > - fixed some typos. > v5 changes: > - fixed checkpatch issues. > Thanks for fixing up the meson errors. I notice some build issues from the Travis server. Can you take a look? https://travis-ci.com/ovsrobot/dpdk/builds/116409374 I think the errors are introduced with the first patch, actually. It might help to use github as an intermediate repository, sign up for travis, push your changes to your github, and then watch the builds to ensure that they are compiling properly. That can help to isolate environmental issues (for instance, accidentally omitted header files, etc). Some of this is documented at doc/guides/contributing/patches.rst but if something is unclear or should have more detail to explain, lets improve the docs.