From: Aaron Conole <aconole@redhat.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix the combined library problems by replacing it with a linker script
Date: Tue, 24 Nov 2015 16:28:25 -0500 [thread overview]
Message-ID: <f7tk2p75bpi.fsf@aconole.bos.csb> (raw)
In-Reply-To: <20151124145518.GA3364@hmsreliant.think-freely.org> (Neil Horman's message of "Tue, 24 Nov 2015 09:55:18 -0500")
Neil Horman <nhorman@tuxdriver.com> writes:
> On Tue, Nov 24, 2015 at 04:31:17PM +0200, Panu Matilainen wrote:
>> The physically linked-together combined library has been an increasing
>> source of problems, as was predicted when library and symbol versioning
>> was introduced. Replace the complex and fragile construction with a
>> simple linker script which achieves the same without all the problems,
>> remove the related kludges from eg mlx drivers.
>>
>> Since creating the linker script is practically zero cost, remove the
>> config option and just create it always.
>>
>> Based on a patch by Sergio Gonzales Monroy, linker script approach
>> initially suggested by Neil Horman.
>>
>> Suggested-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
>> Suggested-by: Neil Horman <nhorman@tuxdriver.com>
>> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
> Nice work
+1, and just for good measure:
Acked-by: Aaron Conole <aconole@redhat.com>
next prev parent reply other threads:[~2015-11-24 21:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 14:31 Panu Matilainen
2015-11-24 14:55 ` Neil Horman
2015-11-24 21:28 ` Aaron Conole [this message]
2015-11-24 22:46 ` Stephen Hemminger
2015-11-25 8:38 ` Panu Matilainen
2015-11-25 13:00 ` Neil Horman
2015-11-25 16:08 ` Stephen Hemminger
2015-11-26 8:05 ` Panu Matilainen
2015-11-30 15:03 ` Neil Horman
2015-11-30 16:41 ` Stephen Hemminger
2015-12-01 12:21 ` Panu Matilainen
2015-12-01 12:36 ` Robie Basak
2015-12-01 13:30 ` Neil Horman
2015-12-08 17:03 ` Robie Basak
2015-12-09 14:16 ` Neil Horman
2015-12-01 13:20 ` Neil Horman
2015-12-01 12:37 ` Robie Basak
2015-12-02 11:44 ` Neil Horman
2015-12-03 1:31 ` Ferruh Yigit
2015-12-03 8:11 ` Christian Ehrhardt
2015-12-03 14:59 ` Neil Horman
2015-12-04 17:19 ` Thomas Monjalon
2015-12-07 8:27 ` Christian Ehrhardt
2015-12-07 10:33 ` Martinx - ジェームズ
2016-02-23 20:07 ` Thomas Monjalon
2016-02-24 9:37 ` Panu Matilainen
2016-02-23 22:20 ` [dpdk-dev] [PATCH v2] mk: replace the combined library " Thomas Monjalon
2016-03-01 13:40 ` Thomas Monjalon
2016-03-01 14:48 ` Panu Matilainen
2016-03-02 12:30 ` Panu Matilainen
2016-03-02 12:40 ` Thomas Monjalon
2016-03-02 12:44 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tk2p75bpi.fsf@aconole.bos.csb \
--to=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).