From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82902A046B for ; Thu, 22 Aug 2019 16:40:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 776011BF6D; Thu, 22 Aug 2019 16:40:39 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 36A481BF6A for ; Thu, 22 Aug 2019 16:40:38 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5BF4C8372EE; Thu, 22 Aug 2019 14:40:37 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC5D18097; Thu, 22 Aug 2019 14:40:36 +0000 (UTC) From: Aaron Conole To: "Burakov\, Anatoly" Cc: "Chaitanya Babu\, TalluriX" , "dev\@dpdk.org" , "Pattan\, Reshma" , "Parthasarathy\, JananeeX M" References: <1566392575-7965-1-git-send-email-tallurix.chaitanya.babu@intel.com> <1566392575-7965-4-git-send-email-tallurix.chaitanya.babu@intel.com> <761FB0F2AB727F4FA9CE98D18810B0155B55F3FA@BGSMSX102.gar.corp.intel.com> Date: Thu, 22 Aug 2019 10:40:36 -0400 In-Reply-To: (Anatoly Burakov's message of "Thu, 22 Aug 2019 11:57:41 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Thu, 22 Aug 2019 14:40:37 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 3/3] app/test: add unit tests for eal vfio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" "Burakov, Anatoly" writes: > On 22-Aug-19 8:18 AM, Chaitanya Babu, TalluriX wrote: >> Hi Aaron, >> >>> -----Original Message----- >>> From: Aaron Conole [mailto:aconole@redhat.com] >>> Sent: Wednesday, August 21, 2019 9:15 PM >>> To: Chaitanya Babu, TalluriX >>> Cc: dev@dpdk.org; Pattan, Reshma ; >>> Parthasarathy, JananeeX M ; >>> Burakov, Anatoly >>> Subject: Re: [dpdk-dev] [PATCH 3/3] app/test: add unit tests for eal vfio >>> >>> Chaitanya Babu Talluri writes: >>> >>>> Unit test cases are added for eal vfio library. >>>> eal_vfio_autotest added to meson build file. >>>> >>>> Signed-off-by: Chaitanya Babu Talluri >>>> >>>> --- >>> >>> Thanks for adding unit tests for the vfio library. >>> >>> In this case, there seems to be some failures - can you help determine the >>> cause: >>> >> As per log we observed >> "EAL: VFIO support not initialized" >> >> Can you Please check if device is binded or not with vfio-pci. >> If device is not binded we might get this error (EAL: VFIO support not initialized). >> >> We have binded the device and observed the tests are running fine as expected. >> >>> https://travis-ci.com/ovsrobot/dpdk/jobs/227066776 >> > > The test should be skipped if VFIO if VFIO is not initialized. +1 - not every developer will have that set up for their systems. And for those developers building drive-by patches, we shouldn't make the unit tests unusable. > I think > we have an API for that, although it is not meant to be used by > application code.